From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 034D02FFDE1; Wed, 11 Mar 2026 13:15:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773234940; cv=none; b=P9tK8J8efpAs2GvtmU5AsjFy524GDJ20y3U+cxLXgGJxwq/6hWrStJnz53kCqARCzSqZBsO1XKHGtueNToeBndFf1jrnKD3WDYyoOnn4zDtw2xW2ou8RE9vwvhku+Ds9DRT34oE/WGhXrSB1omAzzO5/7Yr7RKXKJ0pC4AmDGFM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773234940; c=relaxed/simple; bh=gKZw/onhqWjwSGM+LV5eSnocT7BlAjHAUXpS4NXyE/w=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=loKVSeg1gmjTlzKRRd5fd4CsikeOWmyqQ5bARLEgqB28VXgvba8jxyHkUNbCgcoyXWZNC6ZdI1HOB0AQu5FFWpPbTiQF8816hg1//pOxQyzQ8e4R1dhA08v8MyPTxYjG3+arOgkSEhngDmLi9dMWTLLJ1Dg8aeHmjLzbRaKPNwE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ht4MsTKD; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ht4MsTKD" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1BC09C4CEF7; Wed, 11 Mar 2026 13:15:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1773234939; bh=gKZw/onhqWjwSGM+LV5eSnocT7BlAjHAUXpS4NXyE/w=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ht4MsTKDZD82fBFjqZ5duLvuB+kjQPhTYgDigFbyVuAkbFY1UTNNsc/skkDXXBDTX xmsEBlnNQyjbvLpO7i3X8XPd4Oqzb1/tf/W+SAqbEf83zEvuk9MxSjiy4OaCNiC2xd WD14jCy5s3wDhpCtV+FOXy+gM5jNXgvapB+bGwJ5o+OdlcpK1nledUmn+Qut7ylkCl 2ixIf0jmYQ8ny6w41BFg2rBbleT9+KQWtIY0UUcngqsbX4+0wDrpE8XZNjNVEj168V yy+7uk9cb9nVbVDvUdQ4jT8hzkIov0jDzrZ/YIuxi6porfPSwH4qkxy5T9/vX776T/ NmN3X+Me+7GOA== Date: Wed, 11 Mar 2026 14:15:37 +0100 From: Krzysztof Kozlowski To: Aaron Kling Cc: Liam Girdwood , Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Weidong Wang , Jaroslav Kysela , Takashi Iwai , linux-sound@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Teguh Sobirin Subject: Re: [PATCH 2/2] ASoC: codecs: aw88166: Support device specific firmware Message-ID: <20260311-glittering-elastic-deer-a2fa58@quoll> References: <20260310-aw88166-fw-v1-0-2777563bb673@gmail.com> <20260310-aw88166-fw-v1-2-2777563bb673@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20260310-aw88166-fw-v1-2-2777563bb673@gmail.com> On Tue, Mar 10, 2026 at 11:43:05PM -0500, Aaron Kling wrote: > From: Teguh Sobirin > > This driver currently loads firmware from a hardcoded path. Support > loading device specific firmware when provided by the boot firmware. > > Signed-off-by: Teguh Sobirin > Co-authored-by: Aaron Kling There is no such tag. Also, incomplete DCO chain. > --- > sound/soc/codecs/aw88166.c | 19 +++++++++++++++---- > 1 file changed, 15 insertions(+), 4 deletions(-) > > diff --git a/sound/soc/codecs/aw88166.c b/sound/soc/codecs/aw88166.c > index daee4de9e3b01fb335975a65456cc79575533d7e..52d33a2f7cb12877138ea5083ad42e2777f8d323 100644 > --- a/sound/soc/codecs/aw88166.c > +++ b/sound/soc/codecs/aw88166.c > @@ -1574,18 +1574,22 @@ static int aw88166_dev_init(struct aw88166 *aw88166, struct aw_container *aw_cfg > static int aw88166_request_firmware_file(struct aw88166 *aw88166) > { > const struct firmware *cont = NULL; > + const char *fw_name; > int ret; > > aw88166->aw_pa->fw_status = AW88166_DEV_FW_FAILED; > > - ret = request_firmware(&cont, AW88166_ACF_FILE, aw88166->aw_pa->dev); > + if (device_property_read_string(aw88166->aw_pa->dev, "firmware-name", &fw_name) < 0) > + fw_name = AW88166_ACF_FILE; > + > + ret = request_firmware(&cont, fw_name, aw88166->aw_pa->dev); > if (ret) { > - dev_err(aw88166->aw_pa->dev, "request [%s] failed!\n", AW88166_ACF_FILE); > + dev_err(aw88166->aw_pa->dev, "request [%s] failed!\n", fw_name); > return ret; > } > > dev_dbg(aw88166->aw_pa->dev, "loaded %s - size: %zu\n", > - AW88166_ACF_FILE, cont ? cont->size : 0); > + fw_name, cont ? cont->size : 0); > > aw88166->aw_cfg = devm_kzalloc(aw88166->aw_pa->dev, > struct_size(aw88166->aw_cfg, data, cont->size), GFP_KERNEL); > @@ -1599,7 +1603,7 @@ static int aw88166_request_firmware_file(struct aw88166 *aw88166) > > ret = aw88395_dev_load_acf_check(aw88166->aw_pa, aw88166->aw_cfg); > if (ret) { > - dev_err(aw88166->aw_pa->dev, "load [%s] failed!\n", AW88166_ACF_FILE); > + dev_err(aw88166->aw_pa->dev, "load [%s] failed!\n", fw_name); > return ret; > } > > @@ -1802,9 +1806,16 @@ static const struct i2c_device_id aw88166_i2c_id[] = { > }; > MODULE_DEVICE_TABLE(i2c, aw88166_i2c_id); > > +static const struct of_device_id aw88166_of_match[] = { > + { .compatible = "awinic,aw88166" }, > + { /* sentinel */ } > +}; > +MODULE_DEVICE_TABLE(of, aw88166_of_match); This looks like an unrelated change. Best regards, Krzysztof