From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f51.google.com (mail-ed1-f51.google.com [209.85.208.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 96EFB33F5B3 for ; Wed, 11 Mar 2026 03:13:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773198809; cv=none; b=msKsZtwyxuEjGWdx3frAFGWcYwopPvBlLpquxiKnArNkV/KvUUJ2z0nJbZ4ye/kp+TEnKwg99qTAPNdtXB16CgEpvo5h5gxZ1iG62mmjmwLZakVotEnF+bdHjVlr/YAJOvi2zZvyrQegnptWSwitn6d/eHhvJbwiqtG37FdbwVc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773198809; c=relaxed/simple; bh=ilFdDzG77VDm6EKMrknAxFVIcJv4i5X1KG2wWa20Gq8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=d8zB3mv4Ve7OIutc7LvxNs8ruCuvmWbGz/m1TyiE2WFcLyUY9sqzgjG1jixjDWwwpz0/NbloYHCiI7CbnimcBZgxUB8zmv9wxfkpm27o2WD+M4uQtxyE2tfNeCHy3To2tz5ZiUJvLfgBXR9VaxnmnrQSFizIf83nLevIGpuJX8k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=WWN+rakH; arc=none smtp.client-ip=209.85.208.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="WWN+rakH" Received: by mail-ed1-f51.google.com with SMTP id 4fb4d7f45d1cf-660a293515fso14697781a12.1 for ; Tue, 10 Mar 2026 20:13:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773198807; x=1773803607; darn=vger.kernel.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=STn/LE7jAGdnYlf6ghHyWjMmORMVJ379U1/iWrgh98k=; b=WWN+rakHepEHtbEVlLAuyhry/IVKwY/VhJwcFFLocvweeaQ8VNmQqSB/JojB6P2sqG hWqcFJx+zR5LaABMHzzJI+hdy9o4C+dMjaguAZGgRiGJwdCaftDnyNkipjf+lZGl3a8Z kzdnRXbRgW8rMH0Zk0BCAe5/qacKutLlS0wEXHaVXn4L1IALLenNPKYDFek2zGBTyXR4 3dNlf5u5zQCGXtoQwkXjrGxMPVjGWQT5Aao9AwmEZm5VUJr7eVhqUZ5noK/WyFFhuyM4 1esyK8Ra7KRBfCTXadEovyZQ9MEXv2pMMaomS7h8gxTvLf7y+kFuvDqfBQpKA2y+tTOZ htFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773198807; x=1773803607; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=STn/LE7jAGdnYlf6ghHyWjMmORMVJ379U1/iWrgh98k=; b=da6Kp0JYFE0BVrWoblFAuY/7IbuoXJalPFqwYB4DqFcXsDmywybJQSL3EQ7eu91Nu+ TvaJjkwp+bDwYG02fYeWl7BGSYj5EFKLYWX8fPdnj4aTvCQRsJr1kVCvoCs+5OO2bkDX fEnbiWohuE3iBEAGHZxI0A2BtH9ZrbqMZrhv6SsenqBsq5p3vZemHS8Hy7S+C3wtLL3x VCmXBkO/J2vAcprwKe9WbXsdv+TtwI/t5WxvHU/sru0vUhXHV8lk8M63LKM6aMIH4a76 yQhkJNa0yahh+0MwQJV9ExWcINI89euS8QRcaHTWw7mEA/WDr3qKlG7DImb2fy0TjjXy 1jTQ== X-Forwarded-Encrypted: i=1; AJvYcCXCXVFbnd9qVgXr2mCB6BbQ0cbYj75gRuhwMJcVJaUyl2v9Y6Sfi9BFpAG+e/uVXCWGZkKP2yEe2xNz4ss=@vger.kernel.org X-Gm-Message-State: AOJu0YwdX6cKZIZ3GNsP8AnPI0/Gkxfrn8wqcyNbl7RXsW34IZef6SK/ jP4vD4Rpa56xyD27nkZiwZWttR1qYFjynfw+1GZePKD6sW5NppKIZIpm X-Gm-Gg: ATEYQzy2DT8ewH/kfa/vt0OXtl5GyiSfmrA5GPnmuEQikMp+I14k9tS5qiU5vtb2V3u WyiDgd3+/m95H/4DgTglQGoecCawItWw2haUex6x2JaBqrV72C5iUdYWTfiV6RM8ZxN0OiSJEtx iwnXUHonEjvVWdZQQBxm7TUz3vi6cNp+/IsaMYeVRvbXskm4HHe+yZXtVJDKa9SZkrXyzkc7USz 1zAEID05rTkML4EZah3ugiPonFE1Lmu9NV3rtnKqT2SXG9TX6rh4iUpBbXuLEyyuNKn9H3kSSMY j+B1zwj0U3O2I52IDlIVa82iKA3NJ3T4NcplWxtQ1AxboEkMPKps9Niqp4BLT/vsKg+h9V2FgX3 61iuNK5r6qRJVbg1Bv3SO/ynhU9BYCsiVXiXDMXKyEszIOB6/eq9GNirg9uXBnn6fB6/KYs8pRx DPoe0+S8cAyF5JFtSjJLiDsQ== X-Received: by 2002:a17:907:1b13:b0:b88:6542:86a0 with SMTP id a640c23a62f3a-b972e59297dmr39950766b.54.1773198806661; Tue, 10 Mar 2026 20:13:26 -0700 (PDT) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b972e1be45dsm22497166b.64.2026.03.10.20.13.26 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 10 Mar 2026 20:13:26 -0700 (PDT) Date: Wed, 11 Mar 2026 03:13:26 +0000 From: Wei Yang To: Breno Leitao Cc: Andrew Morton , David Hildenbrand , Lorenzo Stoakes , Zi Yan , Baolin Wang , "Liam R. Howlett" , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Lance Yang , Vlastimil Babka , Suren Baghdasaryan , Michal Hocko , Brendan Jackman , Johannes Weiner , Mike Rapoport , linux-mm@kvack.org, linux-kernel@vger.kernel.org, usamaarif642@gmail.com, kas@kernel.org, kernel-team@meta.com, "Lorenzo Stoakes (Oracle)" Subject: Re: [PATCH v5 3/4] mm: huge_memory: refactor enabled_store() with change_enabled() Message-ID: <20260311031325.7dfjig3w3ee5udqt@master> Reply-To: Wei Yang References: <20260310-thp_logs-v5-0-686099175bf6@debian.org> <20260310-thp_logs-v5-3-686099175bf6@debian.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260310-thp_logs-v5-3-686099175bf6@debian.org> User-Agent: NeoMutt/20170113 (1.7.2) On Tue, Mar 10, 2026 at 10:57:09AM -0700, Breno Leitao wrote: >Refactor enabled_store() to use a new change_enabled() helper. >Introduce a separate enum global_enabled_mode and >global_enabled_mode_strings[], mirroring the anon_enabled_mode >pattern from the previous commit. > >A separate enum is necessary because the global THP setting does >not support "inherit", only "always", "madvise", and "never". >Reusing anon_enabled_mode would leave a NULL gap in the string >array, causing sysfs_match_string() to stop early and fail to >match entries after the gap. > >The helper uses the same loop pattern as set_anon_enabled_mode(), >iterating over an array of flag bit positions and using >__test_and_set_bit()/__test_and_clear_bit() to track whether the state >actually changed. > >Signed-off-by: Breno Leitao >Reviewed-by: Lorenzo Stoakes (Oracle) Reviewed-by: Wei Yang -- Wei Yang Help you, Help me