From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f51.google.com (mail-ot1-f51.google.com [209.85.210.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 45A862FDC3C for ; Wed, 11 Mar 2026 15:02:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773241365; cv=none; b=jXzzj1YMw2sZsdjLTu4MYKpWAzPjOps+sTkEzSrntWA0wxcuvT2LUVgzlkFUAzhFjsLAbDLLkJ2r9m2cPbuNMVqIrvkFLYKpKs3kVnxvHivlvcuzwNc6FLJM5xJM959M0cbpcUGYkM6MoxWGbyw+jbAQ4gXO51dBN65Djvrdwoo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773241365; c=relaxed/simple; bh=KSIu965BR9xA34yWpWzXwjBlcvjtLsvWwOmdlSdhm1k=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=B9WpaMBHQ4zKlvHzyDgbrH6kCg9uYD/wrxCRIBxfWWtf7qHWeBkAg572WYrIucfx8oGKz1ehJ4yBKfWXGPiBCQ9qvOH7qykhqiosHwVh4qJ5P99jm7yWOLX8riE0MGN9tDeNDfC2cwzBGy380Wceevkv54HnER5hrIhlcbDjyuw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=PVo/shbD; arc=none smtp.client-ip=209.85.210.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="PVo/shbD" Received: by mail-ot1-f51.google.com with SMTP id 46e09a7af769-7d73be007a1so21986a34.0 for ; Wed, 11 Mar 2026 08:02:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773241363; x=1773846163; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=cXQ57kKM6BGHnOjMhBIqOh965QFWXPvn5ljLxWRi0mg=; b=PVo/shbDVd6F7MtMHDuEmrB3J2H44ngoFAcEmokdRBVbP9Q410GaemHLbKtg35hSqk iwCD8ZZdBUG8xLhKGL4tXIbDIucZdOVA0vFQ/F1UrRNIPcHH9Nuh9c71hKzN9abQfU8Y lbl4hEaTWlxmR4DNQpuy4zbvM197sX57hmgaPMeyxkK9DBbYjoK6BmI4EWDFh3zBlx2s XwqyUJWfNfFy5fESPLkRyHdHAYI/mlYxAGR3vrlkff90FEW1gV1LuOORbNwm7W59RDlx Lc4CWtDHLIjaXFSOxgy32S4jvCRepaTfb9t2lRmT12tYGiG/h7vkQIrM+fNfXiZ4k65M 0eQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773241363; x=1773846163; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=cXQ57kKM6BGHnOjMhBIqOh965QFWXPvn5ljLxWRi0mg=; b=Qm3wr0F+pATqqOQZiPlIWaqe5WoYiHHRwQcYfvZfaQ4pWTFw44lbCsfTyHGj3t8l+h aGNpUnS1F4L+sE0AiuK3WRH4yodSHbM6Owpp9zgYAzV8gomVnh0vypJ27t8noNfDQze6 +VpbEuTdwd/Fi98Bste1WKrJszkekIqs18kvEFO2tLs+vTDMS0z6zyRXPKGeFBSYnLNU bN+xaDpQHX/VXmbAK5sawE4YpBVjVCeQlVaObBDoP0aXtQdj9eeKex42rfnoS3eBxD31 Lg9/nP+K9fy1eNb+3fHGvgTZ4t1r9BDThifNXx6GZ848gUCVsRepBchMVFBD+8UawOFk 335g== X-Forwarded-Encrypted: i=1; AJvYcCVhQMZv9OluXBf4P3STKZooFpXMM72oJvzJPNguIxqQJvwOhFtOuLRUO4wqtVp58btZ1rdjyFyOfWsUQO4=@vger.kernel.org X-Gm-Message-State: AOJu0YxtWs9olh0/2VMEA79s3Rg9XfMOkWgGeMXq74NDgn/xhwQEC3Ua SJks4vwM65VISErCXe8RFT/XyAC2AXyZTGnvKuHLj3VGI+eIhn7B67ax X-Gm-Gg: ATEYQzy4Q6tDIv3l6gfEpboPUU2sqr7cy/OnbVekh9+1T797FQox73QwDIKP0zAa6PL Jpk0TaglItPxNNL9scEeqgK63+M/Tbs7TMeYeOC+lpn2uRzjbiRmAXcjMh3+MaB2jSRCBSQGLJQ f5UAU2v+IAOoBvqxonfz9l7j6ihVIPcu8+UC50i43fkyAUBOoUP4Nfv3SPtaDXvxWWxWilGqD7E srLTuk21Fz+9G4wJunSUnUp8uIr1ahLib1cNwdMENQPscpO5xCnO8k7af05NUUX6CYcbt3jZDgM 0wq4mIUMSapaOdYw1iWUfy7BFfOrTonMydVCX52HLPc51zumTjGnRQ5PNkqvmEjpfUsCVg5nEjk 8+ceoE4eiI3G6Wdjl5W3S6rI+4ECUhRpDQTnEipXF3pLyEbHOJRv5n3XcIKsDOJ5UDkW0tWLv5Q hvhnYF1fIpF7Lc13pSW6SalA== X-Received: by 2002:a05:6830:91c:b0:7d1:93e7:cd6f with SMTP id 46e09a7af769-7d76a77354bmr1856158a34.13.1773241363016; Wed, 11 Mar 2026 08:02:43 -0700 (PDT) Received: from localhost ([2a03:2880:10ff:70::]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7d76ac8975csm2026328a34.8.2026.03.11.08.02.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Mar 2026 08:02:42 -0700 (PDT) From: Joshua Hahn To: Alexandre Ghiti Cc: akpm@linux-foundation.org, alexghiti@kernel.org, kernel-team@meta.com, akinobu.mita@gmail.com, david@kernel.org, lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com, vbabka@kernel.org, rppt@kernel.org, surenb@google.com, mhocko@suse.com, hannes@cmpxchg.org, zhengqi.arch@bytedance.com, shakeel.butt@linux.dev, axelrasmussen@google.com, yuanchu@google.com, weixugc@google.com, gourry@gourry.net, apopple@nvidia.com, byungchul@sk.com, joshua.hahnjy@gmail.com, matthew.brost@intel.com, rakie.kim@sk.com, ying.huang@linux.alibaba.com, ziy@nvidia.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/4] mm: Rename node_get_allowed_targets() to make it more explicit Date: Wed, 11 Mar 2026 08:02:40 -0700 Message-ID: <20260311150241.2579851-1-joshua.hahnjy@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260311110314.237315-3-alex@ghiti.fr> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit On Wed, 11 Mar 2026 12:02:41 +0100 Alexandre Ghiti wrote: > This function actually returns the tier nodes that are targeted during a > demotion, so rename it to be more explicit. > > No functional change intended. Agreed, node_get_allowed_targets is pretty vague ; -) I do think that node_get_allowed_demotion_targets could be considered a bit too long, but I don't think it's called in too many places where there would be more than just this function call in the line so LGTM! Please feel free to add my review tag, have a great day Alexandre! Reviewed-by: Joshua Hahn > Signed-off-by: Alexandre Ghiti > --- > include/linux/memory-tiers.h | 6 +++--- > mm/memory-tiers.c | 4 ++-- > mm/vmscan.c | 2 +- > 3 files changed, 6 insertions(+), 6 deletions(-)