From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oi1-f173.google.com (mail-oi1-f173.google.com [209.85.167.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7DDED38D01D for ; Wed, 11 Mar 2026 20:22:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773260560; cv=none; b=bnMqLGatVvU1Rs5VtJV4E2W00jvnnQdvktX5WFUhMdPUoToie+PfHwcMp6k9MmHC6oyOtHkUnpK2n+s/M06VqX8wikLFt/RKlHLqUbu/1j533w4OfubFFxJyXWOUonYBmRLBO7gwNvIwnIF5wWLMsIiojrsEDZvYmcFELOI94Bk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773260560; c=relaxed/simple; bh=jB2oMvtjSlTt4fVzJfxYs7QB0QpySnep/Y2yZ6amjhw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=noXZFLSiNYXyZilcmFzDvDrIPxx7kRR0yW2tMv4kqEMyOYbII9c8+LGk2l6gbaUqm5/+/dqMunJh32XWDzeDcm7hMC1bH4g4u/7VLX1rwR7ZPYHoNkoa16voSGkPLk0cT3HZdXt7jtoHs96z0U8vXFOwhtf6VbRFOtaoBAgMl2I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=EuqO/YgQ; arc=none smtp.client-ip=209.85.167.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="EuqO/YgQ" Received: by mail-oi1-f173.google.com with SMTP id 5614622812f47-46704fbf62dso223211b6e.1 for ; Wed, 11 Mar 2026 13:22:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773260558; x=1773865358; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=lDadkc9uehD2Q82HtUQ1xvN3p0rzr8EBQuFGGMiWazg=; b=EuqO/YgQdGHBNcg4CCSUHDiLIJsNAIGvXoghAVbSRQLYbyF8g+r6O53xrmPaDErnf7 CchtW1WTlXC+lSnA9KyHUopVOuRtT5bOvtnvHGVfyF4zHnq/5IyFZ7kBKsSgeyPEZhSi U8e3UIy4RTbkJOW4FsiEh8IYgOu5mi0wMnZDTVYVnZsg+Z33GKC3at3m0DCJgwopeUdi aXuAkg8Mr4BZOtJ/QouHQaMh/5OEN+hPzF0GtJ2gn5LV859kT4Zp/K2pxnOpDp2DN36W TbGp4ttihOyTB8sLvlSU2+97AZFfbkVODE5XYLtzPdKVlmhgud/Jj0HuV/9LI7PZMnIF VgDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773260558; x=1773865358; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=lDadkc9uehD2Q82HtUQ1xvN3p0rzr8EBQuFGGMiWazg=; b=wyg0X4czz9kG/q3xrHT6pW5kJ5ym3WLZlgDj3vZf9geetNg4kIKXhiBLMHkjlN82no MVT8sWm5pUQsxczTmC+lKBvoJauAGP4KyW1bTTWpV4BoR9RpjIReTCWTc9cGktkJlCw3 9HKB6ikarUvFAeNR4PX89KJIvMpq6kNH0XItCrsFesW3Elvt9dDq11gP1fgg404GWEmU ydNcHv3g8zw3vA3B0e49NIRkviYaDCq3RPV9nLey6DVoVRotD7wX46mU+WJUeisc4G50 svOW7ZpbHtjHithR85ESFwno1R/skeCzsCWSti5fnxfLGefD1Gi8lEfUkx4KA+/JQFB/ tteQ== X-Forwarded-Encrypted: i=1; AJvYcCVFgY5JCHC0iFWm4nFLDrjolUFlUkr0h/7yXFbSEgST8RH2z0FaZVFxYqfzYyzDKVqGFgML7kWsh7HFcQU=@vger.kernel.org X-Gm-Message-State: AOJu0Yx3PYdeH9hxtlNdPL/isjprFg4Khx1nCTtVWQqyQ7DiXlFg6s65 CIghxZx8SutuHSbhSJH9p7ojn4zVVK2648iRjmGjdeIrugeHZAUuDaVZ X-Gm-Gg: ATEYQzw+KgPTsmIPpmYhiXtXBDgRPQaVI6kpu0Z37Fc9VmMaNNQetehqz3xsDzH4/8E HYw2qPHkeLokXwf5VR7FQ0+wY3uf/XU1v8xq9niKWHXvKnZov+1Xl1terwov3KYltt9u3uUrkhb DKeaZbIbSSXrY40cIdX+vpjDtsJkeYyESMyDutjJAvqrYsjBEDKt1q7mpfoEhje2QHs8muLjBP0 TGl6L+HatuQ2i9VUC5U/gTZQ18n7xIBHTCNqW0J4gFjUDMLaL3zJrkJjauVVU9dGwFEWz+jXBsI qNBtnxaV28XGYNdvCBtH04ing4UFY3YMZg+hRcb33GMxw2KCZXvzgsbSNiFW1IW3mjMmIJ3lGhe t99Y4Wof7HoOfGEPsGKo4dKx8E49Sss0a++LSAkFMQH4HXcowW4fmEO9y9D2y38VVJqr6JkRZNR ocjRzwWs4o7WRCiWYmQYA9bQ== X-Received: by 2002:a05:6808:4f54:b0:45c:881c:e0c0 with SMTP id 5614622812f47-4673359c4a7mr2171831b6e.47.1773260558347; Wed, 11 Mar 2026 13:22:38 -0700 (PDT) Received: from localhost ([2a03:2880:10ff:70::]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-4177e268f37sm2889525fac.6.2026.03.11.13.22.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Mar 2026 13:22:37 -0700 (PDT) From: Joshua Hahn To: Nhat Pham Cc: Minchan Kim , Sergey Senozhatsky , Johannes Weiner , Harry Yoo , Yosry Ahmed , Nhat Pham , Chengming Zhou , Andrew Morton , linux-mm@kvack.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@meta.com Subject: Re: [PATCH 04/11] mm/zsmalloc: Introduce objcgs pointer in struct zspage Date: Wed, 11 Mar 2026 13:22:28 -0700 Message-ID: <20260311202230.294520-1-joshua.hahnjy@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On Wed, 11 Mar 2026 13:17:22 -0700 Nhat Pham wrote: > On Wed, Mar 11, 2026 at 12:52 PM Joshua Hahn wrote: > > > > Introduce an array of struct obj_cgroup pointers to zspage to keep track > > of compressed objects' memcg ownership, if the zs_pool has been made to > > be memcg-aware at creation time. > > > > Move the error path for alloc_zspage to a jump label to simplify the > > growing error handling path for a failed zpdesc allocation. > > > > Suggested-by: Johannes Weiner > > Suggested-by: Harry Yoo > > Signed-off-by: Joshua Hahn > > --- > > mm/zsmalloc.c | 34 ++++++++++++++++++++++++++-------- > > 1 file changed, 26 insertions(+), 8 deletions(-) > > > > diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c > > index 3f0f42b78314..dcf99516227c 100644 > > --- a/mm/zsmalloc.c > > +++ b/mm/zsmalloc.c > > @@ -39,6 +39,7 @@ > > #include > > #include > > #include > > +#include > > #include "zpdesc.h" > > > > #define ZSPAGE_MAGIC 0x58 > > @@ -273,6 +274,7 @@ struct zspage { > > struct zpdesc *first_zpdesc; > > struct list_head list; /* fullness list */ > > struct zs_pool *pool; > > + struct obj_cgroup **objcgs; > > struct zspage_lock zsl; > > }; > > > > @@ -825,6 +827,8 @@ static void __free_zspage(struct zs_pool *pool, struct size_class *class, > > zpdesc = next; > > } while (zpdesc != NULL); > > > > + if (pool->memcg_aware) > > + kfree(zspage->objcgs); > > cache_free_zspage(zspage); > > > > class_stat_sub(class, ZS_OBJS_ALLOCATED, class->objs_per_zspage); > > @@ -946,6 +950,16 @@ static struct zspage *alloc_zspage(struct zs_pool *pool, > > if (!IS_ENABLED(CONFIG_COMPACTION)) > > gfp &= ~__GFP_MOVABLE; > > > > + if (pool->memcg_aware) { > > + zspage->objcgs = kcalloc(class->objs_per_zspage, > > + sizeof(struct obj_cgroup *), > > + gfp & ~__GFP_HIGHMEM); > > I remembered asking this, so my apologies if I missed/forgot your > response - but would vmalloc work here? i.e kvcalloc to fallback to > vmalloc etc.? Hello Nhat : -) Thank you for reviewing, and for your acks on the other parts! You're right, I missed changing that on my end after v1. No reason vmalloc shouldn't work here, let me make that change in v3. Thanks, I hope you have a great day! Joshua