From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f193.google.com (mail-pg1-f193.google.com [209.85.215.193]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0468F2EB5A6 for ; Thu, 12 Mar 2026 03:31:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.193 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773286277; cv=none; b=CguoR221/LpkNbRTRYLMlgR270+ODsSdOUfL9Ef6iMm1s2wBJm8cP+0Fs+AU3OiKIeJCi9NSxvZoDuSRFAZlZNCZoeXvYbG9sBPsiWCk9FC0/zBF9Wm514eRjXhV7EdY3qIlZ09xfW9FTLfDAkT/39cg/bdNM+b22fOSzsUPmaw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773286277; c=relaxed/simple; bh=ZSoeiRTvYCDwKbXm60wX4BwY98Pc1hsahjf3gGCu4jo=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=WNGjcu91S1VRbRKHoCp8uzld0L+yx0ImYuVrryOK84fi2c39gZ9uN6FFWF3Xi6vMT7OZFTikroNptq2LkpkgWPdniDPQg54eEzz8QTGHdSWpqeR7mvycvl5x98otu+gRSiRdqhMF8Aq9LcDBIx89GV8Ksrj8CFv+k/bEOm81of8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=YL/vKADm; arc=none smtp.client-ip=209.85.215.193 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YL/vKADm" Received: by mail-pg1-f193.google.com with SMTP id 41be03b00d2f7-c739d32b72cso319902a12.2 for ; Wed, 11 Mar 2026 20:31:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773286275; x=1773891075; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=AL8nEFmYbr0Vo7ZxbIIIA5WrHWg/oaxX1oMLgJ1GQQU=; b=YL/vKADmhGRbonlJVqlpa7llP6XKceRrT4vFcfg1fkow1Bd2ls1UF1HSyaPV53/jvM DxxCXrQ2s0r7mEn1VcGd0GkCkRzzWrMi/WS50QOmGkR2jiivIWyEaUw4322IRU85OmSK lIoF+xDO5EWP4s5C1cBUWdVjawdmaYybSuJFQZOp3MuwHCIkbkqFc5E4w/iryjsd0BqI 2cqlXm7C49xkG63Rl7ymidawtlWnd9bt1TSqOD+9uceT2lhYUn79Wn0Kfhc563ga2Ekc 7Y7Wn/oHe8UCzP6/szTas+4w1htZU15Lp8CGGH6yOSpzBLGSnGjiocKZKT5NxFPWUhyu lCuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773286275; x=1773891075; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=AL8nEFmYbr0Vo7ZxbIIIA5WrHWg/oaxX1oMLgJ1GQQU=; b=ZWmmnBMdjqEDunFnjyEYdgTk966TWIPLfqrpYxxtMBp1QLcMmd6TwOkMYVDAfF0qxI qIwsfCOs9IJWXK/hKfHfrfDycMC6iK2UNpHn43kZwmbeTFRtdwWh6APaSOiD0dsNHK7s 4C62K+GFvAHKVgb5h6G3Ffhv8wL6vZg5mAbm4V8YF8rf3CwkJK9zmJbK8EfKF1w5RY4t tY0wfYGWBrf6urMGgmmlK+GQGVWpj1LTNS2X+hxqRqm2ZPZPOIEyUnl6/tAE5Ga9NDpu 07jgDQ7bsLIHuLS6/u+tlqfP252IsXuRCsMzg/KU4b0sC2BUrQsZBWb4QvVnGv72rb8S iwbA== X-Forwarded-Encrypted: i=1; AJvYcCVcmT0aotVFty3qhT0wm5izvcmLxoYpN9WnUaalE/e8lkm7bEV4uetdltdl/QUauiiyoACMt/v629wCKWg=@vger.kernel.org X-Gm-Message-State: AOJu0Yyt3qVPNTWEorAFBqHwD99s48QEPl7S5ah8nPZQF3RJ9W0dhjTD LSGM1fiUi60/tRkbAZ0YX68GZ+U+uYHyuCwZBTRKi7JBYvLYS34PMCoo X-Gm-Gg: ATEYQzyBStaRsMTgTQz4+/6D+Pbk3OOs7a/WB6SmKVQJuS+/IbC1GHSbu3qelmu3fD/ vRUx/qHZc2xS8xdFsX/o494nmOnEpUj8xfD9K9AFR+0qHLm0Nj0wUouD+/k/yUYvtgmkJ7Xe8FP rexWuLx0Y1BgBaGi37v1hQ5Qa+bmTy3ygaBZT8Jko8cWT8Zqnx7Au08ZdYc3bVYKJfiz5yrRB7n 0iI94+yvA2whV3uUNwWXMHS+9pZPlf7AuQO3XLWuwj16lt+s4l39r4wK4EYbBTDEDF8VAQyCXde a/QwjB6uDDRtOx8i//9hLoieLcDRrMBrmcFqMcUdgC98rDpiEFTxQlZo7dU+8O60nB9MLDevupN 5hn3EdG+73uxDEdioY5utsRWyBJ9CecN/d2xSUJAhXXaNZ3aQa6jwjoWMHSDz4l3wpHrJgujZe3 Bv0tMhTq4jGkNTksWIzn4WGX3yB+iTzXHXdsLBKSPh0EuYM1xBlQ== X-Received: by 2002:a05:6a20:9183:b0:398:8321:7499 with SMTP id adf61e73a8af0-398c60b41camr4402926637.37.1773286275256; Wed, 11 Mar 2026 20:31:15 -0700 (PDT) Received: from lima-ubuntu.hz.ali.com ([47.246.98.213]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c73cdf0e498sm3542770a12.3.2026.03.11.20.31.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Mar 2026 20:31:14 -0700 (PDT) From: Qing Wang To: vbabka@kernel.org Cc: akpm@linux-foundation.org, cl@gentwo.org, hao.li@linux.dev, harry.yoo@oracle.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, rientjes@google.com, roman.gushchin@linux.dev, wangqing7171@gmail.com Subject: Re: [PATCH] slab: remove alloc_full_sheaf() Date: Thu, 12 Mar 2026 11:31:05 +0800 Message-Id: <20260312033105.593829-1-wangqing7171@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260311-b4-slab-remove-alloc_full_sheaf-v1-1-c4c5bb587ae5@kernel.org> References: <20260311-b4-slab-remove-alloc_full_sheaf-v1-1-c4c5bb587ae5@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit On Thu, 12 Mar 2026 at 02:22, "Vlastimil Babka (SUSE)" wrote: > - if (!full) > + if (refill_sheaf(s, empty, gfp | __GFP_NOMEMALLOC | __GFP_NOWARN)) { > + /* > + * we must be very low on memory so don't bother > + * with the barn > + */ > + sheaf_flush_unused(s, empty); > + free_empty_sheaf(s, empty); > + > return NULL; > + } > + > + full = empty; > + empty = NULL; 'empty = NULL' is meaningless since 'empty' is not used after here. > > if (!local_trylock(&s->cpu_sheaves->lock)) > goto barn_put; > pcs = this_cpu_ptr(s->cpu_sheaves); > > /* > - * If we are returning empty sheaf, we either got it from the > - * barn or had to allocate one. If we are returning a full > - * sheaf, it's due to racing or being migrated to a different > - * cpu. Breaching the barn's sheaf limits should be thus rare > - * enough so just ignore them to simplify the recovery. > + * If we put any empty or full sheaf to the barn below, it's due to > + * racing or being migrated to a different cpu. Breaching the barn's > + * sheaf limits should be thus rare enough so just ignore them to > + * simplify the recovery. > */ > > if (pcs->main->size == 0) { LGTM. Reviewed-by: Qing Wang -- Cheers, Qing