From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7CD892DECDE for ; Thu, 12 Mar 2026 07:04:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.95.11.211 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773299043; cv=none; b=YjKbYJaJ1GkdzXs82Zan9NOTkwgfASxYn6hdHJl9GKtcyAHf3T/IyoLycD007ZIYSCzUDHL4qVJs0FOtnTuRpqLxLmKft3cR0dZk9Sxe8YczSmkbxYStjwWHZaj1Ww2RUAdtZCVotTK6/haURZg3NjRfiJacQLOqdRxpe9hfwCg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773299043; c=relaxed/simple; bh=Djtflw+UPN8mrqORsGP6qfy+VVO9F5jSRvCrRCJLZqU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=h3Gb8u7ctU6wOjxlzqYpKF/gt09qUQIeViLV86Ej06i36pMQOrwVI95JMT/ljplrmSrZIUa+oy6ckHXZHc/zGK3A/6ykEksy9vmwFxrIGRkJa5Luh8F3tCGpxqiHs9UGJf2Sl1uSwyShi+Px/BJPE5JEuMu4JNh8SZoO6sjJyvg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lst.de; spf=pass smtp.mailfrom=lst.de; arc=none smtp.client-ip=213.95.11.211 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lst.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lst.de Received: by verein.lst.de (Postfix, from userid 2407) id C9A3268BFE; Thu, 12 Mar 2026 08:03:55 +0100 (CET) Date: Thu, 12 Mar 2026 08:03:54 +0100 From: Christoph Hellwig To: Randy Dunlap Cc: linux-kernel@vger.kernel.org, Keith Busch , Jens Axboe , Christoph Hellwig , Sagi Grimberg , linux-nvme@lists.infradead.org Subject: Re: [PATCH] nvme-tcp.h: correct kernel-doc comments Message-ID: <20260312070354.GA27358@lst.de> References: <20260312051431.684352-1-rdunlap@infradead.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260312051431.684352-1-rdunlap@infradead.org> User-Agent: Mutt/1.5.17 (2007-11-01) On Wed, Mar 11, 2026 at 10:14:31PM -0700, Randy Dunlap wrote: > Mark reserved fields as "private:" so that kernel-doc comments are > not required for them. I'm honestly not sure the kerneldoc makes any sense for an on-disk structure that has an external specification. So insteada of these hacks, what about just dropping the kerneldoc comment entirely?