From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f180.google.com (mail-qt1-f180.google.com [209.85.160.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A096B30B51D for ; Thu, 12 Mar 2026 13:41:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773322914; cv=none; b=QuLY0BMweIK324Yq2nIurSJX8icuOPal0f3ALZ5Pv2rfwhcephYygHf4qJJOGRAI/WhhAxECMRsauujdfN/tqVOwTtIUAsqbqPxPfUK3oCLEaCYJFfzCnwUZV1hL9A1El0z+5cmSpP0n/Ld/Yy2t/3aNlqSFd2y9NC2EKt5of5w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773322914; c=relaxed/simple; bh=dI/azoJAlajelMailovq8TyNO1fCclqei3qlPfzJK9Q=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=D06M+DUvEIw6Gg2/sf8tZbtdCkbQGmoUf01PpGKL/a3pl7hyBMqOn2wFCNQEnG+mZPrAW6gUEjF5syozKTjPvvrxpUuK2jzDmmmKZYTrl+SOY8Xr40GUHAiwnaKvua0bOD52KDNrRGGgoVLkyEQjaD82VEog1SeqBpeWbpBD1ao= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca; spf=pass smtp.mailfrom=ziepe.ca; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b=cusr1pCD; arc=none smtp.client-ip=209.85.160.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="cusr1pCD" Received: by mail-qt1-f180.google.com with SMTP id d75a77b69052e-50919fc3a14so11908711cf.2 for ; Thu, 12 Mar 2026 06:41:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1773322912; x=1773927712; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=o5dFx0wHNh8e3LinTTG/Y3HW59wuwEbRT1tQ1nd6tlk=; b=cusr1pCDMaoOgY5fMpQ4Pf/PuV1IzxkJXE5WI4Rj94D/ZrSLTYuQEEWqb5e5ldNeP1 tsWKD3HH8aApJVp7Xb+ZJszzn59/jDNvbwRnvLBW01AIWbNNo05G4WLwDVwVsHNrT3oo kcG6mrGDW2RJfSdb3AEwCUjMwrKyQhnpg7xyCVjCQrCCWVYRlHq1RUjH0buc6igOac7+ sxyN0VFcD2h97UM5jOeTZwgRRvsfXXCFHCJeThwhkIdV7LcHrnwywu/f809foi3e/FbT hrtemdXxMQKy5ieQVdHPoyXB7kzUa4LjngGca8Ks5dgUw5WiHlk8kGreaiE9yuIyXobF yxNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773322912; x=1773927712; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=o5dFx0wHNh8e3LinTTG/Y3HW59wuwEbRT1tQ1nd6tlk=; b=KFT0IGF5r7oCMYxekBjjU10fEKi6yrLvIIqWIB5HIa9maFmdZCDa05gVOY7GMLgIq/ 7fIigFTvP/V3+rh2YTxP2yPzmS4Q3z0wGIaOwes0L9lNxX/HF3n9+KOX+usmHd7b9xyr JYAvTNN8Qh2+CwsaaGDaAtCNqlxiqkO7xVEhKlCvQrOyKDpiTkkeJtSPN5NoVs1fGlvN a+/Joq7iFR9PkK4N3rx8yGdddsZ6lNu/klexKEWgbW6GayhCKq50ZIEcRvl36ePc5kTM LZpuN7SDUaZP3EiXejQbYVrJDFUf2M400lT0ETjMpMjIf3mTRKhqZ6KxCROn2B0ncmRn 8EdQ== X-Forwarded-Encrypted: i=1; AJvYcCVOv3JVEy459/RXHfl3gjVMMpht/zeX/Db/z7QCvzp/krJibhyC5pR7JVpofYNKlbSkneE+UKhBgehf/+E=@vger.kernel.org X-Gm-Message-State: AOJu0YyaP/SLx7i72jah1SyjyWdBmbs3k7VN5khIZvkNM/BcnKRR/szA EUXiGqLimOLmFlBC0KN4wtVSPhLcBjFgMaOaK4PutQKbVxsnZ+v+1fmjp8wYGkHAzSI= X-Gm-Gg: ATEYQzxvAmuDJd4ojlSHKtYxIkIlBPnP5Q7DyTnrc5n8ZIORLiwR9t8+LtMJ8alU4L/ wcfkDK6Ak71v0D4hxACgqAMRQHQVVoplZJNLwazq0wKO93Gw/jIiDtK8FcUyzrOHxSdgmO5gLKf OkfuU2skN6QlnIATHA2850lpV5kyxESAbZchgf2Or5jL8flXmEvM1qwSKlDubps7BhI6aan/rgT 5Dy0dE2Hqk9er+ceHOjKepCSYPk1EmAEO1NIlOdme2mzSOgvMXdXG0sYryKMlgdzDpqk78mfX0C PzkRpTUVGHjjuQ2nnZ8OAcOGCiz1HCMtWkMsSMDuipbSYSbBT4gQzGrDTH6SeUa5t952kAItvTm nAqYZ+WutbYSp3EAxIyNhV8MDoQ0DbifZz7sSV/1WhfLy2LuLb+DA4TXqimENK9BdTm3aIl6t+o begZ/2bVEuFvjfs5Fy1TdUvYkAW0HtI68udMmCb5QibQnxTFBEV8KwmfQmgc4EIfoQyJL5/5jwZ y5tDhlC X-Received: by 2002:a05:622a:d2:b0:509:4d26:25d9 with SMTP id d75a77b69052e-5094d264978mr22289541cf.58.1773322912409; Thu, 12 Mar 2026 06:41:52 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-142-162-112-119.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.162.112.119]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-50939ec63d6sm37587711cf.12.2026.03.12.06.41.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Mar 2026 06:41:51 -0700 (PDT) Received: from jgg by wakko with local (Exim 4.97) (envelope-from ) id 1w0gIR-00000006fkJ-0b7W; Thu, 12 Mar 2026 10:41:51 -0300 Date: Thu, 12 Mar 2026 10:41:51 -0300 From: Jason Gunthorpe To: Lizhi Hou Cc: joro@8bytes.org, will@kernel.org, robin.murphy@arm.com, yi.l.liu@intel.com, iommu@lists.linux.dev, linux-kernel@vger.kernel.org, baolu.lu@linux.intel.com, vasant.hegde@amd.com Subject: Re: [PATCH V2] iommu/sva: Fix crash in iommu_sva_unbind_device() Message-ID: <20260312134151.GK1469476@ziepe.ca> References: <20260305061842.3953885-1-lizhi.hou@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260305061842.3953885-1-lizhi.hou@amd.com> On Wed, Mar 04, 2026 at 10:18:42PM -0800, Lizhi Hou wrote: > domain->mm->iommu_mm can be freed by iommu_domain_free(): > iommu_domain_free() > mmdrop() > __mmdrop() > mm_pasid_drop() > After iommu_domain_free() returns, accessing domain->mm->iommu_mm may > dereference a freed mm structure, leading to a crash. > > Fix this by moving the code that accesses domain->mm->iommu_mm to before > the call to iommu_domain_free(). > > Fixes: e37d5a2d60a3 ("iommu/sva: invalidate stale IOTLB entries for kernel address space") Cc: stable@vger.kernel.org > Signed-off-by: Lizhi Hou > --- > drivers/iommu/iommu-sva.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) Reviewed-by: Jason Gunthorpe Jason