From: Borislav Petkov <bp@alien8.de>
To: William Roche <william.roche@oracle.com>
Cc: yazen.ghannam@amd.com, tony.luck@intel.com, tglx@kernel.org,
mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org,
hpa@zytor.com, linux-edac@vger.kernel.org,
linux-kernel@vger.kernel.org, John.Allen@amd.com,
jane.chu@oracle.com
Subject: Re: [PATCH v2 1/1] x86/mce/amd: Fix VM crash during deferred error handling
Date: Thu, 12 Mar 2026 17:04:53 +0100 [thread overview]
Message-ID: <20260312160453.GDabLkJfhslCLXZntv@fat_crate.local> (raw)
In-Reply-To: <8e35298b-7511-4f7f-8f13-9b03738b286c@oracle.com>
On Thu, Mar 12, 2026 at 04:11:10PM +0100, William Roche wrote:
> From the kernel point of view (regardless if it is running on bare metal or
> in a VM), access to these registers registers is provided by the platform:
> either the Hardware or the emulation framework.
Except the emulation doesn't emulate the platform properly. We test on real
hw. If your hypervisor doesn't do that properly then that's not really
upstream kernel's problem.
> Errors are injected into VMs by the hypervisor when real memory hardware
> errors occur on the system that impact the VM address space.
And?
Why?
What's the recovery action scenario for having errors injected into guests?
Where is that documented? Why does the upstream kernel need to care?
Basically I'm asking you for the use case in order to determine whether that
use case is valid for the *upstream* kernel to support.
> This is not only a test, this is real life mechanism. With the fix
> 7cb735d7c0cb that has been integrated, VMs kernel running on AMD now crashes
> on Deferred errors, where it used to be able to deal with them before this
> commit.
Because we don't know of your use case. So when we do upstream development how
can we test your case?
Before that, is that case even worth testing?
I hope I'm making sense here. The MCA and other low-level hw code works on
baremetal as that's its main target. If it is supposed to work in VMs, then
there better be a proper use case which we are willing to support and we can
*actually* *test*.
If not, you can keep this "fix" in your guest kernels and everyone's happy.
Thx.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2026-03-12 16:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-18 16:30 [PATCH v2 0/1] AMD VM crashing on deferred memory error injection “William Roche
2026-02-18 16:30 ` [PATCH v2 1/1] x86/mce/amd: Fix VM crash during deferred error handling “William Roche
2026-03-12 14:42 ` Borislav Petkov
2026-03-12 15:11 ` William Roche
2026-03-12 16:04 ` Borislav Petkov [this message]
2026-03-12 22:44 ` William Roche
2026-03-13 20:10 ` Borislav Petkov
2026-03-16 15:27 ` William Roche
2026-03-13 20:26 ` Yazen Ghannam
2026-03-16 15:26 ` William Roche
2026-03-19 14:25 ` Yazen Ghannam
2026-03-12 14:23 ` [PATCH v2 0/1] AMD VM crashing on deferred memory error injection William Roche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260312160453.GDabLkJfhslCLXZntv@fat_crate.local \
--to=bp@alien8.de \
--cc=John.Allen@amd.com \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=jane.chu@oracle.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@kernel.org \
--cc=tony.luck@intel.com \
--cc=william.roche@oracle.com \
--cc=x86@kernel.org \
--cc=yazen.ghannam@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®