From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f42.google.com (mail-ot1-f42.google.com [209.85.210.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C209F38D690 for ; Thu, 12 Mar 2026 16:56:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773334580; cv=none; b=s9pTS7+GEd2fJiZrd72azHeW9brrMlZWOeBxwfNLp5GBqHC/470tNkeFi3OhuGafLEkl9UlC+8lTgO18gLxLqlUPMn1rEVsFRTnXXn23CtuK2EU8e790s0ucY8iGvXv8bFNY/ei1E/KvM/0y4cwnxudWkFp9vHFw0v/xx5UhKOI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773334580; c=relaxed/simple; bh=2FIX/z0MA78TQchy8Bl9fzSZSjfi9qD8z5KF77Ky/zQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=N0hQ6koCu/QlRGrKDdUStRigOkvCFd75MPZmWbYIRHI44En2/4Qhey81OXxeQ9XGDI7YG3F8vsQmYqNzKgBBRyOKcVUHndbV9tdb2J35yMyQRUnN3hyIbCtrmDOHNC8b2CpZYKJB4+CR6PJmojYC+lH/4EuuuTnpRPjiszlRLjI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=BTMHpUNN; arc=none smtp.client-ip=209.85.210.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BTMHpUNN" Received: by mail-ot1-f42.google.com with SMTP id 46e09a7af769-7d741f61ee5so1097913a34.1 for ; Thu, 12 Mar 2026 09:56:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773334578; x=1773939378; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=18JIT3O6zukphcEe6SxTxh/vhMczaM3dIFncm+AHYYE=; b=BTMHpUNNNmnQlidSOO0IPQEjpot8CFxxd1FK/cFyMOdplq4JljIsoikFHr/7pAfj+C mbB3pFHUS3SdhTITOOlkJyee4CqjZYVdIz6x0rKVVlb0pI7SLeRkOCHGi/vFGx3wrdBc 1x55VEohgXHFmHodZRO8yMVfZKc7HjidaOxZ7O9DbJPx5T4dm4aYKVNQp8QCRuKyFoO1 h5qXjB/yJb2MxshMx04UfY+Ju3oeTe5SjNZk9Kyp81DSWgnefY+uyY6mg5FGrd0qF8yA 6yxELj8+7TPbTHp+gjKR7ekdjQldWh1/nFU94lLwpZnf6MzV9ut8qGMOX3SsG6/6Zkor kN1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773334578; x=1773939378; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=18JIT3O6zukphcEe6SxTxh/vhMczaM3dIFncm+AHYYE=; b=vJj8vVe98c4XrJH+siz2Vm9bHLQ4mJEkLHKh+HZo0RABjkKUVv+MSWZsyn4XcVB09R dZNqVpVxrMIRO8zCGpgSxZSukAlMa8a+eGF04gCaoUTnMWXy6p9rhIq9W1F/NPrtHry0 M8NDWXXpb9uD83qpJBfkVTw8Zlu6DmOZ5xseeDCtXdeqcmnd+Z6GOC/EgRNCzXgJkiro g933bHPK6tIjsIZ6osSUpl6UM/p7eC3c2HWRXpVUIKg5HfVPSCRdYbLI9l3oOcn4iNJi FG16Byhnx0jfiaudj841646DaRrHSPSDXd7kOMaNJhD4vMsGVrKrYK29GSaHJnIXMjEl 3pNg== X-Forwarded-Encrypted: i=1; AJvYcCX/sNR52oHwFh/GzF8+YGhAQGZVFgqg0LvtEGaQ44gkawbYQQ86zLco/qlIOww9k2t71SE4ucgD1QSId1Q=@vger.kernel.org X-Gm-Message-State: AOJu0Yx1FmlIVC7eVI70olYOTqz1Gbi7oXalPT7q+Xc47z8dZDRKZA1B r5IW38/YuEWW/CVTYeg0gJzoNcC66uUJuf6PlS7GL4C0sKearpte0yTV X-Gm-Gg: ATEYQzyn+AYuq1Y8FRFZPUJWqgmdTBoTzQZva30mEDu4YjJpwT50uLq5xU6E4d8EtAU kWsrq6m1k2LO7mLk980VLm3jSXcJGLxRHwH0zaqCVeuv9/ksYysHiKjlDHiDqc1vd/mswsUloEm ZXnSAouSRD5rKSVlGqLo2Uk3A/2twN8JZl0PlMuTJAAax2+Nck5vCOG2o0mUoEfdm9HLel/SPN7 sLXFjCElW4Ux3ryZq4NNVjIkp7A3v8w4mutyTOuIU5ahjy105CS5QQyvMCMvfFnuX2Pp9rx42US MO6YfZXDM3CW1VZCUnSpCs4wqfAWt0BOi53XqxtZUfj58+kJ1l4+aGASUwt9ZqqW/fMGBF5iswk mOMaomyu+pOI787v4dUw5byzrMEYzuh79evKSoSR4MwIZhSxeEYCJX9kG+DHwZB4e9/5QM0Qtox G1vKgDM2IWNea9K6i00mJuuQ== X-Received: by 2002:a05:6830:64c8:b0:7d7:5b20:16ec with SMTP id 46e09a7af769-7d782466df9mr59235a34.11.1773334577663; Thu, 12 Mar 2026 09:56:17 -0700 (PDT) Received: from localhost ([2a03:2880:10ff:57::]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7d76aa5dcc7sm4596873a34.0.2026.03.12.09.56.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Mar 2026 09:56:17 -0700 (PDT) From: Joshua Hahn To: kernel test robot Cc: Minchan Kim , Sergey Senozhatsky , llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, Johannes Weiner , Yosry Ahmed , Nhat Pham , Harry Yoo , Andrew Morton , Linux Memory Management List , linux-kernel@vger.kernel.org, kernel-team@meta.com Subject: Re: [PATCH 10/11] mm/zsmalloc: Handle single object charge migration in migrate_zspage Date: Thu, 12 Mar 2026 09:56:14 -0700 Message-ID: <20260312165615.3800716-1-joshua.hahnjy@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <202603121158.g93vlc2U-lkp@intel.com> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit On Thu, 12 Mar 2026 11:51:59 +0800 kernel test robot wrote: > Hi Joshua, > > kernel test robot noticed the following build warnings: > > [auto build test WARNING on axboe/for-next] > [also build test WARNING on linus/master v7.0-rc3] > [cannot apply to akpm-mm/mm-everything next-20260311] > [If your patch is applied to the wrong git tree, kindly drop us a note. > And when submitting patch, we suggest to use '--base' as documented in > https://git-scm.com/docs/git-format-patch#_base_tree_information] > > url: https://github.com/intel-lab-lkp/linux/commits/Joshua-Hahn/mm-zsmalloc-Rename-zs_object_copy-to-zs_obj_copy/20260312-035531 > base: https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux.git for-next > patch link: https://lore.kernel.org/r/20260311195153.4013476-11-joshua.hahnjy%40gmail.com > patch subject: [PATCH 10/11] mm/zsmalloc: Handle single object charge migration in migrate_zspage > config: x86_64-randconfig-001-20260312 (https://download.01.org/0day-ci/archive/20260312/202603121158.g93vlc2U-lkp@intel.com/config) > compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261) > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260312/202603121158.g93vlc2U-lkp@intel.com/reproduce) > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > the same patch/commit), kindly add following tags > | Reported-by: kernel test robot > | Closes: https://lore.kernel.org/oe-kbuild-all/202603121158.g93vlc2U-lkp@intel.com/ > > All warnings (new ones prefixed by >>): > > >> mm/zsmalloc.c:1702:6: warning: variable 's_idx' is used uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized] > 1702 | if (!cgroup_subsys_on_dfl(memory_cgrp_subsys)) > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > mm/zsmalloc.c:1752:45: note: uninitialized use occurs here > 1752 | d_zspage->objcgs[d_idx] = s_zspage->objcgs[s_idx]; > | ^~~~~ > mm/zsmalloc.c:1702:2: note: remove the 'if' if its condition is always false > 1702 | if (!cgroup_subsys_on_dfl(memory_cgrp_subsys)) > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > 1703 | goto out; > | ~~~~~~~~ > mm/zsmalloc.c:1696:20: note: initialize the variable 's_idx' to silence this warning > 1696 | unsigned int s_idx, d_idx; > | ^ > | = 0 > >> mm/zsmalloc.c:1702:6: warning: variable 'd_idx' is used uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized] > 1702 | if (!cgroup_subsys_on_dfl(memory_cgrp_subsys)) > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > mm/zsmalloc.c:1752:19: note: uninitialized use occurs here > 1752 | d_zspage->objcgs[d_idx] = s_zspage->objcgs[s_idx]; > | ^~~~~ > mm/zsmalloc.c:1702:2: note: remove the 'if' if its condition is always false > 1702 | if (!cgroup_subsys_on_dfl(memory_cgrp_subsys)) > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > 1703 | goto out; > | ~~~~~~~~ > mm/zsmalloc.c:1696:27: note: initialize the variable 'd_idx' to silence this warning > 1696 | unsigned int s_idx, d_idx; > | ^ > | = 0 > 2 warnings generated. Hello kernel test robot, Thank you for catching this issue! Yes, the MEMCG v1 check should be done after I use obj_to_location to initialize the indices, so that the objcg pointer swap works at the end. Will make the change in the next version! Joshua