From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2448A381B18 for ; Thu, 12 Mar 2026 21:59:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773352765; cv=none; b=EZnoLpdi6z1kfNQZYH1LxN0YxUAIFA2Yn7gZ7+zhII+88RKq0PlTLJzYbaAQU8JkIpJEI+pkMTkvTq+0i3t/+avVGvmIp8iAU5Xkb2zlqP4ppDJepQhy/ad6yq3b+GawnfcTZzHbyHEOdrx9k2KBPN6jagCOfyY7rr/ekQc2PRo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773352765; c=relaxed/simple; bh=JxlY+Q6YlArxRPFjIBcDy7cUCg1qCv5lcXgIRei49Ic=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=JGeBOYnNPLTLhh7YnVQ/e9GVV6Xl2Xkod40jqwMAtPmPJP+Icgz0/eyfRwGOWGN08yS25jSnn0mu9NVL7i6MMWzRSJhcDKXRjfVsAKCPlYo7yvMmLNm4ZPFhPzsPJdI00t6AjBO81ku/A2xVxtdYq7Vi5XjQqnM+OGLrwLmSo+M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=cn/JY+qW; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="cn/JY+qW" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-48541edecf9so15692855e9.1 for ; Thu, 12 Mar 2026 14:59:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773352762; x=1773957562; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=CAyX6GXYtg7Rn3FHKIXBbFd5m2ihGyjftaZK5jVFt/A=; b=cn/JY+qW0/tmGHNgsXsRV9cwEz7ZsY1wLYYss6vhAwfjcu4oN8bRfaphBrVSIpB5p5 hqGjEeWcYXucCacbZLmxM/B726IPpz5vCwE8IRnVRsc8nZ9dIIOQaVig169382XoPsKs 4/Iz0wDKAP8yI0N6cQPYVQhAGSqd5xmAyeJZraYPDNkhtGtep/hZFrVRV+hkEtCVrnrr qOPc65sL3yEozaF/xWLLrd5wS2746tAH9gFRQP66Y0qq145XDcgivt/Kr3aWmh/3MwO5 twK8oSMkYh4uKfYBSDHCL/X5Sl76w6HWi2yqwxMKPE8xDVXjoLsPKEmwOVu/qB2fSy7x KQqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773352762; x=1773957562; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=CAyX6GXYtg7Rn3FHKIXBbFd5m2ihGyjftaZK5jVFt/A=; b=Lq5hkhPKcaapX3DNb5hotyW8FKE+9kFJ8Uxu+BN04wdejQcjz8i14c1pY+UEcgnAXf KBG0vkMf6AlstZ2/Xgg3JJi14JUBwXJElRxJYKWViIs+X11/9Fp8BG7wCAy4shf/N+9K 3AfkTb0/4U6cguiFTL0UvoeqEUYEKPxiuunCC9qy0w+G2H2yv6NAFTvMb0binfo1fAEv Nv85yn8x6WRYpFWoTN5ZrnEqrtBDCgwcK/YEQUXcFfLR1oFxEiDR8ZOtbQYVWlSTMgxl nXJAnf15QnFmW+cUwr62QA4HimgDNGho7bL3DhU6HRTG/7W3yPd7vzMGgRM3u7paUtE9 dM9w== X-Forwarded-Encrypted: i=1; AJvYcCXMniCE+HFPSK4fkN7Djo20bDhYctRo0TgyPho4zp2XUc98u5Qk6phsKXJf//7vCuK3MecZJmSw+9sW8WE=@vger.kernel.org X-Gm-Message-State: AOJu0YwnefvUlE8AE8gv/Lij/xhB9/t98ILG20HdB0yTW6CDN2aGKH3p 5d69mBcW1y4l6bux3N5/hJz8oaNVz+sMRZQZddj8wHm6ILve+6T4TKWS X-Gm-Gg: ATEYQzxgvV2Ci7HURvaThO6J2RwD9zySFhyWh9NhUuZiiaMAMDxjI87q47EWkoazQ5e uSs6hekcLhcfZOa6IyAox/LHfz+6IWU2/TIlWFwjEOmRI57UiBK+Bq67CnIBMMPpy32CBIsSYsA CzWshEyQgroyjVTc4PpKHhDHuaMr+x9KsGBWeLla5oYrcYu0+vyVSZSD4K86nr8JV+VRXmZh1bY gpH/miFzdDYyuwBZ5qS9thD9kNM6DytYREnJXI/c8mZtmoo5cw1lqxrkDJ8IIkRfR62q9WfIkym PPDQ5kDZtPX4OY9WlfCKrcbToEXoPMQDgioB9hLw7halpStd1vzRfDqK3ey40Og0CZvT5ICYsUy 6Tcsr6o22sUIFw+DuoWg84NgLWtP2Rc6xlmp+EWJQ5UJevNYhw127iuVcsQVIbSHVuBfPG6FDom 2wr6iXCPBf17viPiHJHpWYgkRcCWnRY7PQEjpTFJ00gK+/grDoQsiaa5zGRXdDtEt7KMr125GHW HMXJOKLAQrdLzTfxbYNx/EAP0Tik5p0loMXAl4UVpIX X-Received: by 2002:a05:600c:5395:b0:485:4278:2558 with SMTP id 5b1f17b1804b1-485566c6a81mr15382375e9.6.1773352762287; Thu, 12 Mar 2026 14:59:22 -0700 (PDT) Received: from fedora ([46.248.82.114]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4854b66ffe2sm148841245e9.13.2026.03.12.14.59.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Mar 2026 14:59:21 -0700 (PDT) From: Uros Bizjak To: x86@kernel.org, linux-kernel@vger.kernel.org Cc: Uros Bizjak , "Peter Zijlstra (Intel)" , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" Subject: [PATCH -tip v3 2/4] x86/segment: Remove unnecessary memory clobber from savesegment() Date: Thu, 12 Mar 2026 22:58:56 +0100 Message-ID: <20260312215916.258176-2-ubizjak@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260312215916.258176-1-ubizjak@gmail.com> References: <20260312215916.258176-1-ubizjak@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The savesegment() macro uses inline assembly to copy a segment register into a general-purpose register: movl %seg, reg This instruction does not access memory, yet the inline asm currently declares a "memory" clobber, which unnecessarily acts as a compiler barrier and may inhibit optimization. Remove the "memory" clobber and mark the asm as `asm volatile` instead. Segment register loads in the kernel are implemented using `asm volatile`, so the compiler will not schedule segment register reads before those loads. Using `asm volatile` preserves the intended ordering with other segment register operations without imposing an unnecessary global memory barrier. No functional change intended. Signed-off-by: Uros Bizjak Acked-by: "Peter Zijlstra (Intel)" Cc: Thomas Gleixner Cc: Ingo Molnar Cc: Borislav Petkov Cc: Dave Hansen Cc: "H. Peter Anvin" --- arch/x86/include/asm/segment.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/include/asm/segment.h b/arch/x86/include/asm/segment.h index 9f5be2bbd291..3fe3a310844c 100644 --- a/arch/x86/include/asm/segment.h +++ b/arch/x86/include/asm/segment.h @@ -348,7 +348,7 @@ static inline void __loadsegment_fs(unsigned short value) * Save a segment register away: */ #define savesegment(seg, value) \ - asm("movl %%" #seg ",%k0" : "=r" (value) : : "memory") + asm volatile("movl %%" #seg ",%k0" : "=r" (value)) #endif /* !__ASSEMBLER__ */ #endif /* __KERNEL__ */ -- 2.53.0