From: Benjamin Tissoires <bentiss@kernel.org>
To: Jiri Kosina <jikos@kernel.org>, Shuah Khan <shuah@kernel.org>
Cc: linux-input@vger.kernel.org, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org,
Benjamin Tissoires <bentiss@kernel.org>,
kernel test robot <lkp@intel.com>,
stable@vger.kernel.org
Subject: [PATCH 0/4] HID: bpf fixes for 7.0/7.1
Date: Fri, 13 Mar 2026 08:40:23 +0100 [thread overview]
Message-ID: <20260313-wip-bpf-fixes-v1-0-74b860315060@kernel.org> (raw)
Hi,
This is a series that targets a few HID-BPF issues I discovered or I've
been reported:
- first 2 patches should go to for-7.0/upstream-fixes:
- 1/4 fixes a compilation issue when HID is not enabled
- 2/4 is a nasty bug which allows a HID-BPF to crash the running
kernel, so not critical (you need special permissions to load the
HID-BPF program), but not great as you don't expect tinkering with
HID-BPF would crash
- last 2 patches are more 7.1 material: basically the LEDs on the
keyboards are bypassing HID-BPF, and then that made me realize that
the fallback calls in case of an unnumbered report is not correct (and
likely unnoticed because I don't think I've seen unnumbered reports on
anything else than USB devices)
Cheers,
Benjamin
Signed-off-by: Benjamin Tissoires <bentiss@kernel.org>
---
Benjamin Tissoires (4):
selftests/hid: fix compilation when bpf_wq and hid_device are not exported
HID: bpf: prevent buffer overflow in hid_hw_request
HID: fix LEDs when report is unnumbered
HID: do not bypass HID-BPF when setting LEDs
drivers/hid/bpf/hid_bpf_dispatch.c | 2 ++
drivers/hid/hid-input.c | 16 +++++++++-------
tools/testing/selftests/hid/progs/hid_bpf_helpers.h | 12 ++++++++++++
3 files changed, 23 insertions(+), 7 deletions(-)
---
base-commit: 48976c0eba2ff3a3b893c35853bdf27369b16655
change-id: 20260313-wip-bpf-fixes-2fe794000870
Best regards,
--
Benjamin Tissoires <bentiss@kernel.org>
next reply other threads:[~2026-03-13 7:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-13 7:40 Benjamin Tissoires [this message]
2026-03-13 7:40 ` [PATCH 1/4] selftests/hid: fix compilation when bpf_wq and hid_device are not exported Benjamin Tissoires
2026-03-13 9:02 ` Thomas Weißschuh
2026-03-13 13:28 ` Benjamin Tissoires
2026-03-13 15:58 ` Jiri Kosina
2026-03-13 7:40 ` [PATCH 2/4] HID: bpf: prevent buffer overflow in hid_hw_request Benjamin Tissoires
2026-03-13 15:58 ` Jiri Kosina
2026-03-13 7:40 ` [PATCH 3/4] HID: fix LEDs when report is unnumbered Benjamin Tissoires
2026-03-13 7:40 ` [PATCH 4/4] HID: do not bypass HID-BPF when setting LEDs Benjamin Tissoires
2026-03-16 15:59 ` (subset) [PATCH 0/4] HID: bpf fixes for 7.0/7.1 Benjamin Tissoires
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260313-wip-bpf-fixes-v1-0-74b860315060@kernel.org \
--to=bentiss@kernel.org \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=lkp@intel.com \
--cc=shuah@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®