From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f172.google.com (mail-qk1-f172.google.com [209.85.222.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B1FB735F5F4 for ; Fri, 13 Mar 2026 16:29:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773419388; cv=none; b=hT1JAPaut6k1+C82ydPUhapBpI3Nl0Ud4dwgLLFvUBd2TZaRrIUp6LMzjlUs5ou6AB6CNfuvD8mM21rxNbVwutQVBAEUgsUoo7mnhnRXB29N4RUf0s87UbwZqw/hpKYxn19LRDjL8tY4vwvKs6tXfXNHZX9s49HnJnUMFXGih8k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773419388; c=relaxed/simple; bh=EZoFcnTv15ywdGMgzpXfHMHTakhgmPvW43ji/xyzqhI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=enzc0O+MtFK5abYApENPD9XeqFrMd1wNZLYjxxK8sIeSz6eRK/f4ra4AZQM+1hTfzwrjNEl0QS/vVSx+2I6JwKVNEjLQh/oLKWn5h1TXcPS59aivSMHlCpHyUa01cj0pMCTujuaGfCsZrVwdVLnrMhTNML9eIMntctZLjwNnNAg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca; spf=pass smtp.mailfrom=ziepe.ca; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b=HgwGhfO4; arc=none smtp.client-ip=209.85.222.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="HgwGhfO4" Received: by mail-qk1-f172.google.com with SMTP id af79cd13be357-8c70b5594f4so247290885a.1 for ; Fri, 13 Mar 2026 09:29:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1773419386; x=1774024186; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=ucU+6O9NcrurkuJo/0aLMyRlc+sLJzYFKhCbCreSM2Q=; b=HgwGhfO4TTyHLjkZpZEc/TsyEmooP8LFX9/yqCJgt6xjEVWxRjS8ad4XcCbjO0wkDN w1sllfgmc1DTdmbps59SypZOQRSw/7gr5ta6sDmeMfErGJQwL9pi291jpdgijaQmk5yW e8dePE9mA3vpxBQME30yY0m7EZOn1XqJtbmKRqe09w0hgF4lnPdIXmLySt4/J7cRYLFM 5VIhN0rygZNWgCxNSi2V7CQTbDKlkqCm2L4Jvn1WxvPz78SG1BDx3Fovdc4xCFzq4ed0 ckXpv9u5ZmfNQd2sp1gF9SsvZcMceyUSxPwfji36UquQd+Dnj9FMqyT7jcOi79RSIVNQ o2Gw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773419386; x=1774024186; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ucU+6O9NcrurkuJo/0aLMyRlc+sLJzYFKhCbCreSM2Q=; b=BOIzy4P218wzRvCIz+s3ncLHs0pUSAwbV+prgH1XS1HJFoN3JeEh/tGG33/NlkeEU4 TdM5g3ah1eDxHuEN8p2usBjXiNKYy+UHB5qoJqF/MTNLkVY1TfEl1UHXo5ffx8gqznOj aeiKmeqo0pEx2Usz2oWAAVO0QvahQWgczXAm6thelmKXhHN4cdBST+MyNbRIv0ZTfNhx qCoCJBr48OQOqlDbt2+/qsxRAXoWYK+3MGysyB6pYIf/FHwNExROMS4yTdlePNx3qUr0 M2LN26qwM8/DNI4XVGUIX0bi7zCy2rEjECcrKGZH98db1hPDdCb1XjnZyWwlC8evI9+Z G5pQ== X-Forwarded-Encrypted: i=1; AJvYcCVkNkxo924GZkMGunFUZf37UYO5mUGVoKbW5vFlUJBXmHPdbL5JF++zNERIrkpyTITsXG3oSspfwF1TzS4=@vger.kernel.org X-Gm-Message-State: AOJu0Yw2Z33Q+HInmK8UW7n8aTVeZ5rbts5RR90M0qDm+dMiAGTZGDI/ eB660KWZ4+dl2p8kKUSFhsSr6Tv00mdpGjlNiF9kh4APDtLifEFtFp+1Qlpn3EB/KUs= X-Gm-Gg: ATEYQzwVpnQxsRGsXn05/wjf+FsKoz5Ad2zgLreRuHtQbe/oRC2B2hRXDEGSG77Gmg5 zvi7Ekj47sLjpIysixROFLMqQe5r6TzL3e+DwuRBwJzeWPr+kYwDsjNh0MPTFnNecz0yy7oFEZf SV73B+E0LxOIAfIr0jhJi78dIR+NsprnCq+PeRzs4QNz914TnxpJsv9m9YnL2pJP5TkbszpozJD wPrz3MqiCW2v++UZvKdPuMHqBZaDiisr+WlgDWP3gInEbQm1/sqf9z2oPYgFOnfv2kLBhNAcJdH SKjQyJz/I1r8n4MVbEw/MeeVjB2jilyY+jiSN8q+fVOQw4OOg31ajHo4o7TfAQOSZXMrtChB+AS Zu0SWNqkpFXour0qihmjScjWmz8IkM9+cYqiatg5X1/MsYn9e0JhbO80TE2JwMsc/W5rW2UCjEK +7FDIafV2CV4UJmM2mn1CUZjbBI2fOVOaWL33JCmimo7rem8pHL6xQHfUl15j18YkhLZHMhutTv YvAN3DM X-Received: by 2002:a05:620a:7114:b0:8cd:9405:9662 with SMTP id af79cd13be357-8cdaa88ceb9mr1132608485a.36.1773419385726; Fri, 13 Mar 2026 09:29:45 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-142-162-112-119.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.162.112.119]) by smtp.gmail.com with ESMTPSA id af79cd13be357-8cda21100adsm633364985a.31.2026.03.13.09.29.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Mar 2026 09:29:45 -0700 (PDT) Received: from jgg by wakko with local (Exim 4.97) (envelope-from ) id 1w15OS-00000007JE0-1OZL; Fri, 13 Mar 2026 13:29:44 -0300 Date: Fri, 13 Mar 2026 13:29:44 -0300 From: Jason Gunthorpe To: Thorsten Blum Cc: Kevin Tian , Joerg Roedel , Will Deacon , Robin Murphy , Pranjal Shrivastava , Nicolin Chen , iommu@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] iommufd/selftest: Fix page leaks in mock_viommu_{init,destroy} Message-ID: <20260313162944.GD1704121@ziepe.ca> References: <20260312164040.457293-3-thorsten.blum@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260312164040.457293-3-thorsten.blum@linux.dev> On Thu, Mar 12, 2026 at 05:40:42PM +0100, Thorsten Blum wrote: > mock_viommu_init() allocates two pages using __get_free_pages(..., 1), > but its error path and mock_viommu_destroy() only release the first page > using free_page(), leaking the second page. Use free_pages() with the > matching order instead to avoid any page leaks. > > Fixes: 80478a2b450e ("iommufd/selftest: Add coverage for the new mmap interface") > Signed-off-by: Thorsten Blum > --- > drivers/iommu/iommufd/selftest.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Applied, thanks Jason