From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f52.google.com (mail-qv1-f52.google.com [209.85.219.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1B4F83DCDBA for ; Fri, 13 Mar 2026 18:27:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773426448; cv=none; b=SONrtoB8tFYo1SvBj1VFOFl9Nbf83BooSVOIlxHqQibBMUTUHoToTv1f8wbiGlCPVsTrE+eHTRiWbDVRW9DORkRrL/C3+QismSSbewjAviUT7oHxd0apOJc52ANB08sIqysfN7s75K7VY2Q2CeT079SZ3kEhmqnDzBkwOIPm+CY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773426448; c=relaxed/simple; bh=r+8WDj17D0ahzMmsV26yBAG5Il5FyUsQjbgg7T++RDQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=EkUDOMEkEx0w5PeS46yczgxqUIiFFkgvc4trQVYWiAWB35ClStCr4NBzDtG/5ATOr25tBxOGeGl7qxXlWCe58tySZEtiU9WeMRYqKL9A5rao+5s+lqZF5vtg0ysFbFRPeLdkGWukqscPvJq8siZBgsoqhf+hsis1EtK0G/BbsTM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca; spf=pass smtp.mailfrom=ziepe.ca; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b=Q5Hdyljx; arc=none smtp.client-ip=209.85.219.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="Q5Hdyljx" Received: by mail-qv1-f52.google.com with SMTP id 6a1803df08f44-89a1c6dd788so26192436d6.0 for ; Fri, 13 Mar 2026 11:27:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1773426446; x=1774031246; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=sD7gZdLIbR12oWsuwP0hMyRwjWKcXWNRvnOkCD9lgq8=; b=Q5HdyljxeDnCzW3ppiaOKcUAMzk/0W9w5V/QZ6ys3FiBZiMevIVNMgUnI8t5f8dI7m SRw+Yjtoym1B4rG4+Q32fT/KY4XoZ4Y5OveRmLi59SH/rdWZsCrHxsoY9+1Shc75UNi9 qMNucUadnEIYk3+PhkwJ5CcGzqojZBGUVIZpUEAMTiv/iYetPdK1weiLdwlfKf7JJcbI RZTlPwlibjhm2QHko+/MHc2UZb/rESinRXuzd/n3jFZQdkA22wMXTjL372sq4K9T+XHz fojxWJuj4IP1I2OwMoEDJf3NGHD2i529d+UWXmyHBkL2DC7jSMuvOCU1E6z7Nah2F+tC Rdhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773426446; x=1774031246; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=sD7gZdLIbR12oWsuwP0hMyRwjWKcXWNRvnOkCD9lgq8=; b=WqlN6h3XwRV+dR3XR0xsQiQTaVChAhiaSZwmtl681ZjjxPYFQ33rvn1Sf88jYp8xZJ FCJ/MMC4RNpO2J0RUQuhxFp+NzFF+S7mC/a80hGszfNWLZi/oetuzsMXkGJ2cwvPLr0t FT/4kgFgQ7r431GbS/shJM/VLmMnnF3Q6cULjkkOWzY0WITJrVSOtTIPdFS8qnrXgRvH nwh0bRzxLGjGUt8SkkhZWKQKLahGAInrtarLPQ5Jj0Jn5Dp71T5D6LMWrPs9zYp7p2OK D4hNhkHhfUVu7O2htFE2FdIFGG+PFzqhRVzo/NWznVnUH0zVuOW0h+0iW3OJOuDMHhok RtYQ== X-Forwarded-Encrypted: i=1; AJvYcCUEcLtmiqrs4oGmfawbYzaJr+X75av9bJZVNNuGN64eNSuoXiJUzYoCTtv/9Jlgzu8Wt5k7IYET4PsTZOQ=@vger.kernel.org X-Gm-Message-State: AOJu0Ywpdxe0PBrmVKmhWiX4JgRio0xlEpYY05tp+UJfG1C4ITJvh3zI k6IHjF5T2MmUBoqrDL0lO9WXiDp5Gt0++l/yTutl4WQffDLgvzngM6jEcUy88NORSHk= X-Gm-Gg: ATEYQzxQite7D24eHp4aDyuHh2XZIuldfRZrj8CiTmnQ+epdrZGbR8iuMM75IK7LlF2 t1c+Oi8DnSyOIp3GjsSrifCRrHAV0i2+yku4wlrEEiGi7RVaWGBi/VcrOjZp7w9HQ7cj+wKh2W1 qNgbM2oW6LTgipQwTVWIg3iX0SQvgxnuubDiH/34F9ZkKdWvBBcBVDaOzX1M4u6U8WZYRm/Ua5U ghsNFE2lz/dvlv1ICptqPaa9fE0MzehqFpsGXkhrYiR2eF8wmIzblVxCLpv8w0juI1nXx0t7tIG UX+5pZhIi5wOEzKT3Cqlv1kTeWxgjn0K/D2pbtvRjl9PXg9Em7b+4MU9Rq2aAw6600tt5ceycEx iuR+wYnHz/7ndlzRm9XDrSD0B0R57Qr8XB3967P3W5SmRiY9pxLF4cnT/03RsoZ0oSBvAiU76LB 3k61AOkmvV1K0kGA6CLSQ60uIZoZk43bufl5n6/psDosXQ2BZr+ih3zeGBMQ/bS5O9TRYuogumZ CbkJcyd X-Received: by 2002:a05:6214:1d26:b0:896:f61e:15f7 with SMTP id 6a1803df08f44-89a81d942f0mr61721186d6.15.1773426446090; Fri, 13 Mar 2026 11:27:26 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-142-162-112-119.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.162.112.119]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-89a65d2ab43sm61664086d6.53.2026.03.13.11.27.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Mar 2026 11:27:25 -0700 (PDT) Received: from jgg by wakko with local (Exim 4.97) (envelope-from ) id 1w17EK-00000007Ln4-3lxb; Fri, 13 Mar 2026 15:27:24 -0300 Date: Fri, 13 Mar 2026 15:27:24 -0300 From: Jason Gunthorpe To: Jonathan Cameron Cc: "Aneesh Kumar K.V (Arm)" , iommu@lists.linux.dev, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, Kevin Tian , Joerg Roedel , Will Deacon , Bjorn Helgaas , Dan Williams , Alexey Kardashevskiy , Samuel Ortiz , Xu Yilun , Suzuki K Poulose , Steven Price Subject: Re: [PATCH v2 1/3] iommufd/viommu: Allow associating a KVM VM fd with a vIOMMU Message-ID: <20260313182724.GJ1704121@ziepe.ca> References: <20260309111704.2330479-1-aneesh.kumar@kernel.org> <20260309111704.2330479-2-aneesh.kumar@kernel.org> <20260311211742.0000391c@huawei.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260311211742.0000391c@huawei.com> On Wed, Mar 11, 2026 at 09:18:07PM +0000, Jonathan Cameron wrote: > > +#if IS_ENABLED(CONFIG_KVM) > > Hmm. Really a question for Jason / Kevin, but so far this file is ifdef free. > Should we keep it that way by spinning this stuff off to a separate .c file, > or maybe use if (IS_ENABLED()) the implementation which I think means > we need a stub for file_is_kvm()? I'd prefer we add the stub, then you don't need any of these ifdefs either.. Jason