From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 952C61C3BEB; Sat, 14 Mar 2026 09:57:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773482233; cv=none; b=hakzcYGK6B+pjfDROBO9KpnSQDMnIKpwIVn1iaNG56ZIRPy9UK+rTCghSE9/+5ZJJe308cVS5Kai6hMRtFXX2YObFlr+Xm8lX8zeebYKkv2kEL7D9Z2tiKudfMzXK8H4pS0PW8mVJQmZO01zZzyNf8RGu8XzwCC8QDmhuTZPoCs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773482233; c=relaxed/simple; bh=09501woOjD4eRvQIVfFayJgg97/evg9zfkOZpWm9MNE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Whu5yxtHqbvErheT+Xwn0wANU7gfY53C5XccchAeWCQzoEjBycuqhrtF7jbw7CHt9Vd3YMBAlRBe2SPthzbH4tlWMVV8K3KHQY3SkqrAMJ78aVnHWZL7++DtkQ/c/JXLxtjj18T92iq/hDIx5j/+h8hu/0nslakBUuBENHp0brQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=oVSSodaN; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="oVSSodaN" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B7CB7C116C6; Sat, 14 Mar 2026 09:57:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1773482233; bh=09501woOjD4eRvQIVfFayJgg97/evg9zfkOZpWm9MNE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=oVSSodaNypOctz3Mvmnd4m3SlYGxQE/t7pz2EmL+ekBbsI8GAUgRk/hRn3ByvAs5h z96k502Vg26VrEEjdeLNXzFpsFaVtw+cPF/ee/0TB4DnKCBLzWsofCPZCQDocZjw2i aAzw5IGMS31SQ/YpxVEWoBlNI2u/fi6bUfzd8JbDQC44gw8GQvkmEdRTTjFRbBOCOV ROSCW8bRdrJFoQU63HvNxr9Fs/isKEgTtxuOS9iAgpkr987lhafcYjrM7N9gPtCu/y FLDyZxl7iYBXOmUywr7KkkXsqAEFhVN8h4rVsuiAkq/61mdQvIMikddfjxx/4PkzKg pbz9bDnElBTNQ== Date: Sat, 14 Mar 2026 10:57:10 +0100 From: Krzysztof Kozlowski To: Jian Hu Cc: Jerome Brunet , Neil Armstrong , Kevin Hilman , Martin Blumenstingl , Stephen Boyd , Michael Turquette , robh+dt , Rob Herring , Krzysztof Kozlowski , Conor Dooley , devicetree , linux-clk , linux-amlogic , linux-kernel , linux-arm-kernel , Ronald Claveau , Ferass El Hafidi Subject: Re: [PATCH v2 2/3] dt-bindings: clock: amlogic: t7: Add missing mpll3 parent clock Message-ID: <20260314-splendid-thoughtful-ostrich-c211dc@quoll> References: <20260313070022.700437-1-jian.hu@amlogic.com> <20260313070022.700437-3-jian.hu@amlogic.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20260313070022.700437-3-jian.hu@amlogic.com> On Fri, Mar 13, 2026 at 03:00:21PM +0800, Jian Hu wrote: > The mpll3 clock is one parent clock of the sd_emmc and mipi_isp clocks > on the Amlogic T7 SoC, but was missing from t7-peripherals-clkc.yaml > bindings. Add the mpll3 clock source to the T7 peripherals clock > controller input clock list, so that sd_emmc and mipi_isp can use it. > > For logical consistency, place the required mpll3 entry before the > optional entry. > > This change breaks the ABI, but while the amlogic,t7-peripherals-clkc > bindings have been merged upstream, the corresponding DT has not been > merged yet. Thus, no real users or systems are affected. > > Fixes: b4156204e0f5 ("dt-bindings: clock: add Amlogic T7 peripherals clock controller") > Signed-off-by: Jian Hu > --- > .../bindings/clock/amlogic,t7-peripherals-clkc.yaml | 12 ++++++++---- > 1 file changed, 8 insertions(+), 4 deletions(-) This should go for current fixes cycle and your cover letter is silent about it, while patchset combines fixes and non-fixes. You clearly don't care about maintainers time for deciphering all this. Well, not my problem. Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof