From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 921BA23EAB0 for ; Sat, 14 Mar 2026 01:46:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773452793; cv=none; b=KSDwdkxJeBmeSpj9tJjgHHy5+h9k6EdlSBEs+olZO6kwp/sj1YCNNwJE9ZpjIHyj1GpWo79pgabwv5SkjNW4JKs3P2mkSI+3ylZQE1x5FPMKPPOLo2SEx+OWPHIn9D/dhcBQux7yYlzbY+g6PTxZ+1KafbXEhWxgxOnB9E9lvaY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773452793; c=relaxed/simple; bh=OPh4VU7qt0AmdUFkmu6okZDByDkjAdiVh7qa6o2rGNE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=QMCK6rNZBEBEtP6pfSqlDQkhj50BUL8Q78bphBOtO0TDL2BGdXIO1FVVrlJOlXH3wqIciwpz1dHUAU0KfgJNTRIqaGM3VHy+pARSaUde8zrkWTBA1r2jfvHwXiDNJzXmb+XJ05rVn3yV9TcfJQ3PVNcDlRXjQcIgklpXV8HKKsc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=IR+b1wF4; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="IR+b1wF4" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 14E68C19421; Sat, 14 Mar 2026 01:46:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1773452793; bh=OPh4VU7qt0AmdUFkmu6okZDByDkjAdiVh7qa6o2rGNE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=IR+b1wF4LYYt1HFZ5PS1RrxfTaE0AkNFqYN61Awc7WyxX9rPQkawmZhBOdMAttsYp 2yg70DSh+zVF47nTEpy7fGYVoY5gbx+oM5oj13xoXXe3vLfL4Jjdc7zDk6msXXMOyO cMUxKjWQaVOyU30MEh1DJn2hRGFrVUqoQ096l6cV7pTnHHwbX4BeMPU6mTCLYWwMcQ UTAXADjcbpHPwSNejrkTx+JfXqXCIQVnErqLNAaTw4rNnpGkdLoee/jBtxtfbCxV8z vxi72bG2PcZ3SwUK+bKBDWYFeoI8Jogx+QxxGp0isQzTT7nesP4B5J2oVU9Aw0P65v 9a9bjqIwwacuQ== Date: Fri, 13 Mar 2026 18:46:28 -0700 From: Nathan Chancellor To: Uros Bizjak Cc: x86@kernel.org, linux-kernel@vger.kernel.org, "Peter Zijlstra (Intel)" , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Nick Desaulniers , Bill Wendling , Justin Stitt Subject: Re: [PATCH -tip v3 3/4] x86/segment: Use ASM_INPUT_RM in __loadsegment_fs() Message-ID: <20260314014628.GA1012212@ax162> References: <20260312215916.258176-1-ubizjak@gmail.com> <20260312215916.258176-3-ubizjak@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260312215916.258176-3-ubizjak@gmail.com> On Thu, Mar 12, 2026 at 10:58:57PM +0100, Uros Bizjak wrote: > Use the ASM_INPUT_RM macro in __loadsegment_fs() to work around clang > problems with "rm" asm constraint. clang seems to always chose the > memory input, while it is almost always the worst choice. > > Signed-off-by: Uros Bizjak > Acked-by: "Peter Zijlstra (Intel)" Acked-by: Nathan Chancellor > Cc: Thomas Gleixner > Cc: Ingo Molnar > Cc: Borislav Petkov > Cc: Dave Hansen > Cc: "H. Peter Anvin" > Cc: Nathan Chancellor > Cc: Nick Desaulniers > Cc: Bill Wendling > Cc: Justin Stitt > --- > arch/x86/include/asm/segment.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/x86/include/asm/segment.h b/arch/x86/include/asm/segment.h > index 3fe3a310844c..0f4283dcd0c4 100644 > --- a/arch/x86/include/asm/segment.h > +++ b/arch/x86/include/asm/segment.h > @@ -335,7 +335,7 @@ static inline void __loadsegment_fs(unsigned short value) > > _ASM_EXTABLE_TYPE(1b, 2b, EX_TYPE_CLEAR_FS) > > - : : "rm" (value) : "memory"); > + : : ASM_INPUT_RM (value) : "memory"); > } > > /* __loadsegment_gs is intentionally undefined. Use load_gs_index instead. */ > -- > 2.53.0 >