From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f50.google.com (mail-pj1-f50.google.com [209.85.216.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DC6EB34AAE3 for ; Sat, 14 Mar 2026 20:39:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773520766; cv=none; b=PLp6NR8pqJ403qmxJ2FgvsArp8PLEdW4f3xdVVFXvFv60lYpSLop5twu/OhNkm7C3Bn93F4DYXPn+5Lejequw2cRqUiaufbb6hLJwgKccoV9Yi7o3tskoHjBON7E3+eC0AuLUB2fwYH6mREpxVVrp2hdr/d5i3rRXjvuqdrskWA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773520766; c=relaxed/simple; bh=t0b4Am2SaTc5Rzzo1GzW6/r13JVH+GhSKnA6pfhvMZA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=qrxBRegfjCgqUsTwqqrUQEJIvZLphZaav39RY7beAb5ttBspmPz05sjvm+MrnvFYSFLOlzzBlu/M1UofbQq8zpowrFTEMROptLozKEKdV0YvkZ3QWMyZdpmstHRY4F7IgM+JI5P/aW7jMvp2CfwGdl/i1g5MzB/VtPvE+vDZ1Uw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.com; spf=pass smtp.mailfrom=gmail.com; arc=none smtp.client-ip=209.85.216.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pj1-f50.google.com with SMTP id 98e67ed59e1d1-3585ec417f6so1577859a91.1 for ; Sat, 14 Mar 2026 13:39:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773520765; x=1774125565; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bXX5VKHaTVlA5Twk1yI3TOmkIkEJcCj90rxXtOUyRQ4=; b=mlOgFkCD56k+S4elzLH++im7jaEWouagFna5t6dhiqVwmx156M9ypVB7FLOSuaUY3r A+qiKzgPolbVF0sBV0Mo2rUZMV3GlMnpgMYypAThl7RCdKlvntKIBwucuFImx/V1NwsG fVRZqaNLcnr/kZ3ApVIZ3E+mLhyHTok+Vz1hyOExQhD5chszTBPqeOmcKylcjHFL6j7n iWShE4beiBqhV5jp0xmh1L/2Y+Qn7uelhMNyErN/t3VvBPIDsQwPe5HNMLxMasXmKUK5 A2JmT3D/rTTA2CzzEgMJCFtm2wfeUpq8t0nziLh0ujTSnXFxpsMHC3qS6EThuK46K+y7 D1Bg== X-Forwarded-Encrypted: i=1; AJvYcCW5vEtJrFH4KBH5f7XwxYX19kFAW2KEMOYr9YBup8WmpK1WdEjhgSyPKBg3cFeE8OUKl2PUOo0deAmOjf0=@vger.kernel.org X-Gm-Message-State: AOJu0YzBTMvht/K06ym+3EGNjs/aDBst3lG6UeVxYniPX59u5ZBcipRO vb78waTrNwyqT0ogRDQCRUasd/jc5GqhKgYg+2ykRMYHV2/4KCq8vHTw X-Gm-Gg: ATEYQzxOocbFNscFqHdGkm7mHIG8bQYCEk/v2JrOiqlef+CFEi3LUmwdbCNeumkKcGB jSB/kieYLDihq0MgUwClGcnDQaYTq9MssUIqUitKSW5cpKGpDZ9Q2zgqvQ1B/WolDPyW2o7+nIV vOs7iT2XkgI0w3WCkOHHQ9mB9qsG8arXocUFW+KgdmKwYmeQq4BFSuH22qq5jx9iljyJLXT2vLR 1qd8+EIjipAAs8BOpSbB9Q0eaBGs4d+QWmdyAJEO3rv5BA9eF7sSSHa1iJz2jUcvUH+eOn4Q3+w n69FgXTbng/G9cssDQRLNC+ZXxOT6IyQZq1KNmfs494CVYyHaB3CLdgk7RwF5vppVwZlWwE8nDD Xf2WxPpEFELgyean1vssRmZHq+N7fDWJ70sh9lu8T6WxuPYCDyaPpv4hos5bmfT16078l0J3PwT H5tCRfejkhw9/pfbh1KGx3IhkylNzaNk+brqSOC2AiQTHWmKFgJ2klUneLRpQoKh8zG6rW+CvoO L37B8R8NycJ2OmALdbdr8UbkovWBMRuZm967TYLGTHhf+B2WqM= X-Received: by 2002:a17:90b:1d86:b0:35b:92ba:66e4 with SMTP id 98e67ed59e1d1-35b92ba6ab1mr1025801a91.7.1773520765158; Sat, 14 Mar 2026 13:39:25 -0700 (PDT) Received: from localhost (fpd11144dd.ap.nuro.jp. [209.17.68.221]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35a02ffdfb7sm14869036a91.14.2026.03.14.13.39.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 14 Mar 2026 13:39:24 -0700 (PDT) Date: Sun, 15 Mar 2026 05:39:23 +0900 From: Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= To: smadhavan@nvidia.com Cc: bhelgaas@google.com, dan.j.williams@intel.com, dave.jiang@intel.com, jonathan.cameron@huawei.com, ira.weiny@intel.com, vishal.l.verma@intel.com, alison.schofield@intel.com, dave@stgolabs.net, alwilliamson@nvidia.com, jeshuas@nvidia.com, vsethi@nvidia.com, skancherla@nvidia.com, vaslot@nvidia.com, sdonthineni@nvidia.com, mhonap@nvidia.com, vidyas@nvidia.com, jan@nvidia.com, mochs@nvidia.com, dschumacher@nvidia.com, linux-cxl@vger.kernel.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 6/7] cxl: Add cxl_reset sysfs interface for PCI devices Message-ID: <20260314203923.GA672783@rocinante> References: <20260306092322.148765-1-smadhavan@nvidia.com> <20260306092322.148765-7-smadhavan@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260306092322.148765-7-smadhavan@nvidia.com> Hello, > +static ssize_t cxl_reset_store(struct device *dev, > + struct device_attribute *attr, > + const char *buf, size_t count) > +{ > + struct pci_dev *pdev = to_pci_dev(dev); > + int rc; > + > + if (!sysfs_streq(buf, "1")) > + return -EINVAL; Not sure what would the pattern/approach be for CXL sysfs entires, but perhaps using kstrtobool() would work here? It handles all the boolean types user could pass. Thank you, Krzysztof