mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Dhruva Gole <d-gole@ti.com>
Cc: Shi Hao <i.shihao.999@gmail.com>, <andriy.shevchenko@intel.com>,
	<andy@kernel.org>, <dlechner@baylibre.com>,
	<linux-iio@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<marcelo.schmitt@analog.com>, <nuno.sa@analog.com>,
	<mazziesaccount@gmail.com>, <daniel.baluta@nxp.com>,
	<simona.toaca@nxp.com>
Subject: Re: [PATCH v4 0/6] iio: fix spelling mistakes in comments
Date: Sun, 15 Mar 2026 13:07:43 +0000	[thread overview]
Message-ID: <20260315130743.0dc0aebf@jic23-huawei> (raw)
In-Reply-To: <20260311101007.gaqcner4fzamyirm@lcpd911>

On Wed, 11 Mar 2026 15:40:07 +0530
Dhruva Gole <d-gole@ti.com> wrote:

> On Mar 11, 2026 at 15:09:27 +0530, Shi Hao wrote:
> > This series fixes spelling mistakes in comments across several IIO
> > subsystems to improve readability and code consistency.  
> 
> I just tried applying this series locally, on top of linux-next tag: next-20260310

Agreed. The series seems to have some corruption issues.

Linux-next is very unlikely target for pretty much anything!
Maybe it'll have the right patches at a given moment, maybe not.

> 
> Could you please make sure to use git format-patch with the option --base HEAD~N
> where N is the number of your patches?
> This will help identify what you used as the base commit for all your
> changes. Make sure it's usually on top of the latest linux-next.
> 
> I also ran checkpatch on them, and saw a bunch of errors and warnings,
> not sure if you've run it on your end and ensured it's clean?

I would very much take those warnings lightly. By all means check
them but I ran it on the first patch and it generated completely
incorrect changes because it was interpreting comment blocks
as code.

> 
> > 
> > v4:
> > 
> > - Fix commit message grammar and punctuation across patches
> > - Keep 'whilst' instead of 'while'
> > - Rephrase sentence in chemical driver comment
> > - Capitalize IIO in comments  
> 
> Also, in the changelog, please add links to your previous revisions.
> This make reviewing things and getting context much easier.
> 
> > 
> > v3:
> > 
> > - Change commit subjects as per changes
> > - Capitalize proper acronyms (IRQ) and Celsius
> > - Fix short wrap in commit body
> > 
> > v2:
> > 
> > - Split original patch into 6 commits
> > - Fixed commit message formatting and typos
> > - Added necessary tags in commits
> > - Added more fixes then previous
> > 
> > Shi Hao (6):
> >   iio: accel: fix typo celcius to Celsius
> >   iio: adc: fix spelling mistakes in comments
> >   iio: amplifiers: fix typo Curren to Current
> >   iio: cdc: fix spelling mistakes in comments
> >   iio: chemical: rephrase sentence and fix typo in comment
> >   iio: common: fix spelling mistakes in comments
> > 
> >  drivers/iio/accel/adis16201.c                          | 2 +-
> >  drivers/iio/accel/adis16209.c                          | 2 +-
> >  drivers/iio/adc/ad4030.c                               | 2 +-
> >  drivers/iio/adc/ad4170-4.c                             | 6 +++---
> >  drivers/iio/adc/ad7380.c                               | 2 +-
> >  drivers/iio/adc/ad7887.c                               | 2 +-
> >  drivers/iio/adc/ad7923.c                               | 4 ++--
> >  drivers/iio/adc/at91_adc.c                             | 4 ++--
> >  drivers/iio/adc/max1363.c                              | 2 +-
> >  drivers/iio/adc/mcp3564.c                              | 2 +-
> >  drivers/iio/adc/men_z188_adc.c                         | 2 +-
> >  drivers/iio/adc/npcm_adc.c                             | 2 +-
> >  drivers/iio/adc/palmas_gpadc.c                         | 2 +-
> >  drivers/iio/adc/rohm-bd79124.c                         | 4 ++--
> >  drivers/iio/adc/spear_adc.c                            | 2 +-
> >  drivers/iio/adc/stm32-adc-core.c                       | 2 +-
> >  drivers/iio/adc/stm32-adc.c                            | 2 +-
> >  drivers/iio/adc/sun20i-gpadc-iio.c                     | 2 +-
> >  drivers/iio/adc/ti_am335x_adc.c                        | 2 +-
> >  drivers/iio/adc/twl4030-madc.c                         | 2 +-
> >  drivers/iio/adc/twl6030-gpadc.c                        | 4 ++--
> >  drivers/iio/amplifiers/ada4250.c                       | 2 +-
> >  drivers/iio/cdc/ad7150.c                               | 2 +-
> >  drivers/iio/cdc/ad7746.c                               | 2 +-
> >  drivers/iio/chemical/bme680_core.c                     | 2 +-
> >  drivers/iio/common/cros_ec_sensors/cros_ec_sensors.c   | 2 +-
> >  drivers/iio/common/hid-sensors/hid-sensor-attributes.c | 2 +-
> >  drivers/iio/common/inv_sensors/inv_sensors_timestamp.c | 2 +-
> >  drivers/iio/common/ms_sensors/ms_sensors_i2c.c         | 2 +-
> >  29 files changed, 35 insertions(+), 35 deletions(-)
> > 
> > --
> > 2.53.0  
> 


      parent reply	other threads:[~2026-03-15 13:08 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-11  9:39 Shi Hao
2026-03-11  9:39 ` [PATCH v4 1/6] iio: accel: fix typo celcius to Celsius Shi Hao
2026-03-11  9:39 ` [PATCH v4 2/6] iio: adc: fix spelling mistakes in comments Shi Hao
2026-03-11  9:39 ` [PATCH v4 3/6] iio: amplifiers: fix typo Curren to Current Shi Hao
2026-03-11  9:39 ` [PATCH v4 4/6] iio: cdc: fix spelling mistakes in comments Shi Hao
2026-03-11  9:39 ` [PATCH v4 5/6] iio: chemical: rephrase sentence and fix typo in comment Shi Hao
2026-03-11  9:39 ` [PATCH v4 6/6] iio: common: fix spelling mistakes in comments Shi Hao
2026-03-11 10:10 ` [PATCH v4 0/6] iio: " Dhruva Gole
2026-03-15 12:44   ` ShiHao
2026-03-15 18:05     ` Jonathan Cameron
2026-03-15 13:07   ` Jonathan Cameron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260315130743.0dc0aebf@jic23-huawei \
    --to=jic23@kernel.org \
    --cc=andriy.shevchenko@intel.com \
    --cc=andy@kernel.org \
    --cc=d-gole@ti.com \
    --cc=daniel.baluta@nxp.com \
    --cc=dlechner@baylibre.com \
    --cc=i.shihao.999@gmail.com \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcelo.schmitt@analog.com \
    --cc=mazziesaccount@gmail.com \
    --cc=nuno.sa@analog.com \
    --cc=simona.toaca@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®