From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.alien8.de (mail.alien8.de [65.109.113.108]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 16A0035F8B9 for ; Sun, 15 Mar 2026 13:14:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=65.109.113.108 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773580479; cv=none; b=BS8nmoVkghXCiTz3k7msYPOQ78+dWSPz2ac7pHO/Q5NghRBNNpEaiWhYUUI4qBv/3IdZESbP9xdEqlzyvlHFiyl7tcjWHAk2bg1FgIXy+A6vLyWD6GWu9PxXL6hZvSS7wkjD+vHkL8Idwb0a4wCsP5B8y8sm2eFVjme3Pe/g9bI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773580479; c=relaxed/simple; bh=AGLeg7O4pbWXkYyRxPRuYcOsa3FwjU3CP8+9seDv5lI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=nAYoabkaUUBBILRIYBMQOeKyj/5ho8dBX8cJS8tj4CD92FM+dSWjwZVFZLHnciZPXE7KvhmDx7XoGHKwPCOAyvJICcYgMKv+RdkdCvy443/9Y/RjlH8o7zKiqwZ5QumZt8C9u6DkcMF2Oiz0TzF1kpLvL3l7pLg3QbfJrprfE6s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=alien8.de; spf=pass smtp.mailfrom=alien8.de; dkim=pass (4096-bit key) header.d=alien8.de header.i=@alien8.de header.b=Av2RoR+c; arc=none smtp.client-ip=65.109.113.108 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=alien8.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=alien8.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (4096-bit key) header.d=alien8.de header.i=@alien8.de header.b="Av2RoR+c" Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTP id E790640E021E; Sun, 15 Mar 2026 13:14:32 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at mail.alien8.de Authentication-Results: mail.alien8.de (amavisd-new); dkim=pass (4096-bit key) header.d=alien8.de Received: from mail.alien8.de ([127.0.0.1]) by localhost (mail.alien8.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id uKU5Nd8oDVdi; Sun, 15 Mar 2026 13:14:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=alien8; t=1773580468; bh=gCppaa5r7WINQn/vjeKbBf5jMNaRvfDjJUnnZA7Irjo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Av2RoR+cy0zhpWUR69QcripTojN6XGOBRqgJIjtDijinh9xMImwd0JRx3Q2dtqaPS xdDOCJvxmptvUbZT4UajrnWxaIYZQBJkoMOqdgT/s00uJ9wfdcLkTCnm9SNbA7vPPC 64cjEvF6MiXWtxyZeOmJD/QTK1Nfc5ovOmbLcxfon0yFOxwM2UijhMY6qZh/IssFBi HOUYIAb29nSjFPHvqL6jk3GATnIq+wN5GOBX4N6lVn+mxS7LjnZJNAkeqXzTNxlqYe qx5GAtJ9vPQLigHIoHY6mr0HJo+fgbRCpm7Q/MVEmvUiEqCR/yNgsjl8mO11cGHVBw o/nHPbkWAav/ov4yfjbTT/tHkf9zNHYUkjzPDmEJFW9l6m6+/Hu6E4LGKKJrZPyik0 4n0vwkIrZIgXdms3Y3T7a9kAkCVm/CS9JduTMsRTVmmMUVk72XVCMMHaT9+/JpnR6i y7swHsF5jPcJke+9ZvoM8l6E6Vr+RAvE6DdK6BGDAsEVblqJ2tcgc/1Z5kgeRwkosR z8pxhAXXjBVm3GVsZw1HsKxHXkNgRmB+J6kNu7R0tlxcK/pCpsOyXPRDR9yYl88Rxk xIPcpbqptncAwz7dpej4hLiTK98ZJ0VTNXha/bNGX/wQaxfs17KPnIrlBlkEZgbleg bRHHCCy0OXxpyUJL9wy9688Q= Received: from zn.tnic (p5de8e020.dip0.t-ipconnect.de [93.232.224.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with UTF8SMTPSA id D210E40E0213; Sun, 15 Mar 2026 13:14:23 +0000 (UTC) Date: Sun, 15 Mar 2026 14:14:16 +0100 From: Borislav Petkov To: "Mario Limonciello (AMD)" Cc: Yazen Ghannam , Jean Delvare , linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 5/5] x86/CPU/AMD: Print AGESA string from DMI additional information entry Message-ID: <20260315131416.GVabawqKuPkYKShXpn@fat_crate.local> References: <20260123213056.861317-1-superm1@kernel.org> <20260123213056.861317-6-superm1@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20260123213056.861317-6-superm1@kernel.org> On Fri, Jan 23, 2026 at 03:30:56PM -0600, Mario Limonciello (AMD) wrote: > From: Yazen Ghannam > > Type 40 entries (Additional Information) are summarized in section 7.41 > as part of the SMBIOS specification. Generally, these entries aren't > interesting to save. > > However on some AMD Zen systems, the AGESA version is stored here. This > is useful to save to the kernel message logs for debugging. It can be > used to cross-reference issues. > > Implement an iterator for the Additional Information entries. Use this > to find and print the AGESA string. Do so in AMD code, since the use > case is AMD-specific. Look what I said the last time: https://lore.kernel.org/r/20260126130755.GIaXdnK65MTIiXqg-l@fat_crate.local I'll have to teach AI to give feedback for commit messages explaining the diff. > Signed-off-by: Yazen Ghannam > Co-developed-by: "Mario Limonciello (AMD)" > Signed-off-by: "Mario Limonciello (AMD)" > --- > v5: > * Return "" in !CONFIG_DMI case (LKP robot, Yazen) > v4: > * New patch (based upon older versions though) > --- > arch/x86/kernel/cpu/amd.c | 53 +++++++++++++++++++++++++++++++++++++ > drivers/firmware/dmi_scan.c | 3 ++- > include/linux/dmi.h | 18 +++++++++++++ > 3 files changed, 73 insertions(+), 1 deletion(-) > > diff --git a/arch/x86/kernel/cpu/amd.c b/arch/x86/kernel/cpu/amd.c > index bc94ff1e250ad..aa04a27aeb107 100644 > --- a/arch/x86/kernel/cpu/amd.c > +++ b/arch/x86/kernel/cpu/amd.c > @@ -1,6 +1,7 @@ > // SPDX-License-Identifier: GPL-2.0-only > #include > #include > +#include > #include > #include > #include > @@ -1404,3 +1405,55 @@ static __init int print_s5_reset_status_mmio(void) > return 0; > } > late_initcall(print_s5_reset_status_mmio); > + > +static void __init amd_dmi_scan_additional(const struct dmi_header *d, void *p) > +{ > + struct dmi_a_info *info = (struct dmi_a_info *)d; > + void *next, *end; > + > + /* > + * DMI Additional Info table has a 'count' field. But it's not very > + * helpful since the entries are variable length. So don't use it. > + */ > + if (info->header.type != DMI_ENTRY_ADDITIONAL || > + info->header.length < DMI_A_INFO_MIN_SIZE) > + return; > + > + /* > + * Get the first entry. > + * The minimum table size guarantees at least one entry is present. > + */ > + next = (void *)(info + 1); > + end = (void *)info + info->header.length; >From last time: "This end needs to be corrected to some sane upper limit because we don't trust firmware one bit." Lemme stop review here until you address all review comments from the last time. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette