From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f228.google.com (mail-qt1-f228.google.com [209.85.160.228]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3703430BF4F for ; Sun, 15 Mar 2026 14:17:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.228 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773584280; cv=none; b=JtYwnqi5EeWjAMj0qwd7P5KIaR7bX3ltjfLRU27tnjPnqCC+znFMLB9JIHY7xvYt+2Gs1gD6dLtFprx6f6fIJsFQBjycL6Wfemw8EkmsPfUUrY7gWtkxVTmY17EWP43udS0H2vDJGBWeLEJXbtIZSbZ77385GYoqgwvQu03ROzY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773584280; c=relaxed/simple; bh=I+lq2v+1zmqDeDsa7KGRrvIAprHY+6ICozCWu0Goz08=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=gkKxIk1usLu47A1ryv7/Re4UdDauJkdy4HKojaBcwOU2Re4hHfI7gkCMEVAzTBjgZM8np72zfbS9i+J9sOG8l5nCC6O0cMQWEwXFov23uUiwDf3FADdlW/SWkVZFVB3Ei3SUjgJgqERCcayfx+opGxgfVV25ODdiWXNMI8lGbS8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=Psp5/3SQ; arc=none smtp.client-ip=209.85.160.228 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="Psp5/3SQ" Received: by mail-qt1-f228.google.com with SMTP id d75a77b69052e-50917417efbso34024621cf.0 for ; Sun, 15 Mar 2026 07:17:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773584278; x=1774189078; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:dkim-signature:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=SlbjD89zevPMO446qciTilc7XLAL6p3qLcyMckAPxvg=; b=LlQO7+qs9ve1YQ5eu7xWIiBzARDOjYYFyH+RGKfatsswmsB/i5ytN+ziLkPcxYV8P7 2R8wRvURA3z2z6sb+D4gyn1sJPQxu+cYDeCT7ulqmgrqWtVcbyVhLXFMrXKTKmaNp43d FWmSrC9LP1qXdeLQR4RCW4hsvEmwch/DMNoz2NXf39oDKVuS26lt4uOdut7wteTekQgB 5VPzEkxFjPtf6akVIpxtUbYkVl+u8/aynr7o6GauzMdisESYj0YMcjvH2MZ/tqwYANYY moaiRqOovfzQqEl2rEmH+n0HobrkBB8uC3Ek6USOBTRqBmEkgOGvWl3jxQ8IodQMVSaf RyOA== X-Forwarded-Encrypted: i=1; AJvYcCWbkdTiANMDpzWi3CdidTxLAquk0/SZ5YlrNWP3bCLFrpeiIK/AYBcMblejMEmhz4gZiNfXzwm4EdDKpus=@vger.kernel.org X-Gm-Message-State: AOJu0YzDlLx1eMEO5wQk5n/bOiR677nXpF3LY0MUJsdhRsFWPnxOVo0y dk6q5upEYXqefUXK6lwFJshPYxM9yTwofpRLmZqp2ObAOkcO2u8/aWll6ZZEEj7l0wyH24xmXDS ZoM1PUFJNoj7u1C5M2G4sN+34ixjqFnKwfIFS1OdI0vVy/cFbQ1J/vntCb++6U5ToIACtw82SEv ZiCQpMOBFZf742Xel64SUkPkQH0q9JkPa+yARTcskkNHfxHzJxIIqFYSM1EBbWrMropcoYcaLAk d6F3liNwiLFXYSZcA== X-Gm-Gg: ATEYQzzd6EfTYfKVajE88EuwRNv/WSh5senP96UQfdaj6XXvgZ98vmzmJZjFIRfLy5+ xRmP9I9Y8/Qo2F19Raf1rjaB2A8CdjQzQl9bsTE+lN25pQS61Z9xxAL5fNNUGbNx0cwoVHF2K0B jwoGdN7LQJag/p5IPUphIXs7BWscCVwIcZWsig4tomXVn+eDge2eCLEfhMrQ3mq5m7AmsrwoyEx A6Cl7RqjboKZkexWueDalpomHSE3L0Hl9SHeC7ou2xyUVGn2/cZOdSqDNsm1I6uWvOuEcnJiQQa lOVxCgXyzUMIb8tuhY5J+faUC3fX9THetBPuWdb3xr1B8Hdm3lpr3+rTWo34CdvgfMkbjCbCSI7 hDEKfr85W4dt4Bk5csCtsYNvbqJ3r/2EKXfBmSD5uZ9Dcx9ONrvSvXQg3EI3wod/Szd6zGXjasQ ghWJvmRBX/24Ja8wld6IKmP7ns1od/90PgzLeVZCB2hA0KGMu0J1XRZlc= X-Received: by 2002:a05:622a:1185:b0:508:ffad:4bf4 with SMTP id d75a77b69052e-5094707b39bmr163613071cf.5.1773584278056; Sun, 15 Mar 2026 07:17:58 -0700 (PDT) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-63.dlp.protect.broadcom.com. [144.49.247.63]) by smtp-relay.gmail.com with ESMTPS id d75a77b69052e-5093a1080besm15612541cf.6.2026.03.15.07.17.57 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 15 Mar 2026 07:17:58 -0700 (PDT) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-2ae4b96c259so52213475ad.1 for ; Sun, 15 Mar 2026 07:17:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1773584277; x=1774189077; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=SlbjD89zevPMO446qciTilc7XLAL6p3qLcyMckAPxvg=; b=Psp5/3SQSquCG9FLfkorv4iE6MvZu8osKyAwsL/W+NfzffDPawFfu3Q/KJ4dYD8jkJ pTg3OPL6nL4dZLDfte9PHIG69/peEoEe5Edvk1SZp9mgz08BS6yTBOR0cY6i0Oz2kyA4 kwplyAabzV1mYbqsPH/PFxtbbXdjy+HjDafjM= X-Forwarded-Encrypted: i=1; AJvYcCUeRHAhN2RJIwIli/CJiEm7AZxn5HhvquDxCe0iswb6ifYfeoAQMLEOK7IvdoGFD9RC6xe/vXvDtL6PPcs=@vger.kernel.org X-Received: by 2002:a17:902:d50e:b0:2ae:5ab4:f4c0 with SMTP id d9443c01a7336-2aeca59a65emr105877075ad.13.1773584276647; Sun, 15 Mar 2026 07:17:56 -0700 (PDT) X-Received: by 2002:a17:902:d50e:b0:2ae:5ab4:f4c0 with SMTP id d9443c01a7336-2aeca59a65emr105876785ad.13.1773584276194; Sun, 15 Mar 2026 07:17:56 -0700 (PDT) Received: from localhost.localdomain ([192.19.203.250]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2aece56c393sm76185395ad.17.2026.03.15.07.17.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 15 Mar 2026 07:17:55 -0700 (PDT) From: Vikas Gupta To: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, michael.chan@broadcom.com, pavan.chebbi@broadcom.com, vsrama-krishna.nemani@broadcom.com, rajashekar.hudumula@broadcom.com, ajit.khaparde@broadcom.com, Vikas Gupta Subject: [PATCH net-next v7 00/10] bng_en: add link management and statistics support Date: Sun, 15 Mar 2026 19:45:55 +0530 Message-ID: <20260315141605.410878-1-vikas.gupta@broadcom.com> X-Mailer: git-send-email 2.47.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e Hi, This series enhances the bng_en driver by adding: 1. Link/PHY support a. Link query b. Async Link events c. Ethtool link set/get functionality 2. Hardware statistics reporting via ethtool -S This version incorporates feedback received prior to splitting the original series into two parts. Addressed following comments from Andrew Lunn - Apply Rev-xmas fix in several places. - Correct ethtool-speed comment to reflect accurate behavior. https://lore.kernel.org/netdev/49930724-74b8-41fe-8f5c-482afc976b82@lunn.ch/ https://lore.kernel.org/netdev/CANXQDtb5XuLKOOorCMYDUpVz6aFuQgvmQZ4pS6RJGkAgeM8n1A@mail.gmail.com/ Addressed following comments from Jakub Kicinski - Took care of missing mutex_init() https://lore.kernel.org/netdev/20251127190855.69779791@kernel.org/#t https://lore.kernel.org/netdev/CANXQDtYy2JziaaVi=Cqt+gAJNt4NjFFs8NbhrS=RBV61ORwinA@mail.gmail.com/ Addressed following comments from ALOK TIWARI - Add newline for clarity/formatting. https://lore.kernel.org/netdev/CANXQDtZbLhdwEtN+kKg1OVLV+uy-gsNfX+rU4MR77QPuO6_y9A@mail.gmail.com/ v7: - Addressed the two valid issues reported by AI (Jakub Kicinski). - Fixed minor issues reported by Alok Tiwari. - Addressed the concern of statistics duplication raised by Jakub Kicinski. A few statistics (discards/errors) have been made part of the standard netdev statistics and removed from ethtool -S. Additionally, a few statistics that require proper implementation have been removed and will be addressed in a later series, for example, get_pause_stats and get_fec_stats. https://lore.kernel.org/netdev/20260312192251.61243873@kernel.org/#t v6: - Resending the full series due to an SMTP failure during v5 submission. - No functional changes from v5. v5: Address Jakub Kicinski's comments by holding the instance lock across the entire service task (instead of flag-based locking) and checking the OPEN bit under the lock to resolve the close-path deadlock. v4: Addressed comments from Jakub Kicinski: - Explicitly size speed mask arrays to remove the need for manual sentinels in the hardware configuration. - Fix an off-by-one error in the queue index bound check. - Standardize ethtool -S per-ring stat naming to "rxq$id_$name" (e.g., rxq0_errors). Removed spaces and brackets to ensure compatibility with parsing scripts. - Exclude ethtool -S global counters (tx_err, tx_fifo_underruns, tx_total_collisions) already covered by rtnl_link_stats64. v3: Addressed comments from Andrew Lunn: - Fix a comment and refactor bnge_hwrm_set_pause() to improve code readability. Addressed comments from Jakub Kicinski: - Switch to RCU for stats synchronization and drop the BNGE_STATE_READ_STATS state bit. Fix checkpatch warning by switching to kzalloc_node(). v2: Addressed comments from Andrew Lunn: - Add implementation for .get_pauseparam and .set_pauseparam to support a full flow control configuration, covering global autoneg, independent pause autoneg, and forced RX/TX pause functionality. - Move MAC, PHY, Control, Pause, and RMON statistics from .get_ethtool_stats to their respective structured ethtool callbacks (e.g., .get_eth_mac_stats, .get_rmon_stats). Addressed comments from Jakub Kicinski: - Fix potential out-of-bounds read in speed mask array by adding the missing sentinel. - Simplify timer synchronization by removing the redundant intr_sem. - Replace link_lock with the netdev instance lock, as it is sufficient to handle the required synchronization. v1: https://lore.kernel.org/all/20260223163641.755200-1-bhargava.marreddy@broadcom.com/ Bhargava Marreddy (10): bng_en: add per-PF workqueue, timer, and slow-path task bng_en: query PHY capabilities and report link status bng_en: add ethtool link settings, get_link, and nway_reset bng_en: implement ethtool pauseparam operations bng_en: add support for link async events bng_en: add HW stats infra and structured ethtool ops bng_en: periodically fetch and accumulate hardware statistics bng_en: implement ndo_get_stats64 bng_en: implement netdev_stat_ops bng_en: add support for ethtool -S stats display drivers/net/ethernet/broadcom/bnge/Makefile | 3 +- drivers/net/ethernet/broadcom/bnge/bnge.h | 12 + .../net/ethernet/broadcom/bnge/bnge_core.c | 1 + .../net/ethernet/broadcom/bnge/bnge_ethtool.c | 723 +++++++++ .../ethernet/broadcom/bnge/bnge_hwrm_lib.c | 386 ++++- .../ethernet/broadcom/bnge/bnge_hwrm_lib.h | 8 + .../net/ethernet/broadcom/bnge/bnge_link.c | 1303 +++++++++++++++++ .../net/ethernet/broadcom/bnge/bnge_link.h | 204 +++ .../net/ethernet/broadcom/bnge/bnge_netdev.c | 597 +++++++- .../net/ethernet/broadcom/bnge/bnge_netdev.h | 87 +- .../net/ethernet/broadcom/bnge/bnge_txrx.c | 35 +- 11 files changed, 3340 insertions(+), 19 deletions(-) create mode 100644 drivers/net/ethernet/broadcom/bnge/bnge_link.c create mode 100644 drivers/net/ethernet/broadcom/bnge/bnge_link.h -- 2.47.1