From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E4A77279DB3 for ; Sun, 15 Mar 2026 23:20:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773616805; cv=none; b=iJu5SVbOyypzVEfE6A+XCr+NKWZQ3TJZtgGiKGZXey2bIkdk8rAlaPhgdcw1y3WLgWus4pd5M6V9cxZwwcorHyG7tib2Repupf9swN0IuIMD4ML1XhRWkYfPnE/BXht0lXiruwOMF34ls1ssyt2xarV6dGDdVt7ldViDOZRrnG0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773616805; c=relaxed/simple; bh=Sprnt5ZDjRPUa1ww1QcN1glz1ZQiWBmFB3RPxEPrdgs=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=Ef0DMbGB+u3/AhOFL2hj7IVOLjLaKsXR0NFyfR1m70/ryyNTrP2KrfhEIx2loAUGOSLpFWElVoUlWpN3sua295UH8MBpmEQSLc931+w5DshJG7BCb9GYWVxHP3Uui3+N9T72vFY8Gw6cQ4qY+D4sH+q5+4YDnYSCwwpF8JZKWyM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ZuIAWCJA; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZuIAWCJA" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-48374014a77so38504415e9.3 for ; Sun, 15 Mar 2026 16:20:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773616802; x=1774221602; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=Df2cbTHSLjGNi97ps33ixIYcO5hgiRbvTnx5Ikk0MHE=; b=ZuIAWCJA21ujhHGqXpETLMQsEbH7BViulNVK1H/Ew5MV3oXa6Bk9VS9sLf3nS84/7v LLG3rHWD1rlhF7ZPRfaoZ81Y9x0eBMm+v7B5E/lPcw74QJWPtLHcpzlRWGu/mTngFrJi vjTN56K7zvnnwmRQwnbtnp5WhEe9tXc4EpUzXEm0Awih5VYshmWQt+yO8t78KfEq4ut2 bIf3g7FS0dGee+vGMQP66s9webnFiJiuYhar2/N72amD6Tjg/duUaMFWkwIwZMk2TSa5 FrdmcxOKbZcNR0r3JvkikMiWylqouRnkgYfdW1dznBjZO4lZA40BVaBVD5XNITqKQhwk yj/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773616802; x=1774221602; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Df2cbTHSLjGNi97ps33ixIYcO5hgiRbvTnx5Ikk0MHE=; b=g2YNrrkPYqjxB3d9U95QUvgwprz4DQnUaSFib0wX8wa1sl0oWH9MfOVJdAPl/538Kv NTMM+Jhqm9ki1GA4vnRiOXE+uTuOHSDDpZidzpr3SDt6jb8B9rZ3kTS9YPDV30yqZkTs BFNRjR9sU1+EL8hxio+vuLVmLv2PkDMLPfkYWS8FKjLQeKPPtwUCp96y3D2DcZjc+O/9 7RhliBU/8H0i+cz1V8hpv40zaIYLkUPubCkcRKyHXh5Vy1Kc2SRovgLfx4qzSIvV8oaI GhSitcEY2OpAMHG5yfZfM6mt8JB+kO8bhD9EbqUNsnaMa1t8RbvqLytf+k9RXTKah7e4 jQZA== X-Forwarded-Encrypted: i=1; AJvYcCU2SZS0S0WQU2FgYq0NxPQ1LgCAeMgSwZLFJPVbO1+l8j2OWSM+0mnvnQ+B0gRMvsbHIz9K8BB3X7sD8V4=@vger.kernel.org X-Gm-Message-State: AOJu0YwU+p8rsaOBrVdpppElir4aTggMYekmmXuvUIOiw5usfknHxzrY Sfz4qbJFNqXskIKeu52QXQ1dfF16Tkw/g1V4xJmHN+StUhVY3NtUszkk X-Gm-Gg: ATEYQzyM9JxdCGLNEkj3azrUtRDHfnX+nfVNYhoqfM5dCiWgl2Lt2C0mmjg8TsrrEev pQqvtcSXsCGQhN70rAxokKcS+10SFeU+7/mgUq64vVsXI6pQoMe5swKHkJo8PUPzSTLQ0kUz3qJ jC7aiDjDoTtYb8w1bGx4TOm0X1zF3qtFAaS6qneOJsYpNTqQIEBMcdTk1sIk+B2x6HrFsJbVGd2 kIZSTjsSfFHbioLNKAQu/43eG/qzcuklvOn/nzWGevb+tGIQMXecBg4Dg3GGVfVVgjf1WtKlASC +XNWXwe4UGecpT+1YZ+mgs3ap/w+oReTfDmDLeU9KqHt3RuPdoF2etNxicg52UUeOabmrsyOaTs 7Wo+wBWmCM6mWP5AU/0TTQsYdS3ZEuymN6ISN6i1JIG+mxw9wYBkzNJlOd3ebK42Qd0c3CsUu19 QnDo02FhY4CEita6nWS8CCuHuCXYtl2hBT0cHhu6Q2gwshxcsUKZrtPmyRb0+8MrE= X-Received: by 2002:a05:600c:8488:b0:480:1d0b:2d32 with SMTP id 5b1f17b1804b1-485566d6fd7mr153183055e9.12.1773616802090; Sun, 15 Mar 2026 16:20:02 -0700 (PDT) Received: from OaroraEtimis.tail60902c.ts.net ([95.179.249.152]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-439fe22529csm37662624f8f.31.2026.03.15.16.19.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 15 Mar 2026 16:20:00 -0700 (PDT) From: Oarora Etimis X-Google-Original-From: Oarora Etimis To: vireshk@kernel.org, johan@kernel.org, elder@kernel.org, gregkh@linuxfoundation.org Cc: greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Oarora Etimis Subject: [PATCH v2 2/2] staging: greybus: bootrom: fix potential null pointer dereference Date: Mon, 16 Mar 2026 07:19:49 +0800 Message-ID: <20260315231949.231320-1-OaroraEtimis@gmail.com> X-Mailer: git-send-email 2.47.3 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit In gb_bootrom_get_firmware(), the 'fw' pointer could be NULL if the function jumps to the 'unlock' label. The execution flow continues into the 'queue_work' block where 'fw->size' is accessed, leading to a null pointer dereference. Fix this by adding a NULL check for 'fw' before accessing its members. Signed-off-by: Oarora Etimis --- Changes in v2: - Rebased onto the latest staging-next branch to resolve merge conflicts. - No logical code changes. drivers/staging/greybus/bootrom.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/greybus/bootrom.c b/drivers/staging/greybus/bootrom.c index 83921d90c322..50c80475d241 100644 --- a/drivers/staging/greybus/bootrom.c +++ b/drivers/staging/greybus/bootrom.c @@ -298,7 +298,7 @@ static int gb_bootrom_get_firmware(struct gb_operation *op) queue_work: /* Refresh timeout */ - if (!ret && (offset + size == fw->size)) + if (!ret && fw && (offset + size == fw->size)) next_request = NEXT_REQ_READY_TO_BOOT; else next_request = NEXT_REQ_GET_FIRMWARE; -- 2.47.3