From: Xiaolei Wang <xiaolei.wang@windriver.com>
To: sakari.ailus@linux.intel.com, laurent.pinchart@ideasonboard.com,
tarang.raval@siliconsignals.io, jacopo@jmondi.org,
mchehab@kernel.org, prabhakar.mahadev-lad.rj@bp.renesas.com,
hverkuil+cisco@kernel.org, johannes.goede@oss.qualcomm.com,
hverkuil-cisco@xs4all.nl, jai.luthra@ideasonboard.com,
dave.stevenson@raspberrypi.com, Xiaolei.Wang@windriver.com
Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] media: i2c: ov9282: Add test pattern control
Date: Mon, 16 Mar 2026 17:05:58 +0800 [thread overview]
Message-ID: <20260316090558.1537823-1-xiaolei.wang@windriver.com> (raw)
This adds V4L2_CID_TEST_PATTERN control support.
Signed-off-by: Xiaolei Wang <xiaolei.wang@windriver.com>
---
drivers/media/i2c/ov9282.c | 47 +++++++++++++++++++++++++++++++++++++-
1 file changed, 46 insertions(+), 1 deletion(-)
diff --git a/drivers/media/i2c/ov9282.c b/drivers/media/i2c/ov9282.c
index 2167fb73ea41..f64b2084b8e7 100644
--- a/drivers/media/i2c/ov9282.c
+++ b/drivers/media/i2c/ov9282.c
@@ -104,6 +104,12 @@
#define OV9282_REG_STROBE_FRAME_SPAN CCI_REG32(0x3925)
#define OV9282_STROBE_FRAME_SPAN_DEFAULT 0x0000001a
+/* Test Pattern registers */
+#define OV9282_REG_TEST_PATTERN_BAR CCI_REG8(0x5e00)
+#define OV9282_TEST_PATTERN_BAR_EN BIT(7)
+#define OV9282_REG_TEST_PATTERN_SOLID CCI_REG8(0x4320)
+#define OV9282_TEST_PATTERN_SOLID_EN BIT(1)
+
/* Input clock rate */
#define OV9282_INCLK_RATE 24000000
@@ -462,6 +468,18 @@ static const struct ov9282_mode supported_modes[] = {
},
};
+enum {
+ OV9282_TEST_PATTERN_DISABLED,
+ OV9282_TEST_PATTERN_COLOR_BAR,
+ OV9282_TEST_PATTERN_SOLID_COLOR,
+};
+
+static const char * const ov9282_test_pattern_menu[] = {
+ "Disabled",
+ "Color Bar",
+ "Solid Color",
+};
+
/**
* to_ov9282() - ov9282 V4L2 sub-device to ov9282 device.
* @subdev: pointer to ov9282 V4L2 sub-device
@@ -586,6 +604,23 @@ static u32 ov9282_flash_duration_to_us(struct ov9282 *ov9282, u32 value)
return DIV_ROUND_UP(value * frame_width, OV9282_STROBE_SPAN_FACTOR);
}
+static int ov9282_set_ctrl_test_pattern(struct ov9282 *ov9282, int pattern)
+{
+ int ret;
+
+ ret = cci_update_bits(ov9282->regmap, OV9282_REG_TEST_PATTERN_BAR,
+ OV9282_TEST_PATTERN_BAR_EN,
+ pattern == OV9282_TEST_PATTERN_COLOR_BAR ?
+ OV9282_TEST_PATTERN_BAR_EN : 0, NULL);
+ if (ret)
+ return ret;
+
+ return cci_update_bits(ov9282->regmap, OV9282_REG_TEST_PATTERN_SOLID,
+ OV9282_TEST_PATTERN_SOLID_EN,
+ pattern == OV9282_TEST_PATTERN_SOLID_COLOR ?
+ OV9282_TEST_PATTERN_SOLID_EN : 0, NULL);
+}
+
/**
* ov9282_set_ctrl() - Set subdevice control
* @ctrl: pointer to v4l2_ctrl structure
@@ -662,6 +697,11 @@ static int ov9282_set_ctrl(struct v4l2_ctrl *ctrl)
case V4L2_CID_FLASH_DURATION:
ret = cci_write(ov9282->regmap, OV9282_REG_STROBE_FRAME_SPAN, ctrl->val, NULL);
break;
+
+ case V4L2_CID_TEST_PATTERN:
+ ret = ov9282_set_ctrl_test_pattern(ov9282, ctrl->val);
+ break;
+
default:
dev_err(ov9282->dev, "Invalid control %d", ctrl->id);
ret = -EINVAL;
@@ -1242,7 +1282,7 @@ static int ov9282_init_controls(struct ov9282 *ov9282)
u32 lpfr;
int ret;
- ret = v4l2_ctrl_handler_init(ctrl_hdlr, 12);
+ ret = v4l2_ctrl_handler_init(ctrl_hdlr, 13);
if (ret)
return ret;
@@ -1314,6 +1354,11 @@ static int ov9282_init_controls(struct ov9282 *ov9282)
V4L2_CID_FLASH_DURATION, 0, exposure_us, 1,
OV9282_STROBE_FRAME_SPAN_DEFAULT);
+ v4l2_ctrl_new_std_menu_items(ctrl_hdlr, &ov9282_ctrl_ops,
+ V4L2_CID_TEST_PATTERN,
+ ARRAY_SIZE(ov9282_test_pattern_menu) - 1,
+ 0, 0, ov9282_test_pattern_menu);
+
ret = v4l2_fwnode_device_parse(ov9282->dev, &props);
if (!ret) {
/* Failure sets ctrl_hdlr->error, which we check afterwards anyway */
--
2.43.0
next reply other threads:[~2026-03-16 9:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-16 9:05 Xiaolei Wang [this message]
2026-03-16 16:38 ` Dave Stevenson
2026-03-17 3:49 ` Xiaolei Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260316090558.1537823-1-xiaolei.wang@windriver.com \
--to=xiaolei.wang@windriver.com \
--cc=dave.stevenson@raspberrypi.com \
--cc=hverkuil+cisco@kernel.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=jacopo@jmondi.org \
--cc=jai.luthra@ideasonboard.com \
--cc=johannes.goede@oss.qualcomm.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=sakari.ailus@linux.intel.com \
--cc=tarang.raval@siliconsignals.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®