From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6FDEB39B4A2; Mon, 16 Mar 2026 14:02:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773669758; cv=none; b=sqr6OVSewKZC3aO1Z5d7lCkWIi0KGS7uwCag+T+UGq/744GBe9C8gbubA61a+jJFX40MzaqtxfooTdtMOO8zc2NFAMJA/K8SPld1Wm6RzlS5Og5tXYAyVoUqIjIIteACtcF4mkWZbrugruXry5vLBZrftOh91pPe8r8KTcICzJI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773669758; c=relaxed/simple; bh=rnC9ZWruT8P234OiKFoEBR1WUr45WgRnghL0ZijnQnM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=DUPvmfcUkfpN50iGNpcLn9QR3WMziLWSrnhfgsH8aZlfPozlifSzJhfSr8lAvFi6ebdBB0mSz8JHBG1bU06GPIMNmI8VRoMq+mOJXZpov4QM69WZ+5aU4uO/ujPVvjssOLyizVRQH5RyraB/CJlocJDKPBnvavFpppFR7LHvUxA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=fBATUmFe; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="fBATUmFe" Received: from killaraus.ideasonboard.com (2001-14ba-703d-e500--2a1.rev.dnainternet.fi [IPv6:2001:14ba:703d:e500::2a1]) by perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 8524622E; Mon, 16 Mar 2026 15:01:22 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1773669682; bh=rnC9ZWruT8P234OiKFoEBR1WUr45WgRnghL0ZijnQnM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fBATUmFeL0g6mBXRZZPIWVMRnJ9VL6l3LMjYQJtRsya6FJCcz8woLDRxgIUSw1JbM z6zfFHE5EYQMy2jNVjOOAnOZ3d0+YsyZAc/svT0zPMM/t2fIIMKcmfEE4aI3B0BEnF P6vgKw5xSxiXO+k2YxDIw+U0B3TuOm/6YNExs8cQ= Date: Mon, 16 Mar 2026 16:02:32 +0200 From: Laurent Pinchart To: Biju Cc: Andrzej Hajda , Neil Armstrong , Robert Foss , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Biju Das , Jonas Karlman , Jernej Skrabec , Dmitry Baryshkov , Tommaso Merciai , Andy Yan , Douglas Anderson , Luca Ceresoli , Jesse Van Gavere , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Geert Uytterhoeven , Prabhakar Mahadev Lad , linux-renesas-soc@vger.kernel.org Subject: Re: [PATCH] drm/bridge: adv7511: Clear HPD IRQ before powering on device during resume() Message-ID: <20260316140232.GB31616@killaraus.ideasonboard.com> References: <20251219104659.114032-1-biju.das.jz@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20251219104659.114032-1-biju.das.jz@bp.renesas.com> Hi Biju, Thank you for the patch. On Fri, Dec 19, 2025 at 10:46:53AM +0000, Biju wrote: > From: Biju Das > > On RZ/G3E SMARC EVK using PSCI, s2ram powers down the SoC. Testing ADV7535 > IRQ configured as edge-triggered interrupt on RZ/G3E SMARC EVK shows that > it is missing HPD IRQ during system resume, as the status change occurs > before the IRQ/pincontrol resume. Once the status bit is set, there won't > be any further IRQ unless the status bit is cleared. > > Clear any pending HPD IRQs before powering on the ADV7535 device to > deliver HPD interrupts after resume(). This issue doesn't seem to be specific to the ADV7511. Any device that uses an edge-triggered interrupt could suffer from the same problem. Implementing a work around in the driver doesn't seem to be a solution that would scale. > Signed-off-by: Biju Das > --- > drivers/gpu/drm/bridge/adv7511/adv7511.h | 1 + > drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 32 ++++++++++++++++++++ > 2 files changed, 33 insertions(+) > > diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511.h b/drivers/gpu/drm/bridge/adv7511/adv7511.h > index 8be7266fd4f4..03aa23836ca4 100644 > --- a/drivers/gpu/drm/bridge/adv7511/adv7511.h > +++ b/drivers/gpu/drm/bridge/adv7511/adv7511.h > @@ -393,6 +393,7 @@ struct adv7511 { > bool cec_enabled_adap; > struct clk *cec_clk; > u32 cec_clk_freq; > + bool suspended; > }; > > static inline struct adv7511 *bridge_to_adv7511(struct drm_bridge *bridge) > diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c > index b9be86541307..8d9467187d7c 100644 > --- a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c > +++ b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c > @@ -790,6 +790,25 @@ static void adv7511_bridge_atomic_enable(struct drm_bridge *bridge, > struct drm_connector_state *conn_state; > struct drm_crtc_state *crtc_state; > > + if (adv->i2c_main->irq && adv->suspended) { > + unsigned int irq; > + > + /* > + * If ADV7511 IRQ is configured as edge triggered interrupt, it > + * will miss the IRQ during system resume as the status change > + * occurs before IRQ/pincontrol resume. Once the status bit is That seems very platform-specific. > + * set there won't be any further IRQ unless the status bit is > + * cleared. So, clear the IRQ status bit for further delivery > + * of HPD IRQ. > + */ > + regmap_read(adv->regmap, ADV7511_REG_INT(0), &irq); > + if (irq & ADV7511_INT0_HPD) > + regmap_write(adv->regmap, ADV7511_REG_INT(0), > + ADV7511_INT0_HPD); Why do you need to read and test the IRQ here ? If ADV7511_INT0_HPD isn't set, a write will be a no-op and will keep it cleared. If it is set, it will clear it. It seems that an unconditional regmap_write(adv->regmap, ADV7511_REG_INT(0), ADV7511_INT0_HPD); should be enough. > + > + adv->suspended = false; > + } > + > adv7511_power_on(adv); > > connector = drm_atomic_get_new_connector_for_encoder(state, bridge->encoder); > @@ -1407,6 +1426,16 @@ static void adv7511_remove(struct i2c_client *i2c) > i2c_unregister_device(adv7511->i2c_edid); > } > > +static int adv7511_suspend(struct device *dev) > +{ > + struct i2c_client *i2c = to_i2c_client(dev); > + struct adv7511 *adv7511 = i2c_get_clientdata(i2c); > + > + adv7511->suspended = true; > + > + return 0; > +} > + > static const struct adv7511_chip_info adv7511_chip_info = { > .type = ADV7511, > .name = "ADV7511", > @@ -1439,6 +1468,8 @@ static const struct adv7511_chip_info adv7535_chip_info = { > .hpd_override_enable = true, > }; > > +static DEFINE_SIMPLE_DEV_PM_OPS(adv7511_pm_ops, adv7511_suspend, NULL); > + > static const struct i2c_device_id adv7511_i2c_ids[] = { > { "adv7511", (kernel_ulong_t)&adv7511_chip_info }, > { "adv7511w", (kernel_ulong_t)&adv7511_chip_info }, > @@ -1467,6 +1498,7 @@ static struct i2c_driver adv7511_driver = { > .driver = { > .name = "adv7511", > .of_match_table = adv7511_of_ids, > + .pm = pm_sleep_ptr(&adv7511_pm_ops), > }, > .id_table = adv7511_i2c_ids, > .probe = adv7511_probe, -- Regards, Laurent Pinchart