From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f169.google.com (mail-pg1-f169.google.com [209.85.215.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F3C643A3E62 for ; Mon, 16 Mar 2026 15:34:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773675257; cv=none; b=I9z2mEILcmWimyKuxtTCZy4btGUKfIEwlGuNh2YgY+KM5mMzJeW+gyfVVMZjFDn0rav9MzMmLJtOYIE+WUOEA0F7VhGwvYd8EjEIysh45whEl94N9YSjm6OVDKT+Z9dU5NpnOxtkzmAkp4wFjrloSLxZqkpip3ldM10DlT4Wimw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773675257; c=relaxed/simple; bh=y/ZLibchuQj7YlYLpkVr+2Z0sBYMwEjJK8GbheI4gus=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=rWoqoBBQKI4R30NlNJzrTVjHuPYY2ALkfNu8jnrVYEQXtjGVxgLIAMfOc2iTKwG274Qn4pJHpo6uFF1VZ9vyWf/NGaGNnq8In4I3vqRhdzcNr7pkoU9ENZPwnvTtGq8p2gQULs13tnsIqFXbiARlHAUAc+IKGpsWszk+yzlKQL8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=NE1l/chP; arc=none smtp.client-ip=209.85.215.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="NE1l/chP" Received: by mail-pg1-f169.google.com with SMTP id 41be03b00d2f7-c7393c6832bso1608832a12.2 for ; Mon, 16 Mar 2026 08:34:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773675255; x=1774280055; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=31hFqWE+7CsGeugLW57EQWcnO71gJWH1yfQQssYWeNc=; b=NE1l/chPmhzwOJQgiGj91utWJOlMAk5TcyxjNy8ZPysExemvpKgWgelSrAF/Gi14Mh vn48JDCFPWGKM/rxTboQDQHOmQUvNbdxUOQtRK0Nn4uINcosJ1ifvl5DvhRQiR6UAtfv upI/A8GAFthL+Cv/JuCDFUH6Kn6SbyiKdoK1wfLo84HpomMc7YXxtmTYc3IyE/+P6uth bZO3rmNfBfls0YGsBPDTDKZscprb8P1tCu/1EQNSe6LZP6a+HNL//5fjhhTJvqfPm1wG 7WF6W9GT/vUzafNZO5FHo7AwDF+6KoQWLZaLUJ8S9duk4dUhGHrVB0vtimVxvpXOC5en hbSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773675255; x=1774280055; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=31hFqWE+7CsGeugLW57EQWcnO71gJWH1yfQQssYWeNc=; b=TO465Ra9I0anUeoimLDXTXECJctMc/NMYFeXWn+1NIaIpHQcV+o8XiL9vNhF2KQ4x2 8ieWiIG6BxiY2v7oBRUu/xsh76eshSVArWUSTuyH3xfEgTrj5JEpkxMU8Z5aR1EDOqpf NdNk6Dg7JsKjVJL+s2d7QYLgUzENqr6tbpmcAg/IVIYTkLw86gBrL5VJNqiqO/cXyn4w nwxLenh3Z9ENu0ktBXElCvvqvSL4TY0Z1PcTV7ghm+0/a9Z5aZNjHfIVtfqImc1i86FA BR/U1VB3Lw+sR0dbWkUFivau9V5gquk+I1W39PfZbU6TRPfcJbpfAFX3h5BjuMIBWy33 Kklg== X-Forwarded-Encrypted: i=1; AJvYcCXVVPSdAI2G4Pxmbz3qvDu4ooJ6S5WK2qMJBMTVKlXJaJvNfiwkNDYBd75muZ0ETxLrjfRYd/XT/zESWdE=@vger.kernel.org X-Gm-Message-State: AOJu0YylJrUfDBCvoBL/RZTJYtnvDEBl2RCUCGTMNzegUxWBodsMv8Bf SW+8eu8r3qA4I8S1gsH0gdKVbvt+xihFYTJC8w87tJGFuTluDQmpNUg= X-Gm-Gg: ATEYQzxn0T4FAi86mz1M4tZStD6QfVfAEqvKesrB5CYGjvIreow9CXxfrezO/C46kzM nbMStKFu+Tk2OlgAMJ+svyrbbdg26Ru5MY08CEzlE26+rONVvttu0jbQTye5Su9mWShDJ3FYmCu 9pzZXgaIZDucHZyiq7q//DMbQOQuoun1QZzeI35DhXWjweVsy2KTW0olwtJA0I9YN+9ta7HMyzl NtC/W3u9JlWoSuWhMcodMYFlvpYUka3zXlOyH3JVlssHUr5pXOu3gV/wyPX4bsVB1pj7T76WpUA TIeefXj/0M8oj7uQ6jr8DHq10K7QafwgeRAueF782Ge6p7TMK8TssgW7B0B+ZOB+/cc8bmQHbYx OF7+7spE2wD5Iyr13Bas3IyO4+jH3sDJL1gPpDLuLXaVuLEjvPdYyNtQ53bC7hasVZ1gN3xXY/x +M/GmEdFcqjpwQ+th6TlO6oj3ewVmeP+LL1tyiyOLxy4movR4+0R7xRxHrdD2SqpA= X-Received: by 2002:a17:90b:2ccb:b0:35b:947d:9fca with SMTP id 98e67ed59e1d1-35b947da15amr4932335a91.19.1773675255126; Mon, 16 Mar 2026 08:34:15 -0700 (PDT) Received: from at-Standard-PC-Q35-ICH9-2009.. ([171.61.163.197]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35badb906c6sm2685a91.9.2026.03.16.08.34.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Mar 2026 08:34:14 -0700 (PDT) From: Atharva Tiwari To: Cc: Atharva Tiwari , Ard Biesheuvel , Hans de Goede , =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= , linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org, platform-driver-x86@vger.kernel.org Subject: [PATCH v4 0/2] Save Brightness on Macs Date: Mon, 16 Mar 2026 21:03:45 +0530 Message-ID: <20260316153407.1781-1-atharvatiwarilinuxdev@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Currently, when a Mac is rebooted, the display brightness does not reflect the level used during the previous boot. Instead, the brightness is reset to the value last stored by macOS, causing the system to ignore any changes made since that time. We fix this by writing the brightness value to efivar 'backlight-level' at shutdown only, when it is changed since the last boot. Changes in v4: - Fixed build error, when apple-gmux is compiled without apple-brightness. - Fix grammatical errors. Changes in v3: - Fixed a bug, in which apple_brightness_shutdown is still called on non-supported devices. Changes in v2: - Saved the brightness only when it is different than the previous boot. Link to v3: https://lore.kernel.org/all/20260315222020.24341-1-atharvatiwarilinuxdev@gmail.com/ Link to v2: https://lore.kernel.org/all/20260315215302.24087-1-atharvatiwarilinuxdev@gmail.com/ Link to v1: https://lore.kernel.org/all/20260206125641.12983-1-atharvatiwarilinuxdev@gmail.com/ Atharva Tiwari (2): efi: Save Brightness using EFI on Macs platform/apple-gmux: use apple_brightness to save brightness to EFI drivers/firmware/efi/Kconfig | 10 +++ drivers/firmware/efi/Makefile | 1 + drivers/firmware/efi/apple-brightness.c | 67 +++++++++++++++++++ drivers/platform/x86/apple-gmux.c | 21 ++++++ .../linux/platform_data/apple-brightness.h | 20 ++++++ 5 files changed, 119 insertions(+) create mode 100644 drivers/firmware/efi/apple-brightness.c create mode 100644 include/linux/platform_data/apple-brightness.h -- 2.43.0