On Mon, Mar 16, 2026 at 06:10:23PM +0100, Krzysztof Kozlowski wrote: > On 16/03/2026 12:13, Conor Dooley wrote: > > On Mon, Mar 16, 2026 at 10:46:06AM +0700, phucduc.bui@gmail.com wrote: > >> From: bui duc phuc > >> > >> Document the "wakeup-source" property for the ti,tsc2005 touchscreen > >> controllers to allow the device to wake the system from suspend. > >> > >> Signed-off-by: bui duc phuc > >> --- > >> .../devicetree/bindings/input/touchscreen/ti,tsc2005.yaml | 7 +++++++ > >> 1 file changed, 7 insertions(+) > >> > >> diff --git a/Documentation/devicetree/bindings/input/touchscreen/ti,tsc2005.yaml b/Documentation/devicetree/bindings/input/touchscreen/ti,tsc2005.yaml > >> index 7187c390b2f5..c0aae044d7d4 100644 > >> --- a/Documentation/devicetree/bindings/input/touchscreen/ti,tsc2005.yaml > >> +++ b/Documentation/devicetree/bindings/input/touchscreen/ti,tsc2005.yaml > >> @@ -55,6 +55,9 @@ properties: > >> touchscreen-size-x: true > >> touchscreen-size-y: true > >> > >> + wakeup-source: > >> + type: boolean > > > > wakeup-source: true > > I am not so sure. > > The property is multi-type, so we want to choose one - bool, IMO, > because device cannot wakeup the specific system idle states. Or am I > misinterpreting the phandles behind wakeup-source and every device can > be differently routed in such system? I checked before my original comment, and there there's a bout a 2:1 ratio of defined v true. I suppose my comment can be ignored, I am just used to this always being true.