From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8AB4129A32D; Tue, 17 Mar 2026 07:33:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773732785; cv=none; b=n66yQngxMy9Ovjhyhp4byGTVniNZCN9XjLAFIpXrL3e5xshxhoNh9vUvybi1WxgCDNefiAaXx6DP8KU9neSdnzzF6vZNW3E1l83I5WlwhShOPFwjxZoBi5x3LZ2i1GbzwNwirUVs/RnJ+MlKW2HOVX/DIi6LlckjJCckrIA2S6s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773732785; c=relaxed/simple; bh=IFqjMBE1/ZQMZCgU1rzj3A/SIfAKjPz7mxOs6XM0BFg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=QwSDcyxMp4cyNe9lhiAQGbR5u42JUuTl9KLQRKhzo7AzwoaLhTaq3/fodFdgzP3OZsXJrhpOaWo7o8RILt4ctZw7IAg05NmPYZMhsDr+1t1ASZGo+QqC6llIX5JY117WZiprqKJy+Y7/TxKUSyxpVpGXqKBVu7TXKMLe2RJ/PLI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=CA8CgmxO; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="CA8CgmxO" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8CEB8C4CEF7; Tue, 17 Mar 2026 07:33:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1773732785; bh=IFqjMBE1/ZQMZCgU1rzj3A/SIfAKjPz7mxOs6XM0BFg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=CA8CgmxOrqFgkTQwayqb0nuuNjWAwzUKKxov6JFm4QtcRbPCwhaj7FgM0RLggFo0/ assnYE0Hbq8Vq6ZumES14AHqvXSUSO2mVREm3t+0jN/jOSCComIc2iEzmyvg/W1YpC +ISDEjkiwY/Pi8/dgPdYEtPWyexF6Rscd7BR4MZiTg9QdgvSOLQmSwShtA82ZBr3Q7 tc2OcdwI6dVXoq0rrAy84ofbC096LkTsGMhCwia/URX/AgMrrwIKW5d8iWWqFF/PjN zs8CoMjYzrSl+nCy7NN9uvguL51IJ4liNlUZOQuQIRzdzXCB7ZT/sJPdwfFPMG83tb kMwceiNcANLgA== Date: Tue, 17 Mar 2026 08:33:02 +0100 From: Krzysztof Kozlowski To: Aaron Kling Cc: Neil Armstrong , Jessica Zhang , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Teguh Sobirin Subject: Re: [PATCH v2 1/2] dt-bindings: display: panel: Add ChipWealth CH13726A AMOLED driver bindings Message-ID: <20260317-helpful-proficient-pronghorn-ef5e1f@quoll> References: <20260317-ch13726a-v2-0-28aa46bcd6d0@gmail.com> <20260317-ch13726a-v2-1-28aa46bcd6d0@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20260317-ch13726a-v2-1-28aa46bcd6d0@gmail.com> On Tue, Mar 17, 2026 at 12:23:07AM -0500, Aaron Kling wrote: > The Chip Wealth Technology CH13726A display driver is a single chip > solution for AMOLED using MIPI-DSI. This is used for the AYN Thor bottom > panel. A nit, subject: drop second/last, redundant "bindings". The "dt-bindings" prefix is already stating that these are bindings. See also: https://elixir.bootlin.com/linux/v6.17-rc3/source/Documentation/devicetree/bindings/submitting-patches.rst#L18 Also drop all references to "display driver", even if you meant hardware thing. Driver in hardware is suitable only to motors, haptics and LEDs, but not to displays. AMOLED driver is fine, display driver too confusing. > > Signed-off-by: Aaron Kling > --- > .../display/panel/chipwealth,ch13726a.yaml | 66 ++++++++++++++++++++++ > 1 file changed, 66 insertions(+) > > diff --git a/Documentation/devicetree/bindings/display/panel/chipwealth,ch13726a.yaml b/Documentation/devicetree/bindings/display/panel/chipwealth,ch13726a.yaml > new file mode 100644 > index 0000000000000000000000000000000000000000..b490c6757bb98c0752ded78b8fea3aaec853c7b2 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/panel/chipwealth,ch13726a.yaml > @@ -0,0 +1,66 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/panel/chipwealth,ch13726a.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Chip Wealth Technology CH13726A display driver > + > +maintainers: > + - Neil Armstrong > + > +description: > + Chip Wealth Technology CH13726A is a single-chip solution > + for AMOLED connected using a MIPI-DSI video interface. > + > +allOf: > + - $ref: panel-common.yaml# > + > +properties: > + compatible: > + const: ayntec,thor-panel-bottom Why compatible is completely different than commit msg, description and title are saying? > + > + port: true This goes before reset-gpios > + reg: > + maxItems: 1 > + description: DSI virtual channel > + > + vdd-supply: true > + vddio-supply: true > + vdd1v2-supply: true > + avdd-supply: true > + > + reset-gpios: true > + Drop blank line here (it is port+reset-gpios+rotation in three lines). > + rotation: true > + Best regards, Krzysztof