From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.hugovil.com (mail.hugovil.com [162.243.120.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 33E633EAC8C; Tue, 17 Mar 2026 15:05:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=162.243.120.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773759911; cv=none; b=VxMlXId0uzlQLqDoqrXDB7jIC/7+Wz6N++7vyfKF7BB5pLuI3a73ffZt4z2trKyNmiNVazkJE4tKYkXdOf5EdP9YFTo99W91TmVd8ndWB/jB2x6Ba5Rkw5otBCsh0hTw952ETXYt0x40BPcnh5kjqisNZ4La5Ig39edEmMWYCy0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773759911; c=relaxed/simple; bh=6uAm27Ql5xQeTLaGM87R8Ws4yEgQXp9j5VjfQBBlIeQ=; h=Date:From:To:Cc:Subject:Message-Id:In-Reply-To:References: Mime-Version:Content-Type; b=bcBXtveXUOmJSeWas5dmLRZ6FS/CEWRnTNavlWT1TAEomoQXEKu4eaLa8L1nr6YIWPzpjwGmvKh0ANSer51BviN579S5/ZqvRdvbR/KmO1FCqF/VwxIr6lsu+vfvsfod8AQQ8cJ6GWjAkwzUJFZyJmrJZrsG9NbBoIWUuCWlWwA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=hugovil.com; spf=pass smtp.mailfrom=hugovil.com; dkim=pass (1024-bit key) header.d=hugovil.com header.i=@hugovil.com header.b=FSLPBW3U; arc=none smtp.client-ip=162.243.120.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=hugovil.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=hugovil.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=hugovil.com header.i=@hugovil.com header.b="FSLPBW3U" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=hugovil.com ; s=default; h=Content-Transfer-Encoding:Mime-Version:Message-Id:Subject:Cc: To:From:Date:subject:date:message-id:reply-to; bh=koyUHICUcLifjkIlRusqBeAiTAEOVXVIw8qXKtQGB+o=; b=FSLPBW3U1WbAetHnlPjPQ0tMuc uh2rP0SzSey0mDYpFwmjTfEoEADtqyDjK+CVv1EybBQMCgsdOEViUJuMARKE6gC0RXWCvHvJ9o3lU TgXIgpbZnjm/cdXq5270EEE85JSK7AyCy/OI6zQEjojvKqnSHtpZpKEydapfVsxa9ziU=; Received: from modemcable061.19-161-184.mc.videotron.ca ([184.161.19.61] helo=debian-lenovo) by mail.hugovil.com with esmtpa (Exim 4.98.2) (envelope-from ) id 1w2VhY-000000001jf-0EqC; Tue, 17 Mar 2026 10:47:20 -0400 Date: Tue, 17 Mar 2026 10:47:19 -0400 From: Hugo Villeneuve To: Biju Cc: Biju Das , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , dri-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Geert Uytterhoeven , Chris Brandt , Prabhakar Mahadev Lad Subject: Re: [PATCH 1/2] drm: renesas: rzg2l_mipi_dsi: Use fsleep() for 1ms delay in D-PHY init Message-Id: <20260317104719.e251fb0feb2e99b7569c2dc4@hugovil.com> In-Reply-To: <20260317123610.329630-2-biju.das.jz@bp.renesas.com> References: <20260317123610.329630-1-biju.das.jz@bp.renesas.com> <20260317123610.329630-2-biju.das.jz@bp.renesas.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam_score: -2.0 X-Spam_bar: -- Hi Biju, On Tue, 17 Mar 2026 12:36:00 +0000 Biju wrote: > From: Biju Das The commit message seems confusing to me, indicating that you only changed fsleep, but did not change the delay? Maybe change it to indicate that you increase the delay from 1us to 1ms, which is the real reason of the change (why). > > Replace udelay(1) with fsleep(1000) in rzg2l_mipi_dsi_dphy_init() to Same here, the real reason of the change is to increase the delay, and this is not obviously stated. > follow the power-on sequence described in Figure 34.5 of section > "34.4.2.1 Reset" of the RZ/G2L hardware manual Rev.1.50 May 2025. > > Signed-off-by: Biju Das > --- > drivers/gpu/drm/renesas/rz-du/rzg2l_mipi_dsi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/renesas/rz-du/rzg2l_mipi_dsi.c b/drivers/gpu/drm/renesas/rz-du/rzg2l_mipi_dsi.c > index a87a301326c7..e53b48e4de56 100644 > --- a/drivers/gpu/drm/renesas/rz-du/rzg2l_mipi_dsi.c > +++ b/drivers/gpu/drm/renesas/rz-du/rzg2l_mipi_dsi.c > @@ -528,7 +528,7 @@ static int rzg2l_mipi_dsi_dphy_init(struct rzg2l_mipi_dsi *dsi, > if (ret < 0) > return ret; > > - udelay(1); > + fsleep(1000); > > return 0; > } > -- > 2.43.0 > > -- Hugo Villeneuve