From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 295B33254BD for ; Tue, 17 Mar 2026 19:45:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773776730; cv=none; b=DwuLYvFiCIll4F/rGvlLtGaxKR+xmHgkCmK99dukt2dsKYRFR0oml3ZRS/5oHHnDE6XKdWBmUsVBUmYsLGCqWgq6yBcwOhIqYT/xnQXxrWy3fPVvXEJ1O+vhuQr4eBN11w5zV9MMpxxNOMWzxE6iaNB2lT4EldTfWJ0j2QPvQLg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773776730; c=relaxed/simple; bh=v6YL1YyMV662ZbfchqvmlhuiuJL0pVwqFzh6HccbzKI=; h=Date:From:To:Cc:Subject:Message-Id:In-Reply-To:References: Mime-Version:Content-Type; b=fYxDdtdP1l6Sl+yFa/uKXM1Wh+GliWy1jJwJYFNlqvZvMGOD5kgCR5nKH7FyaNggdTc6ztaGFEMcBHc21EPOL3s2gWmUWdpV1AX4/cQo/jgiOGoBo25e5F1s0KBnPc2lZqw9QWJZiLHrnscZeDRYm/FbTZqVUvvvpNKXnn/EDVM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b=yYQ7HO0g; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="yYQ7HO0g" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 676B1C4CEF7; Tue, 17 Mar 2026 19:45:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1773776729; bh=v6YL1YyMV662ZbfchqvmlhuiuJL0pVwqFzh6HccbzKI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=yYQ7HO0gn0KuSl2BgQ2sVKWaYpPEDkQaCA3L73jq12yD4nNzESfQ0hYE7FtewMhVM jiNBPTWZfLqg/jCXILiKDgmltxTjTUSn2rkCk9OlsMwBxxjUMTg+/KzqY1z5Goj7iu 2zyTzW0YYt3kE6hZQoAbyReSPH1cMWyzcYU5ZQCc= Date: Tue, 17 Mar 2026 12:45:28 -0700 From: Andrew Morton To: "Kanchana P. Sridhar" Cc: hannes@cmpxchg.org, yosry@kernel.org, nphamcs@gmail.com, chengming.zhou@linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, herbert@gondor.apana.org.au, senozhatsky@chromium.org Subject: Re: [PATCH v2 0/2] zswap pool per-CPU acomp_ctx simplifications Message-Id: <20260317124528.961ebeaac03f69e65cb767e8@linux-foundation.org> In-Reply-To: <20260317014802.27591-1-kanchanapsridhar2026@gmail.com> References: <20260317014802.27591-1-kanchanapsridhar2026@gmail.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Mon, 16 Mar 2026 18:48:00 -0700 "Kanchana P. Sridhar" wrote: > This patchset first removes redundant checks on the acomp_ctx and its > "req" member in zswap_cpu_comp_dead(). > > Next, it persists the zswap pool's per-CPU acomp_ctx resources to > last until the pool is destroyed. It then simplifies the per-CPU > acomp_ctx mutex locking in zswap_compress()/zswap_decompress(). > > Code comments added after allocation and before checking to deallocate > the per-CPU acomp_ctx's members, based on expected crypto API return > values and zswap changes this patchset makes. > > Patch 2 is an independent submission of patch 23 from [1], to > facilitate merging. Thanks. What happened with "mm: zswap: Consistently use IS_ERR_OR_NULL() to check acomp_ctx resources"? Still relevant? https://lkml.kernel.org/r/20260314051632.17931-3-kanchanapsridhar2026@gmail.com