From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A3846346AE8 for ; Tue, 17 Mar 2026 21:09:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=216.40.44.11 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773781763; cv=none; b=hi0ofg2E3Rx7do8C7qzeS1c6qYIJK8p6MPvWS0TiscsQO4E3Zy/brLq35/YppT7DpKfHswwzUpt7nNP/HCATnoika2guD5PwLA/p0LtHs66qTryhtzxr1eI0dTjWD4/knbKX0ZpkY1WnEpuAIbgXbGvulo9tKbKLEPCdTxJfbrg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773781763; c=relaxed/simple; bh=jNQh1KQrOQtg+4LA9O3zOv8GCilW9sdS54w/UPPgGE0=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Ak96bWXpYg2h4D/wRvMK5v7IYxzjcGaCRhUdeDRdzekSR8LmmRfLnh1BBjJeKEuQpAQN+GLqNnueBa1MOYzozr7xfzTtwVxhK3aksW1BqFHRMsnNW49DbWb0HGzXO+tA7SXp/uAvjq4HZKE6AYKs09PB+cy+7AZHoEuPMtTbWeg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=goodmis.org; spf=pass smtp.mailfrom=goodmis.org; arc=none smtp.client-ip=216.40.44.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=goodmis.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=goodmis.org Received: from omf18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id DF329B8F03; Tue, 17 Mar 2026 21:09:19 +0000 (UTC) Received: from [HIDDEN] (Authenticated sender: rostedt@goodmis.org) by omf18.hostedemail.com (Postfix) with ESMTPA id A3E062E; Tue, 17 Mar 2026 21:09:17 +0000 (UTC) Date: Tue, 17 Mar 2026 17:09:43 -0400 From: Steven Rostedt To: Joseph Salisbury Cc: Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Ben Segall , Mel Gorman , Valentin Schneider , linux-kernel@vger.kernel.org Subject: Re: [PATCH] sched/core: initialize resched_latency in sched_tick() Message-ID: <20260317170943.44c41263@gandalf.local.home> In-Reply-To: <20260317195807.98850-1-joseph.salisbury@oracle.com> References: <20260317195807.98850-1-joseph.salisbury@oracle.com> X-Mailer: Claws Mail 3.20.0git84 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspamout07 X-Rspamd-Queue-Id: A3E062E X-Stat-Signature: py7owjexutwx3wofokrgw1udfgdsoyum X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Session-ID: U2FsdGVkX1/uXZbCySEtgex5AxvV1sPnrCRFaJ7kq8k= X-HE-Tag: 1773781757-867970 X-HE-Meta: U2FsdGVkX1+y+dIjIlb5fHTUZA1PDSAGOh27fKwn2tr+f3PNfxiGp22CCqvO4x7ohTobkT6V41FmQzfZ7lJ4+srgT+Vy8JTYwtC7i2VNIvE+em6OYrFp4L7s7LUn0RonOM/nIuwGmpw3/5uLsbdgbmrv38MxGx6PhFFBEMd7fL2pVvWWyLDtsgHQRwUSIE2PdNtz/IZYxAci0qHj/h7PmUc0RYUc3xuoaLQgxdkabVPFgU6MndgcDkQzhrnSOPBdNReXI8J9P6V0Oj+9bwG0Od1i10HtZOs7rAdGKl+hSf8Qy5ccF2fuw4WlNIRl/EN5Tk3fP6DQW+wRoaD2D9R2kmmm8l1/gzZqXUDOLL4NakTrzbOhthTrYMApKEwJlkK5qAxThFkvZ6otD1QR3/zMBcMmRFvzLgE5eKvk8cCL5+I= On Tue, 17 Mar 2026 15:58:07 -0400 Joseph Salisbury wrote: > sched_tick() only assigns resched_latency when the LATENCY_WARN feature is > enabled, but tests the variable later in a separate feature check. > > That leaves the code dependent on both checks observing identical state. > Initializing resched_latency to zero makes the later test safe even if the > feature state changes between the two checks. > > This does not change behavior when LATENCY_WARN is enabled. It only avoids > using an uninitialized local value. > > Fixes: c006fac556e4 ("sched: Warn on long periods of pending need_resched") > Cc: stable@vger.kernel.org > Assisted-by: Codex:GPT-5 > Signed-off-by: Joseph Salisbury > --- > kernel/sched/core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/sched/core.c b/kernel/sched/core.c > index 08a06162dd9a..15916186e4ff 100644 > --- a/kernel/sched/core.c > +++ b/kernel/sched/core.c > @@ -5548,7 +5548,7 @@ void sched_tick(void) > struct task_struct *donor; > struct rq_flags rf; > unsigned long hw_pressure; > - u64 resched_latency; > + u64 resched_latency = 0; > > if (housekeeping_cpu(cpu, HK_TYPE_KERNEL_NOISE)) > arch_scale_freq_tick(); The code has: if (sched_feat(LATENCY_WARN)) resched_latency = cpu_resched_latency(rq); calc_global_load_tick(rq); sched_core_tick(rq); scx_tick(rq); rq_unlock(rq, &rf); if (sched_feat(LATENCY_WARN) && resched_latency) resched_latency_warn(cpu, resched_latency); I guess if LATENCY_WARN gets enabled between the first check and the second, then the resched_latency could be uninitialized. Heck, probably could even get rid of the second sched_feat(LATENCY_WARN), and make it simply: if (resched_latency) Reviewed-by: Steven Rostedt (Google) -- Steve