From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C061F36CE0E; Wed, 18 Mar 2026 08:14:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773821656; cv=none; b=Kd87nFLD4CYm7y5GB/nq46U7UiCXGVbGdlJDpRxyI07GK9xHAHT1y6kyVB7VVSZHV0nN6ttf0vIXkU9p9qcprzGYd9MnwA1c1vtydQ0YgbFaR7MYnxupLyg1NKcSh/kExk3oebDiqM+4zvD7dXuO6h9FHr4DhPs94cvYe+TRkX8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773821656; c=relaxed/simple; bh=TJmXFfIJfaa6VOTzzmQKFARsgVBOZMjy1CMPytzgCEo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=sHRfQzQ5FJwUljPIfFJRG7WKEyjleTV/WV1Fb6est5CylhZgQoAVyrs7kvi5EigowMpJ/Q4FX94nbkMLDQkX9Pvv40ENPD4+deTW6CiOoabpAeOtEPge5Hz3TqoPmPalQV+JonhWherZP0VhMKb9k6EQ7ydJRNAdeVH1Ge9RnDY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=SpHpJhBW; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="SpHpJhBW" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E3DBFC19421; Wed, 18 Mar 2026 08:14:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1773821656; bh=TJmXFfIJfaa6VOTzzmQKFARsgVBOZMjy1CMPytzgCEo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=SpHpJhBWEv4EzWWo6op6XaS8chwtMxLg6jYhPsoBD3kRWXx/RnTLHv+HXQte9Zc1r XFvmderltrtB9O9PDsqNqMUke2qlGrIDk6noceCtU65p4gvQikiGern2bIsT8El5zw 6z/vcPv5p8X8hErUTsOqmgTFFes4v5vlzevULDI6D8gW/smSQ62bs8DSrc3AoASP+u SR42rlx2lAbL+xbNmuHbbBnJN+G8dwU79Z7r02XhVZQy+USDKkHPmWSjJSMG/CVlqw rbTHIBBrfk6vOLojG6iP4PLTzXMLI0e7a3C9yvF2e5ZeIIoDwhqWMhPagT+7j96k21 /XhPyxsrJ8kBQ== Date: Wed, 18 Mar 2026 09:14:14 +0100 From: Krzysztof Kozlowski To: Andre Przywara Cc: Mark Rutland , Lorenzo Pieralisi , Sudeep Holla , Salman Nabi , Vedashree Vidwans , Trilok Soni , Nirmoy Das , vsethi@nvidia.com, vwadekar@nvidia.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Rob Herring , Krzysztof Kozlowski , Conor Dooley , devicetree@vger.kernel.org Subject: Re: [PATCH v2 7/8] firmware: smccc: lfa: Register DT interrupt Message-ID: <20260318-mighty-handsome-spider-814ff4@quoll> References: <20260317103336.1273582-1-andre.przywara@arm.com> <20260317103336.1273582-8-andre.przywara@arm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20260317103336.1273582-8-andre.przywara@arm.com> On Tue, Mar 17, 2026 at 11:33:33AM +0100, Andre Przywara wrote: > + return devm_request_threaded_irq(dev, irq, lfa_irq_handler, > + lfa_irq_handler_thread, > + IRQF_COND_ONESHOT, NULL, NULL); > +} > + > static int lfa_faux_probe(struct faux_device *fdev) > { > int ret; > @@ -854,6 +893,12 @@ static int lfa_faux_probe(struct faux_device *fdev) > } > } > > + ret = lfa_register_dt(&fdev->dev); > + if (!ret) > + pr_info("registered LFA DT notification interrupt\n"); Drop. Drivers must be silent on success (mentioned more than once in coding docs). Starting FW update would deserve a comment, but probing a device or its resource is completely irrelevant for the user. > + if (ret != -ENODEV) > + return ret; > + > return 0; > } > > -- > 2.43.0 >