From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 810053ED5CF for ; Wed, 18 Mar 2026 16:40:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773852020; cv=none; b=ZebO2aGHYnExDbBdRO+XdgXyFFTegSjhiXQjYFI4DAZg771uzJWo++OoxuFlGKv2phYJUIscVryjfwM30lxONtUYCcRW8G4xTdmBj5VAF5pi9c38vYJN8QpjTC4pb+28vmwvqHVPwt4wl9UmlNS/JYKg9GPxsyBUm/cdlQj5Z3s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773852020; c=relaxed/simple; bh=o6AVF+seDXXoEKcYyR4YjiujzkKLhAV0t0FitFZE+LY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=TTsxmvVl4bjI9W4GopR9sIWfRDuvTt8ocNlu2V3g8m8DrpH+fLWs8oKNkbE0DQk/O5v7MBLTIyioCiHgaPzVt2E3P3Rb7v00Q3O01jojeNnsyIEL9qponlIOWDJBEOho3M+R0mspN997mKABhY7Uc1fZJIcSnUiolbyw8sw8gBE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=ftikvnJL; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="ftikvnJL" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1773852018; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=bMBkRhNtl1otgu2Cs3jk5tJVzD2P2TtDrsldPd05Oik=; b=ftikvnJLj91pdEBVWVpxjnxSK8plPc0mpXrrrcWuFRIV232NeBtS5y6iimKwcxgaBDoqhj f86egjRdZeMAfXThLp2JVinsz+p+hzRm4mT9yC7WWxQL3CHRDixyPXgi8yv/cZmcYqSRk1 XY9DOFIWeBcoSkK9gGPGfKdKyhSxnJ0= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-457-tJlDMtgMOUWA-GjSaf3ifQ-1; Wed, 18 Mar 2026 12:40:11 -0400 X-MC-Unique: tJlDMtgMOUWA-GjSaf3ifQ-1 X-Mimecast-MFC-AGG-ID: tJlDMtgMOUWA-GjSaf3ifQ_1773852010 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id BF45B1955F18; Wed, 18 Mar 2026 16:40:09 +0000 (UTC) Received: from my-developer-toolbox-latest (unknown [10.2.16.140]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with SMTP id 2D6021800351; Wed, 18 Mar 2026 16:40:07 +0000 (UTC) Date: Wed, 18 Mar 2026 09:40:05 -0700 From: Chris Leech To: alistair23@gmail.com Cc: hare@suse.de, kbusch@kernel.org, axboe@kernel.dk, hch@lst.de, sagi@grimberg.me, kch@nvidia.com, linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org, Alistair Francis Subject: Re: [PATCH] nvme-auth: Include SC_C in RVAL controller hash Message-ID: <20260318-straw-snazzy-a8976b9c9427@redhat.com> References: <20260317031330.2794078-1-alistair.francis@wdc.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260317031330.2794078-1-alistair.francis@wdc.com> X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 On Tue, Mar 17, 2026 at 01:13:30PM +1000, alistair23@gmail.com wrote: > From: Alistair Francis > > Section 8.3.4.5.5 of the NVMe Base Specification 2.1 describes what is > included in the Response Value (RVAL) hash and SC_C should be included. > Currently we are hardcoding 0 instead of using the correct SC_C value. > > Update the host and target code to use the SC_C when calculating the > RVAL instead of using 0. Am I correct in reading this, the current kernel implementation is out of spec when doing secure channel concatenation (SC_C != 0) with bidirectional authentication (R1 takes SC_C into account, but not R2)? - Chris