From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5A117134CF for ; Wed, 18 Mar 2026 00:08:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773792505; cv=none; b=I1KgbhRBcOR014z8ZfT4K/4luP+kV5qTOUVJlG7hMiX7KOwC0nCXxxf+4gEey1aTIIz71zNp8AF3Ga3qy50WEB+BkmmyJziYxz5Y6mMRVR8/jgOZ3IhT7ZaLsN7WBpSVXQcWqoG2TcxTqbHOTFsMeOhk79qKUddlE2w87RbEu5k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773792505; c=relaxed/simple; bh=djFFpPUmzZrEXSAwoP2fU6PeHYBExiHv5Hefbxl+VZE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=t5btjdaCB8IHHJDF5MH5uSBZL5OoUGTKWi6y3MQAAVFMCrA5u580u+HrYPxsar1QiTgj1tO5W0t6CmG8ZGWp2e8p30w+gWPCHAr68ksKVWEx0uXkFQOi7rRyxSeGwPzZuwR2I2rTn1yTZjrMjQuFofTkf6l4W25KviEh1FzOrQ4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=B14gM2Nx; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="B14gM2Nx" Received: by smtp.kernel.org (Postfix) with ESMTPSA id BCA32C2BCB9; Wed, 18 Mar 2026 00:08:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1773792505; bh=djFFpPUmzZrEXSAwoP2fU6PeHYBExiHv5Hefbxl+VZE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=B14gM2NxXwWc8lTi/b7HajGaiaT/Kpvsy4hzPBngZCRuYZGmqrtNkE74SQ8/y0XaV ZWn2u6THSdbxgZtuKKYVyN2PK+bt1wqzTM0pxkv76Gcd72zrA4uwjuYlKSWVKFbTeA R9T3Ks8VnKUWxU94ImqCIHmoNzTdV3U1NjFD1t6tSpnB0VT1KzOnHkQdyqbw8bR8dM Mg6/5P3f9rAfK9/Sl4dbzC/PhS5767pQOy5dDvUjLoMtfSbk/RexC6+L7AKTL/pX6+ gQj4CJE9KR+UH9Dsg/FeYVoZgblq7NyzcYXSLXXvgpRpAAyCGtJC/f7xC9HjxAnvVH 5N11YHhEIkfgA== From: SeongJae Park To: "Vishal Moola (Oracle)" Cc: SeongJae Park , Michal Clapinski , Evangelos Petrongonas , Pasha Tatashin , Mike Rapoport , Pratyush Yadav , Alexander Graf , Samiullah Khawaja , kexec@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrew Morton Subject: Re: [PATCH v7 2/3] kho: fix deferred init of kho scratch Date: Tue, 17 Mar 2026 17:08:15 -0700 Message-ID: <20260318000817.130248-1-sj@kernel.org> X-Mailer: git-send-email 2.47.3 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On Tue, 17 Mar 2026 16:23:07 -0700 "Vishal Moola (Oracle)" wrote: > On Tue, Mar 17, 2026 at 03:15:33PM +0100, Michal Clapinski wrote: > > Currently, if DEFERRED is enabled, kho_release_scratch will initialize > > the struct pages and set migratetype of kho scratch. Unless the whole > > scratch fit below first_deferred_pfn, some of that will be overwritten > > either by deferred_init_pages or memmap_init_reserved_pages. > > > > To fix it, I modified kho_release_scratch to only set the migratetype > > on already initialized pages. Then, modified init_pageblock_migratetype > > to set the migratetype to CMA if the page is located inside scratch. > > > > Signed-off-by: Michal Clapinski > > --- > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > > index ee81f5c67c18..5ca078dde61d 100644 > > --- a/mm/page_alloc.c > > +++ b/mm/page_alloc.c > > @@ -55,6 +55,7 @@ > > #include > > #include > > #include > > +#include > > #include > > #include "internal.h" > > #include "shuffle.h" > > @@ -549,6 +550,12 @@ void __meminit init_pageblock_migratetype(struct page *page, > > migratetype < MIGRATE_PCPTYPES)) > > migratetype = MIGRATE_UNMOVABLE; > > > > + /* > > + * Mark KHO scratch as CMA so no unmovable allocations are made there. > > + */ > > + if (unlikely(kho_scratch_overlap(page_to_phys(page), PAGE_SIZE))) > > + migratetype = MIGRATE_CMA; > > + > > flags = migratetype; > > > > #ifdef CONFIG_MEMORY_ISOLATION > > I've just tried to build the current mm-new tree. I'm getting this > error: > > error: ‘MIGRATE_CMA’ undeclared (first use in this function); did you mean ‘MIGRATE_SYNC’? > 557 | migratetype = MIGRATE_CMA; > | ^~~~~~~~~~~ > | MIGRATE_SYNC > > >From what I can tell, MIGRATE_CMA is only defined if CONFIG_CMA is > enabled (for x86 defconfig its disabled). I also got the same issue, and was about to report. I added below workaround patch to my test setup. It is just a temporal quick fix for only my setup. Michal or others may find a better fix. === >8 === >From 9d89a12e1a17edd68750e97b0c8b1970e3adc648 Mon Sep 17 00:00:00 2001 From: SeongJae Park Date: Tue, 17 Mar 2026 16:56:17 -0700 Subject: [PATCH] mm/page_alloc: enclose kho-specific code with CONFIG_KEXEC_HANDOVER Signed-off-by: SeongJae Park --- mm/page_alloc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/mm/page_alloc.c b/mm/page_alloc.c index 5ca078dde61d6..ed4d585f46202 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -550,11 +550,13 @@ void __meminit init_pageblock_migratetype(struct page *page, migratetype < MIGRATE_PCPTYPES)) migratetype = MIGRATE_UNMOVABLE; +#ifdef CONFIG_KEXEC_HANDOVER /* * Mark KHO scratch as CMA so no unmovable allocations are made there. */ if (unlikely(kho_scratch_overlap(page_to_phys(page), PAGE_SIZE))) migratetype = MIGRATE_CMA; +#endif flags = migratetype; -- 2.47.3