From: "Hüseyin Can Erdem" <erdemhuseyincan09@gmail.com>
To: gregkh@linuxfoundation.org
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
"Hüseyin Can Erdem" <erdemhuseyincan09@gmail.com>
Subject: [PATCH 2/2] staging: rtl8723bs: add parentheses around macro arguments
Date: Wed, 18 Mar 2026 18:35:15 +0300 [thread overview]
Message-ID: <20260318153515.5071-2-erdemhuseyincan09@gmail.com> (raw)
In-Reply-To: <20260318153515.5071-1-erdemhuseyincan09@gmail.com>
Add parentheses around macro arguments in IS_FW_HEADER_EXIST_8723B
and AVAILABLE_EFUSE_ADDR to avoid potential operator precedence issues.
Signed-off-by: Hüseyin Can Erdem <erdemhuseyincan09@gmail.com>
---
drivers/staging/rtl8723bs/include/rtl8723b_hal.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8723bs/include/rtl8723b_hal.h b/drivers/staging/rtl8723bs/include/rtl8723b_hal.h
index 32a93653b..cd3b49338 100644
--- a/drivers/staging/rtl8723bs/include/rtl8723b_hal.h
+++ b/drivers/staging/rtl8723bs/include/rtl8723b_hal.h
@@ -28,7 +28,7 @@
#define FW_8723B_END_ADDRESS 0x1FFF /* 0x5FFF */
#define IS_FW_HEADER_EXIST_8723B(fw_hdr) \
- ((le16_to_cpu(fw_hdr->signature) & 0xFFF0) == 0x5300)
+ ((le16_to_cpu((fw_hdr)->signature) & 0xFFF0) == 0x5300)
struct rt_firmware {
u32 fw_length;
@@ -133,7 +133,7 @@ struct rt_firmware_hdr {
#define EFUSE_IC_ID_OFFSET 506 /* For some inferiority IC purpose.
* Added by Roger, 2009.09.02.
*/
-#define AVAILABLE_EFUSE_ADDR(addr) (addr < EFUSE_REAL_CONTENT_LEN_8723B)
+#define AVAILABLE_EFUSE_ADDR(addr) ((addr) < EFUSE_REAL_CONTENT_LEN_8723B)
#define EFUSE_ACCESS_ON 0x69 /* For RTL8723 only. */
#define EFUSE_ACCESS_OFF 0x00 /* For RTL8723 only. */
--
2.47.3
next prev parent reply other threads:[~2026-03-18 15:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-18 15:01 [PATCH v3] staging: rtl8723bs: fix code style issues in rtl8723b_hal.h Hüseyin Can Erdem
2026-03-18 15:12 ` Greg KH
2026-03-18 15:35 ` [PATCH 1/2] staging: rtl8723bs: replace __attribute__((__packed__)) with __packed Hüseyin Can Erdem
2026-03-18 15:35 ` Hüseyin Can Erdem [this message]
2026-03-18 15:59 ` [PATCH 2/2] staging: rtl8723bs: add parentheses around macro arguments Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260318153515.5071-2-erdemhuseyincan09@gmail.com \
--to=erdemhuseyincan09@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®