From: "Bera Yüzlü" <b9788213@gmail.com>
To: gregkh@linuxfoundation.org
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
"Bera Yüzlü" <b9788213@gmail.com>,
"Ethan Tidmore" <ethantidmore06@gmail.com>
Subject: [PATCH v2] staging: rtl8723bs: Remove dead code
Date: Wed, 18 Mar 2026 22:50:05 +0300 [thread overview]
Message-ID: <20260318195005.23962-1-b9788213@gmail.com> (raw)
Clean up the dm_odm_t structure by removing commented-out members and
related legacy comments.
Signed-off-by: Bera Yüzlü <b9788213@gmail.com>
Reviewed-by: Ethan Tidmore <ethantidmore06@gmail.com>
---
V2: Deleted other remaining comments.
V2: Restored /* common */ comment.
V1 link: https://lore.kernel.org/linux-staging/2026031851-elephant-unnamed-7e95@gregkh/T/#u
drivers/staging/rtl8723bs/hal/odm.h | 34 -----------------------------
1 file changed, 34 deletions(-)
diff --git a/drivers/staging/rtl8723bs/hal/odm.h b/drivers/staging/rtl8723bs/hal/odm.h
index 38830552d5bc..d186cf2f3add 100644
--- a/drivers/staging/rtl8723bs/hal/odm.h
+++ b/drivers/staging/rtl8723bs/hal/odm.h
@@ -650,10 +650,6 @@ struct ant_detected_info {
/* 2011/09/22 MH Copy from SD4 defined structure. We use to support PHY DM integration. */
/* */
struct dm_odm_t { /* DM_Out_Source_Dynamic_Mechanism_Structure */
- /* struct timer_list FastAntTrainingTimer; */
- /* */
- /* Add for different team use temporarily */
- /* */
struct adapter *Adapter; /* For CE/NIC team */
/* WHen you use Adapter or priv pointer, you must make sure the pointer is ready. */
bool odm_ready;
@@ -673,17 +669,6 @@ struct dm_odm_t { /* DM_Out_Source_Dynamic_Mechanism_Structure */
u8 ControlChannel;
/* ODM HANDLE, DRIVER NEEDS NOT TO HOOK------ */
-/* REMOVED COMMON INFO---------- */
- /* u8 PseudoMacPhyMode; */
- /* bool *BTCoexist; */
- /* bool PseudoBtCoexist; */
- /* u8 OPMode; */
- /* bool bAPMode; */
- /* bool bClientMode; */
- /* bool bAdHocMode; */
- /* bool bSlaveOfDMSP; */
-/* REMOVED COMMON INFO---------- */
-
/* 1 COMMON INFORMATION */
/* */
@@ -766,7 +751,6 @@ struct dm_odm_t { /* DM_Out_Source_Dynamic_Mechanism_Structure */
u8 *pAntennaTest;
bool *pbNet_closed;
u8 *mp_mode;
- /* u8 *pAidMap; */
u8 *pu1ForcedIgiLb;
/* For 8723B IQK----------- */
bool *pIs1Antenna;
@@ -865,18 +849,9 @@ struct dm_odm_t { /* DM_Out_Source_Dynamic_Mechanism_Structure */
/* Latest packet phy info (ODM write) */
struct odm_phy_dbg_info PhyDbgInfo;
- /* PHY_INFO_88E PhyInfo; */
/* Latest packet phy info (ODM write) */
struct odm_mac_status_info *pMacInfo;
- /* MAC_INFO_88E MacInfo; */
-
- /* Different Team independent structure?? */
-
- /* */
- /* TX_RTP_CMN TX_retrpo; */
- /* TX_RTP_88E TX_retrpo; */
- /* TX_RTP_8195 TX_retrpo; */
/* */
/* ODM Structure */
@@ -902,15 +877,6 @@ struct dm_odm_t { /* DM_Out_Source_Dynamic_Mechanism_Structure */
/* */
/* common */
- /* u8 DM_Type; */
- /* u8 PSD_Report_RXHP[80]; Add By Gary */
- /* u8 PSD_func_flag; Add By Gary */
- /* for DIG */
- /* u8 bDMInitialGainEnable; */
- /* u8 binitialized; for dm_initial_gain_Multi_STA use. */
- /* for Antenna diversity */
- /* u8 AntDivCfg; 0:OFF , 1:ON, 2:by efuse */
- /* PSTA_INFO_T RSSI_target; */
bool *pbDriverStopped;
bool *pbDriverIsGoingToPnpSetPowerSleep;
--
2.53.0
reply other threads:[~2026-03-18 19:50 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260318195005.23962-1-b9788213@gmail.com \
--to=b9788213@gmail.com \
--cc=ethantidmore06@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®