From: Peter Zijlstra <peterz@infradead.org>
To: Mark Brown <broonie@kernel.org>
Cc: "Matthew Wilcox (Oracle)" <willy@infradead.org>,
Ingo Molnar <mingo@redhat.com>, Will Deacon <will@kernel.org>,
Boqun Feng <boqun.feng@gmail.com>,
Waiman Long <longman@redhat.com>,
linux-kernel@vger.kernel.org, Aishwarya.TCV@arm.com
Subject: Re: [PATCH 1/3] rwsem: Remove the list_head from struct rw_semaphore
Date: Wed, 18 Mar 2026 21:28:51 +0100 [thread overview]
Message-ID: <20260318202851.GL3738010@noisy.programming.kicks-ass.net> (raw)
In-Reply-To: <78e16f40-28f1-4dcb-a5ab-b2a29e43f048@sirena.org.uk>
[-- Attachment #1: Type: text/plain, Size: 1103 bytes --]
On Wed, Mar 18, 2026 at 07:07:24PM +0000, Mark Brown wrote:
> On Thu, Mar 05, 2026 at 07:55:41PM +0000, Matthew Wilcox (Oracle) wrote:
> > Instead of embedding a list_head in struct rw_semaphore, store a pointer
> > to the first waiter. The list of waiters remains a doubly linked list
> > so we can efficiently add to the tail of the list, remove from the front
> > (or middle) of the list.
>
> > Some of the list manipulation becomes more complicated, but it's a
> > reasonable tradeoff on the slow paths to shrink some core data structures
> > like struct inode.
>
> In the past few days we've started seeing lockups when running LTP on
> -next on a range of arm64 platforms which bisect to this patch. It
> looks like corruption of some kind, the exact trigger varies but it's
> very predictable that something goes wrong and we get lots of rwsem
> related backtraces which do seem relevant to this commmit. This one
> seems reasonably typical:
I merged the fix in todays branch:
https://lkml.kernel.org/r/177382097549.1647592.8219974128268935080.tip-bot2@tip-bot2
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2026-03-18 20:29 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-05 19:55 [PATCH 0/3] Shrink size of sleeping locks Matthew Wilcox (Oracle)
2026-03-05 19:55 ` [PATCH 1/3] rwsem: Remove the list_head from struct rw_semaphore Matthew Wilcox (Oracle)
2026-03-09 19:48 ` [tip: locking/core] locking/rwsem: " tip-bot2 for Matthew Wilcox (Oracle)
2026-03-14 0:03 ` Andrei Vagin
2026-03-18 19:07 ` [PATCH 1/3] rwsem: " Mark Brown
2026-03-18 20:28 ` Peter Zijlstra [this message]
2026-03-19 13:47 ` Mark Brown
2026-03-05 19:55 ` [PATCH 2/3] semaphore: Remove the list_head from struct semaphore Matthew Wilcox (Oracle)
2026-03-09 19:48 ` [tip: locking/core] locking/semaphore: " tip-bot2 for Matthew Wilcox (Oracle)
2026-03-05 19:55 ` [PATCH 3/3] mutex: Remove the list_head from struct mutex Matthew Wilcox (Oracle)
2026-03-07 0:30 ` kernel test robot
2026-03-09 19:48 ` [tip: locking/core] locking/mutex: " tip-bot2 for Matthew Wilcox (Oracle)
2026-03-06 10:14 ` [PATCH 0/3] Shrink size of sleeping locks Peter Zijlstra
2026-03-09 19:48 ` [tip: locking/core] locking/rwsem: Add context analysis tip-bot2 for Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260318202851.GL3738010@noisy.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=Aishwarya.TCV@arm.com \
--cc=boqun.feng@gmail.com \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=longman@redhat.com \
--cc=mingo@redhat.com \
--cc=will@kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®