From: Omer El Idrissi <omer.e.idrissi@gmail.com>
To: gregkh@linuxfoundation.org
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
Omer El Idrissi <omer.e.idrissi@gmail.com>
Subject: [PATCH] rtl8723bs: replace _SUCCESS/_FAIL with standard errno
Date: Wed, 18 Mar 2026 22:41:03 +0100 [thread overview]
Message-ID: <20260318214104.16971-1-omer.e.idrissi@gmail.com> (raw)
Replace non-standard return values with descriptive
linux kernel error codes in probe path.
Also replace the variable name 'status' with 'ret'
to be more consistent with other kernel code
Signed-off-by: Omer El Idrissi <omer.e.idrissi@gmail.com>
diff --git a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c
index d664e254912c..ff0ebcb59c68 100644
--- a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c
+++ b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c
@@ -345,38 +345,46 @@ static int rtw_drv_init(
struct sdio_func *func,
const struct sdio_device_id *id)
{
- int status = _FAIL;
+ int ret;
struct adapter *if1 = NULL;
struct dvobj_priv *dvobj;
dvobj = sdio_dvobj_init(func);
- if (!dvobj)
+ if (!dvobj) {
+ ret = -ENOMEM;
goto exit;
+ }
if1 = rtw_sdio_if1_init(dvobj, id);
- if (!if1)
+ if (!if1) {
+ ret = -ENOMEM;
goto free_dvobj;
+ }
/* dev_alloc_name && register_netdev */
- status = rtw_drv_register_netdev(if1);
- if (status != _SUCCESS)
+ ret = rtw_drv_register_netdev(if1);
+ if (ret) {
+ ret = -EIO;
goto free_if1;
+ }
- status = sdio_alloc_irq(dvobj);
- if (status != _SUCCESS)
+ ret = sdio_alloc_irq(dvobj);
+ if (ret) {
+ ret = -EIO;
goto free_if1;
+ }
- status = _SUCCESS;
+ ret = _SUCCESS;
free_if1:
- if (status != _SUCCESS && if1)
+ if (ret != _SUCCESS && if1)
rtw_sdio_if1_deinit(if1);
free_dvobj:
- if (status != _SUCCESS)
+ if (ret != _SUCCESS)
sdio_dvobj_deinit(func);
exit:
- return status == _SUCCESS ? 0 : -ENODEV;
+ return ret;
}
static void rtw_dev_remove(struct sdio_func *func)
---
drivers/staging/rtl8723bs/os_dep/sdio_intf.c | 30 +++++++++++++-------
1 file changed, 19 insertions(+), 11 deletions(-)
diff --git a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c
index d664e254912c..ff0ebcb59c68 100644
--- a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c
+++ b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c
@@ -345,38 +345,46 @@ static int rtw_drv_init(
struct sdio_func *func,
const struct sdio_device_id *id)
{
- int status = _FAIL;
+ int ret;
struct adapter *if1 = NULL;
struct dvobj_priv *dvobj;
dvobj = sdio_dvobj_init(func);
- if (!dvobj)
+ if (!dvobj) {
+ ret = -ENOMEM;
goto exit;
+ }
if1 = rtw_sdio_if1_init(dvobj, id);
- if (!if1)
+ if (!if1) {
+ ret = -ENOMEM;
goto free_dvobj;
+ }
/* dev_alloc_name && register_netdev */
- status = rtw_drv_register_netdev(if1);
- if (status != _SUCCESS)
+ ret = rtw_drv_register_netdev(if1);
+ if (ret) {
+ ret = -EIO;
goto free_if1;
+ }
- status = sdio_alloc_irq(dvobj);
- if (status != _SUCCESS)
+ ret = sdio_alloc_irq(dvobj);
+ if (ret) {
+ ret = -EIO;
goto free_if1;
+ }
- status = _SUCCESS;
+ ret = _SUCCESS;
free_if1:
- if (status != _SUCCESS && if1)
+ if (ret != _SUCCESS && if1)
rtw_sdio_if1_deinit(if1);
free_dvobj:
- if (status != _SUCCESS)
+ if (ret != _SUCCESS)
sdio_dvobj_deinit(func);
exit:
- return status == _SUCCESS ? 0 : -ENODEV;
+ return ret;
}
static void rtw_dev_remove(struct sdio_func *func)
--
2.51.0
next reply other threads:[~2026-03-18 21:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-18 21:41 Omer El Idrissi [this message]
2026-03-19 9:09 ` Dan Carpenter
2026-03-20 7:05 ` Omer El Idrissi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260318214104.16971-1-omer.e.idrissi@gmail.com \
--to=omer.e.idrissi@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®