From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 631A32F83AE for ; Wed, 18 Mar 2026 11:37:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773833878; cv=none; b=Q8OGpYhOSfpat1WBf5aVyO0TkluQm4G/c4tMOsyedXidWQQxyXYj5BWXabgtl9KllueG1n8Odv7oGj5RcP6fu8nhu8Qo6S++/hHyS3biBypccgWAw7PjL2eKtEDIoDG2pbnbQaZj/OVg8R/DS2s8Go40f+ESdEwdWK68Etrau1Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773833878; c=relaxed/simple; bh=1q5xqs8SZiDZH0JBEg5ry2xzTMoklBhrzjzt+vYMfuc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=CIAY5JFixWg28AZ3wJY1TnXGmCzqDA2b8BNWhxeh9W71TyLvL8FJkpo+rr5KohXt5mHmlAFrfCZsJRmvs7qQcaOUApM+jXycUmu5vbOCVvLn4v2KjqKNwmh/8k86iZVFZL77OlTLygSYHiTCk+0+5T/ORiWynMdN5q3Jn47S3Rw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=Yh7NH6h5; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="Yh7NH6h5" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9B027C19421; Wed, 18 Mar 2026 11:37:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1773833878; bh=1q5xqs8SZiDZH0JBEg5ry2xzTMoklBhrzjzt+vYMfuc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Yh7NH6h5wnRamqWpnQshBrFRwrPjTr8PlJoGyJZ4ibq4QLui2+58kA6vQ0UptUCIF c0XpZzL61kNaX4MHTFYQukGBDrdNt700w9R0yi2KAZWXJI2ZPTZjLCg681iDcIIKC1 MvzeZWPcKJbAr+G7wQXpSpSogwMnsyMsHFGOwId0= Date: Wed, 18 Mar 2026 10:53:06 +0100 From: Greg KH To: Akshay Gupta Cc: linux-kernel@vger.kernel.org, arnd@arndb.de, naveenkrishna.chatradhi@amd.com, Anand.Umarji@amd.com, Prathima L K Subject: Re: [PATCH] misc: amd-sbi: Address CPUID extended function bits Message-ID: <2026031858-prepaid-thank-eb29@gregkh> References: <20260318094706.2623258-1-Akshay.Gupta@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260318094706.2623258-1-Akshay.Gupta@amd.com> On Wed, Mar 18, 2026 at 03:17:06PM +0530, Akshay Gupta wrote: > According to the UAPI header (amd-apml.h), the CPUID extended function > capability is indicated by bits [55:48], but the driver currently > checks bits [63:56]. Adjust the driver to use bits [55:48] so that > extended function capability is detected correctly. > > Fixes: bb13a84ed6b7 ("misc: amd-sbi: Add support for CPUID protocol") > Tested-by: Prathima L K > Reviewed-by: Naveen Krishna Chatradhi > Signed-off-by: Akshay Gupta > --- > drivers/misc/amd-sbi/rmi-core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/misc/amd-sbi/rmi-core.c b/drivers/misc/amd-sbi/rmi-core.c > index c3a58912d6db..6979bfd7da64 100644 > --- a/drivers/misc/amd-sbi/rmi-core.c > +++ b/drivers/misc/amd-sbi/rmi-core.c > @@ -48,7 +48,7 @@ > /* CPUID MCAMSR mask & index */ > #define CPUID_MCA_THRD_INDEX 32 > #define CPUID_MCA_FUNC_MASK GENMASK(31, 0) > -#define CPUID_EXT_FUNC_INDEX 56 > +#define CPUID_EXT_FUNC_INDEX 48 > > /* input for bulk write to CPUID protocol */ > struct cpu_msr_indata { > -- > 2.34.1 > Hi, This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree. You are receiving this message because of the following common error(s) as indicated below: - You have marked a patch with a "Fixes:" tag for a commit that is in an older released kernel, yet you do not have a cc: stable line in the signed-off-by area at all, which means that the patch will not be applied to any older kernel releases. To properly fix this, please follow the documented rules in the Documentation/process/stable-kernel-rules.rst file for how to resolve this. If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers. thanks, greg k-h's patch email bot