From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f225.google.com (mail-pl1-f225.google.com [209.85.214.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DCB6A1E0DD8 for ; Thu, 19 Mar 2026 05:52:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.225 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773899539; cv=none; b=GdXrhjSIfqdojFHk0kHDLnEhq56xdrin6df7i1NKTBttFfnipWJ6VVzvIujDnKXVJ5/gYGiJYik357sOdMf0nin/yFoFocCEASYowyAGPDkNezOveXMGoiobHXfKnK98Xo+6bowbEwepatgOIjHqnmN3qsHnIKksNp10eOMutoQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773899539; c=relaxed/simple; bh=/eTE0ZFTzGnRK8R4FVp3sVhsToT4DkidTTDVuLzOvoM=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=BTrJWaLKY7uR1nad/OMOitsJRk3cumZujjCjwIgfJ8b79/hQjMUWoaXwfvJdqY7FLFKxIyg1jvJhajpDh4/Zr9mcBzlJ1/nvDeXpzK+AJ7iIQx1zOMFGjXhiP5vPAK3ohxc+UxFg+xm+F7kFBbxlnTtKs/jKT/SHegYNzuiy9xU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=L6dtI3wv; arc=none smtp.client-ip=209.85.214.225 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="L6dtI3wv" Received: by mail-pl1-f225.google.com with SMTP id d9443c01a7336-2b04e6a989eso4023075ad.3 for ; Wed, 18 Mar 2026 22:52:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773899537; x=1774504337; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:dkim-signature:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=cVu/8xvOsdGoGd4w2kwUZr836dq46hFLl6aqiaFuMak=; b=D6ylBGvRhvw3VVNKH3WuINVLNLrFIY2183nE2X8U8V9lmWZLnsbq80JmlQjUE6Iplq yHtvtJShcU8LK//OEtVaaeOd2HoqjnqUAVM3j3RQ2TL/3cQ8F0m/hYY0paz+aj9J2L8i NK74s9imv9y8GH4FoSgRriBvWTunLZxD8hvLX1PJp4J/37VLIKgyZ4y5UQAFRokax0Ub 1jsI3dtj3uJBli69ZwRqqc/OPTigcEfCy+HDKM7meQQuFiRYS1h1Ocqj/7jPwiuZxHgO Z/4twKaoex5t/h1jg6IwGrP7lqXytgl8r+xA4pXnUt/PLtCw5lighcT4vSAy0Mof6wk0 D0gQ== X-Forwarded-Encrypted: i=1; AJvYcCUfQisJbpMyxxopruUASqf0Hq3NDDmt4sQ16gTq09Zj1SQ5KHDELi04QeOHPjza5nYiaOeYyk9euL3Z+/o=@vger.kernel.org X-Gm-Message-State: AOJu0YzfhZSG/4w4kvCqzW+fOYlPY2Ubw8Fj/XbRDI4IgCMnWtnqHP+q kxHF2pY9NGDrqnG8q4HDd8NtmHme7mP2P611S/7H56LuUz+om6rF+NxY+0zIsIGIszrIoki+fNQ D1z7IKvcipJlXjERfgH4rfuh0e8zMiEQTai4k07TepJWJbMVJRBo5YNJtE6Urs+KJYyD8GcAIox 31aYrYrvVeVH2+JSpXrXQlD3aAQ1QjoBpLGXLexw5E4dIMKI/F0emKAyyP4h1wZpxvT01qTE/zG ZogYCav7UiFDx48rg== X-Gm-Gg: ATEYQzxsCU/4R0V7TqBek+19garaT6EUCiU4Z9k6350t2os0y9mcjj4Cv9gBn7iGbYz oxWscZd7jorG0ZS/r02gxVEgWAF2bUfSSRSLWWyuLAqcVT656bVGwFkkuTAvE+bwR9KiufX37SE 0VTs0Su9c1ugnUAHGyiDWuBsAEyagvYvXQKN0IdzVWOUgltt8zACAiSLQ70IoXqZiqNQ3zmQU7P 84AHVMmrukH7lm/0GH7DvHaOTe6148IrYofFCXst+IB74DCR6VsdWO9bJqcpF6HgDHdZ/JVSG++ yAOCf4Ul47RRcY/4rKwDbgFHfxrybFAM62/Yr4aBFD6GRMAMmLgmdZTWyez8bd6yV84G+1aPa62 hHZUoUznZs/vbmI7Irs8LkNMeanyYta9bdroEVXR8xqxTGXwu6SqUjl6saZRX5O/m3+BfFQj+H9 Zx2GdcKiiZ/RSqVbpy3wT7iStCjABt6KYC7ruMXEssso9TnyQ9YkpPf2nTLQ== X-Received: by 2002:a17:902:f544:b0:2ae:8253:1452 with SMTP id d9443c01a7336-2b06e2da4f2mr62956955ad.11.1773899537074; Wed, 18 Mar 2026 22:52:17 -0700 (PDT) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-102.dlp.protect.broadcom.com. [144.49.247.102]) by smtp-relay.gmail.com with ESMTPS id d9443c01a7336-2b06e60b519sm5294945ad.38.2026.03.18.22.52.16 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 18 Mar 2026 22:52:17 -0700 (PDT) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-yx1-f69.google.com with SMTP id 956f58d0204a3-649deef077eso1280088d50.1 for ; Wed, 18 Mar 2026 22:52:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1773899536; x=1774504336; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=cVu/8xvOsdGoGd4w2kwUZr836dq46hFLl6aqiaFuMak=; b=L6dtI3wvQDaWST57Ws4NfqUNV59D0LKmsPlT8Db/ZtLmUxHtdiSCzLdbby/3HIyb8E P7pCqGF179tnihC4BVK2xjATpeNTmpPTFRKavciwjfDhU0OIduKL9T0kJ/O3Zx3s16Ne CM9E9r6k4NeK8cziqndRgeNRrAv9pTpYfQ6/w= X-Forwarded-Encrypted: i=1; AJvYcCW/kqK9N6aGUtYUnWaD5euASroS7k7IGPN970iaBiMXeId4Zb4k/1Lg4dcpgo/dij73oP95Wgfgth22qEw=@vger.kernel.org X-Received: by 2002:a05:690e:5c9:b0:64c:e789:4397 with SMTP id 956f58d0204a3-64e912fb6demr5090535d50.10.1773899535929; Wed, 18 Mar 2026 22:52:15 -0700 (PDT) X-Received: by 2002:a05:690e:5c9:b0:64c:e789:4397 with SMTP id 956f58d0204a3-64e912fb6demr5090530d50.10.1773899535441; Wed, 18 Mar 2026 22:52:15 -0700 (PDT) Received: from localhost.localdomain ([192.19.203.250]) by smtp.gmail.com with ESMTPSA id 956f58d0204a3-64e91a1cd32sm2918980d50.2.2026.03.18.22.52.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Mar 2026 22:52:15 -0700 (PDT) From: Vikas Gupta To: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, michael.chan@broadcom.com, pavan.chebbi@broadcom.com, vsrama-krishna.nemani@broadcom.com, rajashekar.hudumula@broadcom.com, ajit.khaparde@broadcom.com, Vikas Gupta Subject: [PATCH net-next v8 00/10] bng_en: add link management and statistics support Date: Thu, 19 Mar 2026 11:21:14 +0530 Message-ID: <20260319055124.1350670-1-vikas.gupta@broadcom.com> X-Mailer: git-send-email 2.47.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e Hi, This series enhances the bng_en driver by adding: 1. Link/PHY support a. Link query b. Async Link events c. Ethtool link set/get functionality 2. Hardware statistics reporting via ethtool -S This version incorporates feedback received prior to splitting the original series into two parts. Addressed following comments from Andrew Lunn - Apply Rev-xmas fix in several places. - Correct ethtool-speed comment to reflect accurate behavior. https://lore.kernel.org/netdev/49930724-74b8-41fe-8f5c-482afc976b82@lunn.ch/ https://lore.kernel.org/netdev/CANXQDtb5XuLKOOorCMYDUpVz6aFuQgvmQZ4pS6RJGkAgeM8n1A@mail.gmail.com/ Addressed following comments from Jakub Kicinski - Took care of missing mutex_init() https://lore.kernel.org/netdev/20251127190855.69779791@kernel.org/#t https://lore.kernel.org/netdev/CANXQDtYy2JziaaVi=Cqt+gAJNt4NjFFs8NbhrS=RBV61ORwinA@mail.gmail.com/ Addressed following comments from ALOK TIWARI - Add newline for clarity/formatting. https://lore.kernel.org/netdev/CANXQDtZbLhdwEtN+kKg1OVLV+uy-gsNfX+rU4MR77QPuO6_y9A@mail.gmail.com/ v8: - Fix the smatch warnings reported by Dan Carpenter https://lore.kernel.org/r/202603180509.nOQGZrG0-lkp@intel.com/ v7: - Addressed the two valid issues reported by AI (Jakub Kicinski). - Fixed minor issues reported by Alok Tiwari. - Addressed the concern of statistics duplication raised by Jakub Kicinski. A few statistics (discards/errors) have been made part of the standard netdev statistics and removed from ethtool -S. Additionally, a few statistics that require proper implementation have been removed and will be addressed in a later series, for example, get_pause_stats and get_fec_stats. https://lore.kernel.org/netdev/20260312192251.61243873@kernel.org/#t v6: - Resending the full series due to an SMTP failure during v5 submission. - No functional changes from v5. v5: Address Jakub Kicinski's comments by holding the instance lock across the entire service task (instead of flag-based locking) and checking the OPEN bit under the lock to resolve the close-path deadlock. v4: Addressed comments from Jakub Kicinski: - Explicitly size speed mask arrays to remove the need for manual sentinels in the hardware configuration. - Fix an off-by-one error in the queue index bound check. - Standardize ethtool -S per-ring stat naming to "rxq$id_$name" (e.g., rxq0_errors). Removed spaces and brackets to ensure compatibility with parsing scripts. - Exclude ethtool -S global counters (tx_err, tx_fifo_underruns, tx_total_collisions) already covered by rtnl_link_stats64. v3: Addressed comments from Andrew Lunn: - Fix a comment and refactor bnge_hwrm_set_pause() to improve code readability. Addressed comments from Jakub Kicinski: - Switch to RCU for stats synchronization and drop the BNGE_STATE_READ_STATS state bit. Fix checkpatch warning by switching to kzalloc_node(). v2: Addressed comments from Andrew Lunn: - Add implementation for .get_pauseparam and .set_pauseparam to support a full flow control configuration, covering global autoneg, independent pause autoneg, and forced RX/TX pause functionality. - Move MAC, PHY, Control, Pause, and RMON statistics from .get_ethtool_stats to their respective structured ethtool callbacks (e.g., .get_eth_mac_stats, .get_rmon_stats). Addressed comments from Jakub Kicinski: - Fix potential out-of-bounds read in speed mask array by adding the missing sentinel. - Simplify timer synchronization by removing the redundant intr_sem. - Replace link_lock with the netdev instance lock, as it is sufficient to handle the required synchronization. v1: https://lore.kernel.org/all/20260223163641.755200-1-bhargava.marreddy@broadcom.com/ Bhargava Marreddy (10): bng_en: add per-PF workqueue, timer, and slow-path task bng_en: query PHY capabilities and report link status bng_en: add ethtool link settings, get_link, and nway_reset bng_en: implement ethtool pauseparam operations bng_en: add support for link async events bng_en: add HW stats infra and structured ethtool ops bng_en: periodically fetch and accumulate hardware statistics bng_en: implement ndo_get_stats64 bng_en: implement netdev_stat_ops bng_en: add support for ethtool -S stats display drivers/net/ethernet/broadcom/bnge/Makefile | 3 +- drivers/net/ethernet/broadcom/bnge/bnge.h | 12 + .../net/ethernet/broadcom/bnge/bnge_core.c | 1 + .../net/ethernet/broadcom/bnge/bnge_ethtool.c | 723 +++++++++ .../ethernet/broadcom/bnge/bnge_hwrm_lib.c | 386 ++++- .../ethernet/broadcom/bnge/bnge_hwrm_lib.h | 8 + .../net/ethernet/broadcom/bnge/bnge_link.c | 1303 +++++++++++++++++ .../net/ethernet/broadcom/bnge/bnge_link.h | 204 +++ .../net/ethernet/broadcom/bnge/bnge_netdev.c | 597 +++++++- .../net/ethernet/broadcom/bnge/bnge_netdev.h | 87 +- .../net/ethernet/broadcom/bnge/bnge_txrx.c | 35 +- 11 files changed, 3340 insertions(+), 19 deletions(-) create mode 100644 drivers/net/ethernet/broadcom/bnge/bnge_link.c create mode 100644 drivers/net/ethernet/broadcom/bnge/bnge_link.h -- 2.47.1