From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 86339391E64 for ; Thu, 19 Mar 2026 23:35:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773963341; cv=none; b=jBDSjR8Jy24DyQLI+4n1ZOoiOjd1n3hEIlGsD5qVXr1G57J0W0JoXlxHlTT2m2ndtUFspzhxpZN2hDh+xveD8KNbPwSI/0zTynBfkFY14+8zzwKakTqPKZ8K895PKq87CIEpUAjPEFpFdS3EEPX2ggVKMAuBYTYiiimy8SrJNts= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773963341; c=relaxed/simple; bh=UanQDetlCjF/6zxJJeIw+AMEstzQ4BQpkXRP4oloNs0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=eRM/1XYZ+/QyuHTBIJTKgfGZSO5I6olKkewkRuVT0x95RGuloTCGZgvPGQROmuqrEjqeAo7lRjkUF6Lzfp3B9VstJlrW6b3kGibNz8iRK8U42jezTuLzAJKrf+M1cdJJwoedo3MufRUnCT6nxgymPtCLprfgJGALiI0iyokAK2Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=BtS+JnTJ; arc=none smtp.client-ip=209.85.214.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="BtS+JnTJ" Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-2b04c9e3eb7so35605ad.0 for ; Thu, 19 Mar 2026 16:35:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1773963338; x=1774568138; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=4QYZkwutITM3hY/BTKkAjdxJTuUr3dbbtbIB0hAX8jE=; b=BtS+JnTJu7dMFjgb0XmaqiRBy56iDqYrI6PlMNrDgpVHoMtlrH2aMKhcWQy92Z4ewi n5puP9+InkLigbVY1yOBCf1lYx2vbAP4oob3ieygn1WID7vdRAM/QiUbGWtXGD46+dw0 qguHZpFQqLjbpadSPaYm3cVAy2vyib1WImuqRs47GHKkAklMeQXau9mJB2Doaa/ZVT6y l+UR96sDp/MdA6+tCC75u54BIBroKg3qZS9tbckaK1tl19Ke4twCYu9BBYpN9IA2H3xK ojLG7eFQC4zXd6sw1M6R1o5RwxJoui+G89kHLEqXBf8lHZkd3zRSamIWtFgWO8XiKwdE 8Yzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773963338; x=1774568138; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4QYZkwutITM3hY/BTKkAjdxJTuUr3dbbtbIB0hAX8jE=; b=lcFYrBaPpADXW94MybjNlXiub+1kWTwRVD4tMmf4MfEUL7OdRI04ekGJ5SYEo1Fb64 AC+saPPpTlhWFc0jNVAmL/5DdFeevFpkuCPZZqhjt+eMT8jivOAO/YdFxSj+97kvK8Ei F088NGHtf/i51KuffnTAdftla/922fZNnOr4TGSCLsG0kK85hZ54N1uIFI8Wr6E5m6Or Vo5KXlVl6W7TpJFXc+MmyL9nQ97wko7TGO3JDBmTy/41BDEGWzCxZ8dE1cZjnRx4I+Xq BdIQ4NrChB60CNsCNxjKajL+DlYmenLE7JsGQDCLqDujfiLrFyX9WGg2dhEyA0jyhLZx HagA== X-Forwarded-Encrypted: i=1; AJvYcCWII9evmfle++4YjhymP25B4zS2WFnCDl/pSYyyUHOdRVfo9nLdyWpn5SYS1a+ImDIU4OtMEmnUEUSD3Uw=@vger.kernel.org X-Gm-Message-State: AOJu0YxZXtacvkXBcx12iP6yGiShwZMtt8omULoyvYXm3A+7CRxorB8r rjqC89K5L3Yc2nDp5S5ozEbf8XLSzBqbuc0sJorgGc4RE+7CRX0PetXS0yYzyCpo+Q== X-Gm-Gg: ATEYQzy+NxP55zTTwIhBEW14qyYV1lc4tDY3kwxD/ZK+BqrELI1VCQxaYzG55soWpvQ balVK9oa+d9WSzGoCo0v8/U6PuQeMc0hn1h8pOLZCxkvQ8p3q/XbaaQTzkEWJwZqk9oN0fXi5jS m+15SNke/njTLgNsZCbRmJA2B+Kc3a4BWN7AVflgFqmjsiP7TdXzZG2PmUQE0pEL4EzIsrtfj3O RaFLIvwmIyFeE1wth+TggTa4wqR25WpdswjTFTYF/U+R9MSjAy7SY+uNAnK8wUf1k0q1zGKlGTm pTFIMCDI99x8rJ0ic0jEQFxCxisXjJwcd2pv7eQxtGUqcqa4Dww+Efj84wefZFlVdLeGMPIP5Sd ELjUuduL92ON3ShYmMJIZjEMajaW6DQCdfG+Y83X8+IjVhw6Nx5/1YPrNO80Plky9MxIClC+Wb4 osHAOizKUq2uWf/Ds3iISNlNTy0hk8HSATZbeU1VfzmDhNeoM2TFDKTjPnR5NN X-Received: by 2002:a17:902:e805:b0:2ae:4808:bd99 with SMTP id d9443c01a7336-2b08285639amr1447705ad.2.1773963337286; Thu, 19 Mar 2026 16:35:37 -0700 (PDT) Received: from google.com (176.13.105.34.bc.googleusercontent.com. [34.105.13.176]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35bc5ff6789sm3845458a91.1.2026.03.19.16.35.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Mar 2026 16:35:36 -0700 (PDT) Date: Thu, 19 Mar 2026 16:35:32 -0700 From: Vipin Sharma To: Samiullah Khawaja Cc: David Woodhouse , Lu Baolu , Joerg Roedel , Will Deacon , Jason Gunthorpe , YiFei Zhu , Robin Murphy , Kevin Tian , Alex Williamson , Shuah Khan , iommu@lists.linux.dev, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, Saeed Mahameed , Adithya Jayachandran , Parav Pandit , Leon Romanovsky , William Tu , Pratyush Yadav , Pasha Tatashin , David Matlack , Andrew Morton , Chris Li , Pranjal Shrivastava Subject: Re: [PATCH 10/14] iommufd-lu: Implement ioctl to let userspace mark an HWPT to be preserved Message-ID: <20260319231331.GB3983821.vipinsh@google.com> References: <20260203220948.2176157-1-skhawaja@google.com> <20260203220948.2176157-11-skhawaja@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260203220948.2176157-11-skhawaja@google.com> On Tue, Feb 03, 2026 at 10:09:44PM +0000, Samiullah Khawaja wrote: > From: YiFei Zhu > @@ -374,6 +374,10 @@ struct iommufd_hwpt_paging { > bool auto_domain : 1; > bool enforce_cache_coherency : 1; > bool nest_parent : 1; > +#ifdef CONFIG_IOMMU_LIVEUPDATE > + bool lu_preserve : 1; > + u32 lu_token; Should we use full name i.e. liveupdate here and other places in this series? > diff --git a/drivers/iommu/iommufd/main.c b/drivers/iommu/iommufd/main.c > index 5cc4b08c25f5..e1a9b3051f65 100644 > --- a/drivers/iommu/iommufd/main.c > +++ b/drivers/iommu/iommufd/main.c > @@ -493,6 +493,8 @@ static const struct iommufd_ioctl_op iommufd_ioctl_ops[] = { > __reserved), > IOCTL_OP(IOMMU_VIOMMU_ALLOC, iommufd_viommu_alloc_ioctl, > struct iommu_viommu_alloc, out_viommu_id), > + IOCTL_OP(IOMMU_HWPT_LU_SET_PRESERVE, iommufd_hwpt_lu_set_preserve, > + struct iommu_hwpt_lu_set_preserve, hwpt_token), Shouldn't struct iommu_hwpt_lu_set_preserve{} be added to union ucmd_buffer{} above in this file?