From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3E0083CEB8B for ; Fri, 20 Mar 2026 16:04:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774022677; cv=none; b=bUMVcnTcfyLpHdV0NSnix7v/T2wKG01BpqkDVPZyoot2khuG7adPuDkTmr8xWS+3raQD6YrNFlSI+VRhkPmMZZFR/BOq5mUW2Q7mZ7HWGt9Scj7rsfy4rhkXiA00KYtBY8MV96yZuNq8GnpJmX4MsYCfIXDhvFY8WA/rK3im9ug= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774022677; c=relaxed/simple; bh=JptcxanHsB7Ba9fauiV8gm+KUKr1wrbn8O+ZDvxsI1U=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=HUPfMfMkMGNI6Jk+49NStkuCVjRTEMMXsFhn+mHbQRkCRmkYz/C5KcoBwlb47fRRyxXPqYkBeXV8/y/bi+C4ECxuu3tesXkWH48r58BPckadNw0tbjMclyNtY8a60lu67lnhLJ3j/3uMWtbFYTpirPhPzD6H/nP5OuJ/QRMR7us= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=jGDjP3Qt; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="jGDjP3Qt" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1774022674; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=CeFWF30cJFOlAu2FX7TnkDgLG4ViuaQJmdWgPCwTBjQ=; b=jGDjP3Qtx0ZDY0YDRJM8LutuaprbNge3VSkW1C7wA8n3YYj45DZT0qJvNb/FmQJ+3VpUk8 tJWC5NwoxOeSw3oeejtYwRYtGNFkmZrtF4behmPi0meCPp8PslJPLHhaicBnP/LCKqTMey IPmKQfPD7hzGq1j4JBuUy5zwPz6Kk08= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-450-ACC_PRoLONaKx1as4az1tg-1; Fri, 20 Mar 2026 12:04:30 -0400 X-MC-Unique: ACC_PRoLONaKx1as4az1tg-1 X-Mimecast-MFC-AGG-ID: ACC_PRoLONaKx1as4az1tg_1774022669 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id E2D6C195605E; Fri, 20 Mar 2026 16:04:28 +0000 (UTC) Received: from my-developer-toolbox-latest (unknown [10.2.16.140]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with SMTP id 80DE430001A1; Fri, 20 Mar 2026 16:04:25 +0000 (UTC) Date: Fri, 20 Mar 2026 09:04:24 -0700 From: Chris Leech To: alistair23@gmail.com Cc: hare@suse.de, kbusch@kernel.org, axboe@kernel.dk, hch@lst.de, sagi@grimberg.me, linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org, yjshin0438@gmail.com, Alistair Francis , Kamaljit Singh Subject: Re: [PATCH v4 2/2] nvme-auth: Don't propose NVME_AUTH_DHGROUP_NULL with SC_C Message-ID: <20260320-gallows-squealer-43a95debdd62@redhat.com> References: <20260320002045.1927526-1-alistair.francis@wdc.com> <20260320002045.1927526-2-alistair.francis@wdc.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260320002045.1927526-2-alistair.francis@wdc.com> X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 On Fri, Mar 20, 2026 at 10:20:45AM +1000, alistair23@gmail.com wrote: > From: Alistair Francis > > Section 8.3.4.5.2 of the NVMe 2.1 base spec states that > > """ > The 00h identifier shall not be proposed in an AUTH_Negotiate message > that requests secure channel concatenation (i.e., with the SC_C field > set to a non-zero value). > """ > > We need to ensure that we don't set the NVME_AUTH_DHGROUP_NULL idlist if > SC_C is set. > > Signed-off-by: Kamaljit Singh > Signed-off-by: Alistair Francis > Reviewed-by: Hannes Reinecke Looks good. Reviewed-by: Chris Leech