From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f173.google.com (mail-yw1-f173.google.com [209.85.128.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7D85E378D63 for ; Fri, 20 Mar 2026 23:07:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774048033; cv=none; b=dPCGiq12+51xyg1gjWCn6nfo3+puZmjaVjQayM+678QHimc67lKeoBHwkXyxhPDYPpOQPemPtZVQ7vDF3XtjM40wvS0F4XaOE+atIKqWZiHdDWPfqbG2ao0qdAMDLNork9/P6svFHiuMDnWXDQFyf7zOYYLTyujlv3lCVDW7tp4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774048033; c=relaxed/simple; bh=/xOopYFRCYcYFC1cEQcAs45V8mZtcpzGipALuKLSM5U=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=m7QJlv/egbFBJZyC1NOFMTN5in5AzlazZCwm2hQXOOdVNwTXWJEIFVX2s9POZ91FFqOc/mj1vnE9jMlSZY4VNQoCJIti1VjkQT3LCfy/rWazyJY82mQoh4rkk0+jJdCv0um6Mxzr7PXyZtys3JJrIL0u72o0851fQdZ2xRhtQhs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ei7WJE78; arc=none smtp.client-ip=209.85.128.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ei7WJE78" Received: by mail-yw1-f173.google.com with SMTP id 00721157ae682-7986fb839f5so26538547b3.0 for ; Fri, 20 Mar 2026 16:07:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1774048031; x=1774652831; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=a/AGxbL20S6dIlae3JMf3cMtITIBgBqCIllzp1bbe8g=; b=ei7WJE78SV1rbrKxK4iti9r8iTLm5TvwRLQ0jc1+N9gN4QglASbSyondfAF/ZjiOHb F+RW+zl9AX1iK1p+h+Bk8Be33RAzwfxgeC9gKzIXO19U0fARfw61PggPEo3xRllw9sEf mJVw15i3ptyxN0+nelsp38r2Ift9+gDxUaGQEljcEbi/YFiKYtElr1xsfxYqrsystE/E 0iBbjCSD214kSoVQFuAtkE0q9s4o08LeYgXNUgaYIKw1mAr30ng3BXqwcnUmN7lpKiNF eiI3gxfTkAqni5MQ2346mbtZPw8DDQmu57dKjjrTk4MLYN/vXK76wlPGtT/cia3gRGvM wzRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774048031; x=1774652831; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=a/AGxbL20S6dIlae3JMf3cMtITIBgBqCIllzp1bbe8g=; b=WLrCwkSMKgwFA5wPFUdxuSNR9bOxyiEfsO7SjmZM1zIhj+LFJ1S4r/sCBJR9IQkS0U ekTcGderqkgtL4BKV+ewpvnwiK+njVEwVF81z1jk/4JoPcMWjVn4SzT9YCMDQy9DVUIr Ju7+e5cdrSbAgHkwyBLWYoxoNnqOIellhfntgoIWLW2+VSZvuQ5fEdnp1jsRePK68Ap/ HcQ5+SMg2WUgVWgP1RKFHymfcSo6I3kjusAnC93uGM3CMJTgCNyy5LcJeIdNPQh+mHSV KuNPEaPRY8/1r2AVV5RBQp9bJH+Wyi3gEr56eexAhLzHvDj3aMV4m0V4uk6/fEZRmfbZ 7uAw== X-Forwarded-Encrypted: i=1; AJvYcCW7mGhLf3/XfTUmApgPfJDwUSgkq+2/ktatMRlmbjFQCRs4K9XHLmtqM6Piux7AZho3E2FFfbYUaSI5Qh0=@vger.kernel.org X-Gm-Message-State: AOJu0YynSLJiQNGOt+2iMOtXIkWUcoZUnzMc56JcfHgJUhguc2JUsvo7 QdwD2jmZPklEv11HfRNk3kWdRNYgxhayUr+vm+8TX6oDJL07ZEvaMT7s X-Gm-Gg: ATEYQzxWOruQScziS16OPeZvTRkhxdmwQORV5sG/5PgLmKrVMyiNLHL9BhwIKKJFe62 ZIHr4gX192/qvxvVkBg6dalaX0cctFE+7AE5hRBQV6iRu9KRkpTAoQI3grNKHgWgAja3Rcb8mAc 3z+IINyoSoNDAFRt8LgHEg9cFP7+X2bq3MEwmkX+ReBK/orZQ48YY/boWIaxRbnjLLOUq5TB0Ne hJOrMBDEfCYxEocoRkOoWsCK8zdCyw860yw0CLSWuAkqvr5KJ9QeRUd4SCmP5PAUbTmSKchvAFK 5JEpP8ERMw1gV24k6ByhnpUkJbPR1+vyLGLVMMwg5Ki6pJCe5ODSQjHhwy2TM0K/9NIFlZdBKKD yI3q3lb9Z063gyucMvj8nCeIUrEHXFZ3SuWbNUp/gn19rdxUdt3ZuYpRJmdrKC4uc+4oOByQfID 0mb0wI5gw3lfdPi6i6vw+NyChb8qUbIGLIinKSRlotxXo7WIclJQ== X-Received: by 2002:a05:690c:c4e8:b0:79a:3a33:94f with SMTP id 00721157ae682-79a90be783cmr53568687b3.48.1774048031372; Fri, 20 Mar 2026 16:07:11 -0700 (PDT) Received: from Starblazer007.localdomain ([12.206.154.114]) by smtp.gmail.com with ESMTPSA id 00721157ae682-79a90580d7csm23142097b3.37.2026.03.20.16.07.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Mar 2026 16:07:10 -0700 (PDT) From: Nelson Johnson To: andriy.shevchenko@intel.com, hansg@kernel.org Cc: adrian.hunter@intel.com, ulf.hansson@linaro.org, linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org Subject: Re: [PATCH 0/3] mmc: Lenovo N22 Braswell SD slot fixes Date: Fri, 20 Mar 2026 18:07:06 -0500 Message-ID: <20260320230707.3122-1-nzjfr547@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit On Fri, Mar 20, 2026 at 07:08:41PM +0100, Andy Shevchenko wrote: > Can you share ACPI DSDT excerpt (from DSDT table of firmware, you can > get it by copying file from /sys/firmware/acpi/tables/DSDT and decode > it with `iasl -d DSDT`) and output of `lspci -vv -n -s $SDHCI_SLOT`? > Because it might be that the problem should be solved just by providing > better fixes to GPIO detection or so. Here is the requested data collected from the N22 on a vanilla 6.19.6+deb14+1-amd64 kernel with no patches applied. DSDT INT33BB section (decoded from /sys/firmware/acpi/tables/DSDT): Name (_HID, "INT33BB") Name (_CID, "PNP0D40") Name (_DDN, "Intel(R) SDIO Controller - 80862295") Name (_UID, 0x02) Name (_HRV, 0x02) Name (_DEP, Package (0x01) { GPO1 }) Name (ABUF, ResourceTemplate () { Memory32Fixed (ReadWrite, 0x00000000, 0x00001000, _Y04) Interrupt (ResourceConsumer, Level, ActiveLow, Exclusive) { 0x0000002E } GpioIo (Exclusive, PullNone, 0x0000, 0x0000, IoRestrictionOutputOnly, "\\_SB.GPO1", 0x00, ResourceConsumer, ,) { 0x0005 } }) Method (_PS0, 0, NotSerialized) { PSAT &= 0xFFFFFFFC PSAT |= Zero If ((PSTS == Zero)) { If ((^^^GPO1.AVBL == One)) { ^^^GPO1.CWLE = One } PSTS = One } } Method (_PS3, 0, NotSerialized) { PSAT |= 0x03 PSAT |= Zero } Two things stand out in this description. First, the _DDN names the device as "Intel(R) SDIO Controller - 80862295" rather than an SD slot, and _UID is 0x02; in current sdhci-acpi.c, INT33BB UID 2 maps to the SDIO slot profile rather than the removable SD profile. Second, the GpioIo descriptor for pin 5 on GPO1 is IoRestrictionOutputOnly with PullNone. My reading of the AML is that this looks more like an enable/control line than a card-detect input, but that is an inference from the firmware description rather than something I can prove from the AML alone. lspci -vv -n -s 0000:00:12.0 on vanilla kernel: 00:12.0 0805: 8086:2296 (rev 21) (prog-if 01) Subsystem: 17aa:3807 Control: I/O- Mem+ BusMaster- SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B- DisINTx- Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort- SERR-