From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 571933DFC6C for ; Fri, 20 Mar 2026 23:56:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774050979; cv=none; b=SnHhSerVqbcGYAirhwKb7QCSX+ngGv+/XUg1kTPyi6Fhlj3d0IKvd+TsmXArFbHRjZdYhFJqOTP3SD3zb3xXsy9xvyY8idfG4nf+BLyN1YM4f3bClAhUdWsmYZfSch0c/K0HllsXIH7a6YzsBzK05Jf1RfcSwe+2GLgi/5e0Dww= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774050979; c=relaxed/simple; bh=4Qv0ASzBZ/GHMP/cF0uuMSr/kHt3nxx/rYtASmNluvQ=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=VNWEuCYghV6v31QvfwP7xTxxT7WxW3YoAF9NQJx/cWMlJU3RFV27Yw91q0l8jlHF2vwTPK4f80112FgxmdxO1bsxttM1i54bS/biziKIShFS/SYmz3wUcl3Ml8drNsSzHWzhve5Mm38BmHc1ptgKoBmokNVQYLg8D5iyCSOYe6E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=AcPvy8ac; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="AcPvy8ac" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-483ad568d68so3620155e9.2 for ; Fri, 20 Mar 2026 16:56:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1774050964; x=1774655764; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=5s66dB2mGXA70emn3wqJCYnvCXFNfAd0Dr6Dg6TLwxg=; b=AcPvy8acuYWP1a41E9CeXTw9E0E/ePVYW45oBAgslDaj11aMP1v/pmcGKiqWPWjHo4 ExYwf4xlP2p7xT4k8UNtnc2HO0ZCb6tlxyoyUBiAA07pGBkBDlO93ln1NSiFVpI/S4DD qvdmdegX/a5AFWRK0q4QfBOEI6mIT/EJ5UybTdbiaJxF8dDOhsDPjR32X9/yauPfyDjF eOcZCNB/nL+4c1jAl8w1u+bE4YA+qJwQ8k1CZ5EwGgDA9Cja/FxDJfFHzOnVulWyonbw VUK4ZmLcggw6sxnCFQTgAytRdCfpDfo2uVESYKbvBf5sRLxXeaMv0tcLuxaM91lyi8d0 TnjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774050964; x=1774655764; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=5s66dB2mGXA70emn3wqJCYnvCXFNfAd0Dr6Dg6TLwxg=; b=aOpZbOO7pVbudFalRqrFO1X1ZBlXrx9dLX/vWylFdNyqWeu/WhX7s9n0dfPihlINl0 hUi8JMWNSkf7CiGxOPr9rbqCQBz5BM2BO+FoTYyhoN74CebKTUnLYveGbVAGHr809beC 57ynlmQcR6jz02lDVBnVqmt8/J4CF93WnejwqDFDacB+POHa2bGmuApWltWpWezUZqBP RlBQbR1i9RkMizAHz9bNI5JiPUkgwLXJePFuGy3MBUQU9nms7UjedIS/0uiqgAUPx8kR 6YYORR0yDXQ8pvsFp92zSdpqm/3ZWtM9/jW7MoslEtP1JI4IHZIEyb2qaBzoeUPnT/SO a+hA== X-Forwarded-Encrypted: i=1; AJvYcCWepg8N1FvlAfjjuyMpwJ1jg0RhgGdvUFaIki9Ruefl0drnOCowNn0F3g34bV0gtCQTlUZmFTa5IOxptPU=@vger.kernel.org X-Gm-Message-State: AOJu0YxLmGjZX3H9yCTRTn6vLc4/yxVxyXQ741t6HSOWuOjsfcTO/n63 UXxL6hKDM2eKa94TMi1hMX3snK4zW59slCwmEHeBoSSUehdbTUjfVSvp X-Gm-Gg: ATEYQzxq3KMfSghC1xsbotMdrdqoYsxxm92RQHcnb9Pnc6maNVQXCLsuN2PZ471aPs7 VE5eoeOrzsIVE8xPkdyIN1h20kFnB2V2mVbiZmEz5ezwpjFTQLjPOTaD7VnveQvEvt16LSlXMYx Wl+lcl1lBev9wcA2M5s8SD60jVxcsubcVkTdbCrKGjvTs1iD42E3KX5JvX4UsEX+Zzjb6plRkM5 K2CKURUmzHOtPALxVgZms74sEcmSx+JTSsdZanJng4ZYLlOb9FJ9MsrSRmjnqkTWB+jjXXDjMX8 gfJl8t7B76za5+9xelqPqnO1i9JtN8PO9jQ8a/2PMylsNrP2u7AZPKXlUl4OyRovpGajjXTOH2Q mRPhlUoyjhJFqROQBuqvi98lhKLOcT77FkaufemqmMjPbynZqCo3nSWzgAtmSNKBXs3AkFQ8QB2 2FypBd7jovF2QjRSVCuoaqQbwTHbrwCgKElrYd5NRCgSIFsw== X-Received: by 2002:adf:9d88:0:b0:43b:60dc:d9bb with SMTP id ffacd0b85a97d-43b63fea120mr3488270f8f.0.1774050964161; Fri, 20 Mar 2026 16:56:04 -0700 (PDT) Received: from fridge ([195.174.58.89]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43b6470c239sm9663418f8f.27.2026.03.20.16.56.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Mar 2026 16:56:03 -0700 (PDT) From: Emre Cecanpunar To: platform-driver-x86@vger.kernel.org Cc: hansg@kernel.org, ilpo.jarvinen@linux.intel.com, krishna.chomal108@gmail.com, linux-kernel@vger.kernel.org, Emre Cecanpunar Subject: [PATCH 0/5] platform/x86: hp-wmi: fix bugs in Victus S fan control Date: Sat, 21 Mar 2026 02:55:52 +0300 Message-ID: <20260320235557.56298-1-emreleno@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This series fixes five bugs in the hwmon fan control code added for HP Victus S laptops: - Return values from WMI calls were silently discarded in two paths of hp_wmi_apply_fan_settings(), and the function's own return value was ignored by both of its callers. - cancel_delayed_work_sync() was called from inside the work handler it was trying to cancel, causing a potential deadlock. - schedule_delayed_work() does not reset a pending timer, so rapid back-to-back fan updates did not extend the keep-alive window. - u8 arithmetic was used to compute a signed delta, producing silent unsigned wrap-around on malformed firmware fan tables. - mode and pwm fields in hp_wmi_hwmon_priv were accessed from both sysfs and workqueue context without any synchronisation. Patches are ordered so that each one applies cleanly on top of the previous. Patches 1-4 are independent fixes; patch 5 (locking) builds on patch 2 (cancel_delayed_work) to avoid a lock-ordering issue. Emre Cecanpunar (5): platform/x86: hp-wmi: fix ignored return values in fan settings platform/x86: hp-wmi: avoid cancel_delayed_work_sync from work handler platform/x86: hp-wmi: use mod_delayed_work to reset keep-alive timer platform/x86: hp-wmi: fix u8 underflow in gpu_delta calculation platform/x86: hp-wmi: add locking for concurrent hwmon access drivers/platform/x86/hp/hp-wmi.c | 59 ++++++++++++++++++++++---------- 1 file changed, 41 insertions(+), 18 deletions(-) -- 2.53.0