From: Jonathan Cameron <jic23@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@intel.com>
Cc: "David Lechner" <dlechner@baylibre.com>,
"Christian Eggers" <ceggers@arri.de>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: light: as73211: remove duplicate zero init of scan.chan[3]
Date: Sat, 21 Mar 2026 19:36:42 +0000 [thread overview]
Message-ID: <20260321193642.70052085@jic23-huawei> (raw)
In-Reply-To: <abgLFt_-OehTEWgb@ashevche-desk.local>
On Mon, 16 Mar 2026 15:52:22 +0200
Andy Shevchenko <andriy.shevchenko@intel.com> wrote:
> On Sun, Mar 15, 2026 at 02:21:51PM -0500, David Lechner wrote:
> > Remove setting scan.chan[3] to zero. Since commit 433b99e92294 ("iio:
> > light: as73211: Ensure buffer holes are zeroed"), the entire scan struct
> > is zeroed before being filled with data, so this is redundant.
>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
>
> ...
>
> > static irqreturn_t as73211_trigger_handler(int irq __always_unused, void *p)
>
> > (char *)&scan.chan[0], 3 * sizeof(scan.chan[0]));
>
> Side note: the above looks like a room to improve.
>
Applied. Indeed that's an ugly line!
Thanks,
Jonathan
prev parent reply other threads:[~2026-03-21 19:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-15 19:21 David Lechner
2026-03-16 13:52 ` Andy Shevchenko
2026-03-21 19:36 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260321193642.70052085@jic23-huawei \
--to=jic23@kernel.org \
--cc=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=ceggers@arri.de \
--cc=dlechner@baylibre.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®