From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A1471363096 for ; Sun, 22 Mar 2026 16:38:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774197481; cv=none; b=gJAZIK6+A0wQ/UNdAO+ZeEwRBMRm1+pqp8GQ89Ak/LPdBBTJGWYErQTLIVPm5+jTPJwXLvq9vyOHPQ/szfzBSK3/VfSaJ5SlN5ddJrhUfHHEOlNtZtWWTGfsB3FO0DmykaAafnxfd3896qNuF9UKJS6Au6ZF8wf8FMpbcatD8MI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774197481; c=relaxed/simple; bh=Sdszyg23QUequRorJfJ8eCM3MpMl3LmBaD9hHrjRhUM=; h=Date:From:To:Cc:Subject:Message-Id:In-Reply-To:References: Mime-Version:Content-Type; b=iN52xpVKatWclaGfvGYTjcxOMzAonPo+t4xcGpMbAfudWNTD0DEkRXAF5wi/E4/KUMBWL7swKKVfKY3WoqbDyvb7wZ/2IrExlpXzY9H9Yy2NjswM4qS7PAOahpWpNdJjUd6EMy/W4/rRkOhnZnO6DqnSe/EjFBCApkuFbdw24eg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b=dOhov4a1; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="dOhov4a1" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C59FCC19424; Sun, 22 Mar 2026 16:38:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1774197481; bh=Sdszyg23QUequRorJfJ8eCM3MpMl3LmBaD9hHrjRhUM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=dOhov4a1sDuQj5+1MN212N1TAo/J3qkxJjmYWZEUVkZdlG3PDOPmns7doRb+wDXyt aaqomisAHnfyYTgwx2obNU7EXOTh2fY7t613Nb5wV7KirPf4XsrPtZUJaR0OZwV8Q/ Zk10b5lxAWO1geVx8TzUzfX3qIG6zOHDE/ENZzZA= Date: Sun, 22 Mar 2026 09:38:00 -0700 From: Andrew Morton To: Mike Rapoport Cc: David Hildenbrand , Kees Cook , "Liam R. Howlett" , Lorenzo Stoakes , Michal Hocko , Suren Baghdasaryan , Vlastimil Babka , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH] memblock: move reserve_bootmem_range() to memblock.c and make it static Message-Id: <20260322093800.27f8b2d249817270bcc6a437@linux-foundation.org> In-Reply-To: <20260322143144.3540679-1-rppt@kernel.org> References: <20260322143144.3540679-1-rppt@kernel.org> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Sun, 22 Mar 2026 16:31:44 +0200 Mike Rapoport wrote: > reserve_bootmem_range() is only called from memmap_init_reserved_pages() > and it was in mm/mm_init.c because of its dependecies on static > init_deferred_pages(). > > Since init_deferred_pages() is not static anymore, move > reserve_bootmem_range(), rename it to memmap_init_reserved_range() and > make it static. > > Update the comment describing it to better reflect what the function > does and drop bogus comment about reserved pages in free_bootmem_page(). > > Update memblock test stubs to reflect the core changes. Some minor observations from Sashiko: https://sashiko.dev/#/patchset/20260322143144.3540679-1-rppt@kernel.org