From: Suraj Sonawane <surajsonawane0215@gmail.com>
To: Dave Stevenson <dave.stevenson@raspberrypi.com>,
Jacopo Mondi <jacopo@jmondi.org>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
Suraj Sonawane <surajsonawane0215@gmail.com>
Subject: [PATCH] media: i2c: ov5647: handle V4L2_CID_LINK_FREQ in s_ctrl
Date: Sun, 22 Mar 2026 19:23:48 +0530 [thread overview]
Message-ID: <20260322135348.11339-1-surajsonawane0215@gmail.com> (raw)
Handle V4L2_CID_LINK_FREQ in ov5647_s_ctrl().
Currently this control is defined but not handled in s_ctrl(),
so V4L2 falls back to estimating link frequency from pixel rate
and prints warning like:
v4l2_get_link_freq: Link frequency estimated using pixel rate:
result might be inaccurate
v4l2_get_link_freq: Consider implementing support for V4L2_CID_LINK_FREQ
in the transmitter driver
Handle it as no-op since link frequency is fixed per mode and
not meant to be changed at runtime.
Avoid these warnings when control is queried.
Signed-off-by: Suraj Sonawane <surajsonawane0215@gmail.com>
---
drivers/media/i2c/ov5647.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/media/i2c/ov5647.c b/drivers/media/i2c/ov5647.c
index 6a46ef723..a5a9cff5a 100644
--- a/drivers/media/i2c/ov5647.c
+++ b/drivers/media/i2c/ov5647.c
@@ -999,6 +999,9 @@ static int ov5647_s_ctrl(struct v4l2_ctrl *ctrl)
ret = cci_write(sensor->regmap, OV5647_REG_HTS,
sensor->mode->format.width + ctrl->val, &ret);
break;
+ case V4L2_CID_LINK_FREQ:
+ ret = 0;
+ break;
case V4L2_CID_TEST_PATTERN:
ret = cci_write(sensor->regmap, OV5647_REG_ISPCTRL3D,
ov5647_test_pattern_val[ctrl->val], NULL);
--
2.34.1
next reply other threads:[~2026-03-22 13:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-22 13:53 Suraj Sonawane [this message]
2026-03-22 22:43 ` Sakari Ailus
2026-03-23 15:37 ` Dave Stevenson
2026-03-23 18:44 ` Jacopo Mondi
2026-03-24 9:38 ` Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260322135348.11339-1-surajsonawane0215@gmail.com \
--to=surajsonawane0215@gmail.com \
--cc=dave.stevenson@raspberrypi.com \
--cc=jacopo@jmondi.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®