From: Shrikanth Hegde <sshegde@linux.ibm.com>
To: mingo@kernel.org, peterz@infradead.org,
vincent.guittot@linaro.org, linux-kernel@vger.kernel.org
Cc: sshegde@linux.ibm.com, kprateek.nayak@amd.com,
juri.lelli@redhat.com, vschneid@redhat.com, rostedt@goodmis.org,
dietmar.eggemann@arm.com
Subject: [PATCH] sched/fair: Fix stale comments around nohz.nr_cpus
Date: Mon, 23 Mar 2026 10:59:09 +0530 [thread overview]
Message-ID: <20260323052909.561337-1-sshegde@linux.ibm.com> (raw)
nohz.nr_cpus has been removed. Update those stale comments around it.
Fixes: 5d86d542f68f ("sched/fair: Remove nohz.nr_cpus and use weight of cpumask instead")
Signed-off-by: Shrikanth Hegde <sshegde@linux.ibm.com>
---
Broke it off from v1, since that would need a larger rework.
v1: https://lore.kernel.org/all/20260319065314.343932-1-sshegde@linux.ibm.com/
kernel/sched/fair.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index b19aeaa51ebc..a24a7cf0fc1d 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -12720,13 +12720,14 @@ static void nohz_balancer_kick(struct rq *rq)
flags = NOHZ_STATS_KICK;
/*
- * Most of the time system is not 100% busy. i.e nohz.nr_cpus > 0
+ * Most of the time system is not 100% busy. i.e number of CPUs in
+ * nohz.idle_cpus_mask > 0
* Skip the read if time is not due.
*
* If none are in tickless mode, there maybe a narrow window
* (28 jiffies, HZ=1000) where flags maybe set and kick_ilb called.
* But idle load balancing is not done as find_new_ilb fails.
- * That's very rare. So read nohz.nr_cpus only if time is due.
+ * That's very rare. So read nohz.idle_cpus_mask only if time is due.
*/
if (time_before(now, nohz.next_balance))
goto out;
--
2.47.3
next reply other threads:[~2026-03-23 5:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-23 5:29 Shrikanth Hegde [this message]
2026-03-27 16:13 ` Valentin Schneider
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260323052909.561337-1-sshegde@linux.ibm.com \
--to=sshegde@linux.ibm.com \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=kprateek.nayak@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®