From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 81C97317148 for ; Mon, 23 Mar 2026 10:59:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774263544; cv=none; b=S+4cAh1Fj3K9GqWsreXfVlde3fnLvMWmn2mQmhy+h0qu64xxJDmpooO60MdvwmXdW8KkfEwljVHbu+v8J+ZWlIkLX+kkTfTLIzTPOnUpDHqcRZixJxgFhG6pAhwyvOULhMydKj14j/zM31B9fLvyXiwgl6KsdefXHWyxcBSdngM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774263544; c=relaxed/simple; bh=+Bd6+Lx4AgAL434TvqT8Dady7/7L8GjbdZDaJJksyaQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=oEVz/XaL4cg73gW4wk4k96CGZkwNxn6ouambPh1sgdSCRqekGyCv3bHxqWrQyjppZUJZmhKh5GbRaFc2vASNo1oiXXMpmLSx4Rc931NJEq+ui7K3XuufhhtuR31czjC0SeUmc1b9qpzO2lJfSW4VGuU02ik8ehAXyKscyFbn8fU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=c/RGADMa; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="c/RGADMa" Received: from killaraus.ideasonboard.com (2001-14ba-703d-e500--2a1.rev.dnainternet.fi [IPv6:2001:14ba:703d:e500::2a1]) by perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id F2673591; Mon, 23 Mar 2026 11:57:43 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1774263464; bh=+Bd6+Lx4AgAL434TvqT8Dady7/7L8GjbdZDaJJksyaQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=c/RGADMaQVPpqspjvHnPzRBjp0mdg0gw6dYwqqRxCYyojhyVCUtTto07fYH+qwzom CsalWK5VP55xZYcVorP+3iV+e/gLPdpISfFyRuLcYeyoOB6HCdLuCAp51xPEtwJ4zG mRuQJdrZUeiGyeLUk+Z9xyCujll6GyQqJKQ9QVrk= Date: Mon, 23 Mar 2026 12:58:58 +0200 From: Laurent Pinchart To: Mark Brown Cc: "Peng Fan (OSS)" , Liam Girdwood , Frieder Schrempf , Joy Zou , linux-kernel@vger.kernel.org, Peng Fan Subject: Re: [PATCH 1/2] regulator: pca9450: Correct interrupt type Message-ID: <20260323105858.GA2185714@killaraus.ideasonboard.com> References: <20260310-pca9450-irq-v1-0-36adf52c2c55@nxp.com> <20260310-pca9450-irq-v1-1-36adf52c2c55@nxp.com> <28dad7ac-3f09-4f0a-a9f9-cfe329f8670a@sirena.org.uk> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <28dad7ac-3f09-4f0a-a9f9-cfe329f8670a@sirena.org.uk> On Tue, Mar 10, 2026 at 01:15:34PM +0000, Mark Brown wrote: > On Tue, Mar 10, 2026 at 12:25:52PM +0800, Peng Fan (OSS) wrote: > > From: Peng Fan > > > > Kernel warning on i.MX8MP-EVK when doing module test: > > irq: type mismatch, failed to map hwirq-3 for gpio@30200000! > > > > Per PCA945[X] specification: The IRQ_B pin is pulled low when any unmasked > > interrupt bit status is changed and it is released high once application > > processor read INT1 register. > > > > So the interrupt should be configured as IRQF_TRIGGER_LOW, not > > IRQF_TRIGGER_FALLING. > > There appear to be a bunch of DTS files which specify edge triggered > interrupts for these devices (eg, imx8mm-emtop-som.dtsi and > imx8mp-debix-model-a.dts) though more getting it right. Not an issue > for this patch but probably wants cleaning up. This patch creates an interrupt storm on the i.MX8MP-based Debix Model A board. I'm getting about 700 interrupts per second from the PMIC (and about 3000 interrupts per second from the I2C controller). arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts specifies the PMIC interrupt as IRQ_TYPE_EDGE_RISING, setting it to IRQ_TYPE_LEVEL_LOW does not help. Peng, I can run test to debug the issue if you tell me what to test. I'd like to fix the problem and avoid an annoying regression in v7.0, either with a follow-up patch, or with a revert if we're too short on time. -- Regards, Laurent Pinchart