mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: "Arnd Bergmann" <arnd@arndb.de>
Cc: "Brendan Jackman" <jackmanb@google.com>,
	"Arnd Bergmann" <arnd@kernel.org>,
	"Nathan Chancellor" <nathan@kernel.org>,
	"Peter Zijlstra" <peterz@infradead.org>,
	"Ingo Molnar" <mingo@kernel.org>,
	"Nick Desaulniers" <nick.desaulniers+lkml@gmail.com>,
	"Bill Wendling" <morbo@google.com>,
	"Justin Stitt" <justinstitt@google.com>,
	linux-kernel@vger.kernel.org, llvm@lists.linux.dev,
	andriy.shevchenko@linux.intel.com
Subject: Re: [PATCH] bug: shut up format attribute warning for clang as well
Date: Mon, 23 Mar 2026 13:45:40 -0700	[thread overview]
Message-ID: <20260323134540.5de3cf098cc9858486462f08@linux-foundation.org> (raw)
In-Reply-To: <cf40b3d8-9a69-40b7-b885-aff87e85de68@app.fastmail.com>

On Mon, 23 Mar 2026 16:38:14 +0100 "Arnd Bergmann" <arnd@arndb.de> wrote:

> On Mon, Mar 23, 2026, at 11:54, Brendan Jackman wrote:
> > On Fri Mar 20, 2026 at 9:14 PM UTC, Arnd Bergmann wrote:
> >
> > There is actually a superior fix for this warning that Andy Schevchenko
> > posted here (mine just happened to get merged first):
> >
> > https://lore.kernel.org/all/20251208141618.2805983-1-andriy.shevchenko@linux.intel.com/T/#u
> >
> > Should we just switch over to that? Looks like it should work for both
> > compilers.
> 
> Right, I tried that again and it works. I had confused it with the
> similar logic to disable the warning on va_format(), which is
> not that easy to avoid.
> 

What I think I'm hearing is that we should revert Brendan's
d36067d6ea00 ("bug: Hush suggest-attribute=format for __warn_printf()")
then apply Andy's
https://lore.kernel.org/all/20251208141618.2805983-1-andriy.shevchenko@linux.intel.com/T/#u,
yes?

Could someone please prepare a suitably changelogged and tested patch
for that?

  reply	other threads:[~2026-03-23 20:45 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-20 21:14 Arnd Bergmann
2026-03-21  0:08 ` Nathan Chancellor
2026-03-23 10:54 ` Brendan Jackman
2026-03-23 15:38   ` Arnd Bergmann
2026-03-23 20:45     ` Andrew Morton [this message]
2026-03-23 20:56       ` Arnd Bergmann
2026-03-24 11:26         ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260323134540.5de3cf098cc9858486462f08@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=arnd@arndb.de \
    --cc=arnd@kernel.org \
    --cc=jackmanb@google.com \
    --cc=justinstitt@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=llvm@lists.linux.dev \
    --cc=mingo@kernel.org \
    --cc=morbo@google.com \
    --cc=nathan@kernel.org \
    --cc=nick.desaulniers+lkml@gmail.com \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®