From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8DEF4154425
	for <linux-kernel@vger.kernel.org>; Mon, 23 Mar 2026 22:29:46 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1774304986; cv=none; b=fxm3koaby0U0gDnZNTcJS/+aUZ+w5Tk/0/1uewyQ+Te0b2UajxGdcxI4+ahepdl8v+F0Uf1HmcFK86rDIU2wNeRnwRR83FsCT31I61iBz9PeUDC2ebNjxg+BV3LZQKtwHnAz5s1PeN9W6jylMGzFSsSjf9MdPZ6LTsc7zBjQnlw=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1774304986; c=relaxed/simple;
	bh=wYGlFzTL5gzNqKe66BjkJuzWF5ZBkDGj2lJjld3GkPs=;
	h=Date:From:To:Cc:Subject:Message-Id:In-Reply-To:References:
	 Mime-Version:Content-Type; b=L3UFkJp4aGbJgVV44d7gfB0a9iZgLEy0xu8Gnn/XZyWYAQYOGPvUQN67rhXMCd/54XUKG64arkEwAQbS9MIZqec5XxvTjJxByEZoysC7Og0uEHJmkJ8yOLCIyknveTf9isnk0FvCxH6c2Hrb09hsAouAg/lz1RqdKjYGmzelZQ4=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b=ACB3aBDM; arc=none smtp.client-ip=10.30.226.201
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="ACB3aBDM"
Received: by smtp.kernel.org (Postfix) with ESMTPSA id C621BC4CEF7;
	Mon, 23 Mar 2026 22:29:45 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org;
	s=korg; t=1774304986;
	bh=wYGlFzTL5gzNqKe66BjkJuzWF5ZBkDGj2lJjld3GkPs=;
	h=Date:From:To:Cc:Subject:In-Reply-To:References:From;
	b=ACB3aBDMLm+j0kgUbd/TnDsPm4m2n9nBksojJNcAl+kPz4tV2JmUXAFeUSDmb3VHq
	 78p9M15ZisS41nGMO66ljL8/tFdLyMH41fdFxvdAPPHGhUNo7Z/XduWgrQjmxic5Cb
	 XkhgwkTL0C8URvW5BHokd8+5t33pYcNPKJQzk+yE=
Date: Mon, 23 Mar 2026 15:29:45 -0700
From: Andrew Morton <akpm@linux-foundation.org>
To: Osama Abdelkader <osama.abdelkader@gmail.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>, Will Deacon
 <will@kernel.org>, Kees Cook <kees@kernel.org>, "Liam R. Howlett"
 <Liam.Howlett@oracle.com>, Jeff Xu <jeffxu@chromium.org>,
 linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: vdso: fix AArch32 compat init allocation leaks
Message-Id: <20260323152945.e3626b741d28e3db526d9413@linux-foundation.org>
In-Reply-To: <20260323214117.241216-1-osama.abdelkader@gmail.com>
References: <20260323214117.241216-1-osama.abdelkader@gmail.com>
X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu)
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Mon, 23 Mar 2026 22:41:16 +0100 Osama Abdelkader <osama.abdelkader@gmail.com> wrote:

> aarch32_alloc_vdso_pages() allocates the AA32 vdso pagelist, the compat
> sigpage, then the kuser vectors page. If aarch32_alloc_sigpage() or
> aarch32_alloc_kuser_vdso_page() fails, earlier allocations were not freed.
> 
> Unwind in reverse order: drop the sigpage when kuser setup fails, and
> kfree the vdso pagelist when either later step fails (only when
> CONFIG_COMPAT_VDSO allocated it).

Thanks.  AI review has flagged a couple of possible issues:
	https://sashiko.dev/#/patchset/20260323214117.241216-1-osama.abdelkader@gmail.com