From: Borislav Petkov <bp@alien8.de>
To: Tycho Andersen <tycho@kernel.org>
Cc: Thomas Gleixner <tglx@kernel.org>, Ingo Molnar <mingo@redhat.com>,
Dave Hansen <dave.hansen@linux.intel.com>,
x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
Ashish Kalra <ashish.kalra@amd.com>,
Tom Lendacky <thomas.lendacky@amd.com>,
John Allen <john.allen@amd.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>,
Ard Biesheuvel <ardb@kernel.org>,
Neeraj Upadhyay <Neeraj.Upadhyay@amd.com>,
Kishon Vijay Abraham I <kvijayab@amd.com>,
Alexey Kardashevskiy <aik@amd.com>,
Nikunj A Dadhania <nikunj@amd.com>,
"Peter Zijlstra (Intel)" <peterz@infradead.org>,
Kim Phillips <kim.phillips@amd.com>,
Sean Christopherson <seanjc@google.com>,
linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org
Subject: Re: [PATCH v3 3/7] x86/snp: create snp_x86_shutdown()
Date: Mon, 23 Mar 2026 16:44:17 +0100 [thread overview]
Message-ID: <20260323154417.GAacFf0X_UGizsaORY@fat_crate.local> (raw)
In-Reply-To: <acFczQda7Xsx4oJg@tycho.pizza>
On Mon, Mar 23, 2026 at 09:31:25AM -0600, Tycho Andersen wrote:
> :) I can add a macro for this. Let me know if you want a full args
> struct instead.
"ew" meant: this is not nice but I don't have a better idea...
A full args struct doesn't really change anything AFAICT. Maybe play with it
a bit and see what the resulting asm is but I'm sceptical it would be any
different...
> My intent here was to indicate that it's doing the x86 (i.e.
> non-firmware) parts of the SNP shutdown process. I will change it to
> just snp_shutdown(), but that will still have a prefix. Just
> shutdown() seemed to generic...
Yeah, snp_shutdown() - just one prefix :) - is enough.
Thx.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2026-03-23 15:44 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-17 16:21 [PATCH v3 0/7] Move SNP initialization to the CCP driver Tycho Andersen
2026-03-17 16:21 ` [PATCH v3 1/7] x86/snp: Create a function to clear/zero the RMP Tycho Andersen
2026-03-17 16:21 ` [PATCH v3 2/7] x86/snp: create snp_prepare_for_snp_init() Tycho Andersen
2026-03-21 16:45 ` Borislav Petkov
2026-03-17 16:21 ` [PATCH v3 3/7] x86/snp: create snp_x86_shutdown() Tycho Andersen
2026-03-21 17:05 ` Borislav Petkov
2026-03-23 15:31 ` Tycho Andersen
2026-03-23 15:44 ` Borislav Petkov [this message]
2026-03-17 16:21 ` [PATCH v3 4/7] x86/snp, crypto: move SNP init to ccp driver Tycho Andersen
2026-03-17 16:21 ` [PATCH v3 5/7] x86/snp, crypto: move HSAVE_PA setup to arch/ Tycho Andersen
2026-03-23 15:47 ` Borislav Petkov
2026-03-17 16:21 ` [PATCH v3 6/7] crypto: ccp - implement SNP x86 shutdown Tycho Andersen
2026-03-21 8:44 ` Herbert Xu
2026-03-17 16:21 ` [PATCH v3 7/7] crypto: ccp - Update HV_FIXED page states to allow freeing of memory Tycho Andersen
2026-03-21 8:44 ` Herbert Xu
2026-03-23 15:49 ` [PATCH v3 0/7] Move SNP initialization to the CCP driver Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260323154417.GAacFf0X_UGizsaORY@fat_crate.local \
--to=bp@alien8.de \
--cc=Neeraj.Upadhyay@amd.com \
--cc=aik@amd.com \
--cc=ardb@kernel.org \
--cc=ashish.kalra@amd.com \
--cc=dave.hansen@linux.intel.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=hpa@zytor.com \
--cc=john.allen@amd.com \
--cc=kim.phillips@amd.com \
--cc=kvijayab@amd.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=nikunj@amd.com \
--cc=peterz@infradead.org \
--cc=seanjc@google.com \
--cc=tglx@kernel.org \
--cc=thomas.lendacky@amd.com \
--cc=tycho@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®