From: Yury Norov <ynorov@nvidia.com>
To: linux-kernel@vger.kernel.org, Bibo Mao <maobibo@loongson.cn>,
Huacai Chen <chenhuacai@kernel.org>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Tianrui Zhao <zhaotianrui@loongson.cn>,
WANG Xuerui <kernel@xen0n.name>,
Yury Norov <yury.norov@gmail.com>,
David Howells <dhowells@redhat.com>,
kvm@vger.kernel.org, loongarch@lists.linux.dev
Cc: Yury Norov <ynorov@nvidia.com>,
Andy Shevchenko <andriy.shevchenko@intel.com>
Subject: [PATCH] lib: count_zeros: unify count_{leading,trailing}_zeros()
Date: Mon, 23 Mar 2026 13:00:32 -0400 [thread overview]
Message-ID: <20260323170032.109858-1-ynorov@nvidia.com> (raw)
The 'leading' helper returns BITS_PER_LONG if x == 0, while 'trailing'
one returns COUNT_TRAILING_ZEROS_0, which turns to be -1.
None of the current users explicitly check the returned value for
COUNT_TRAILING_ZEROS_0, except the loongarch, which tests implicitly
for the '>= 0'.
So, align count_trailing_zeros() with the count_leading_zeros(), and
simplify the loongarch handling.
Signed-off-by: Yury Norov <ynorov@nvidia.com>
---
On top of bitmap-for-next.
arch/loongarch/kvm/intc/eiointc.c | 4 ++--
include/linux/count_zeros.h | 6 ++----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/arch/loongarch/kvm/intc/eiointc.c b/arch/loongarch/kvm/intc/eiointc.c
index d2acb4d09e73..3b5268116727 100644
--- a/arch/loongarch/kvm/intc/eiointc.c
+++ b/arch/loongarch/kvm/intc/eiointc.c
@@ -16,7 +16,7 @@ static void eiointc_set_sw_coreisr(struct loongarch_eiointc *s)
ipnum = (s->ipmap >> (irq / 32 * 8)) & 0xff;
if (!(s->status & BIT(EIOINTC_ENABLE_INT_ENCODE))) {
ipnum = count_trailing_zeros(ipnum);
- ipnum = (ipnum >= 0 && ipnum < 4) ? ipnum : 0;
+ ipnum = ipnum < 4 ? ipnum : 0;
}
cpuid = ((u8 *)s->coremap)[irq];
@@ -41,7 +41,7 @@ static void eiointc_update_irq(struct loongarch_eiointc *s, int irq, int level)
ipnum = (s->ipmap >> (irq / 32 * 8)) & 0xff;
if (!(s->status & BIT(EIOINTC_ENABLE_INT_ENCODE))) {
ipnum = count_trailing_zeros(ipnum);
- ipnum = (ipnum >= 0 && ipnum < 4) ? ipnum : 0;
+ ipnum = ipnum < 4 ? ipnum : 0;
}
cpu = s->sw_coremap[irq];
diff --git a/include/linux/count_zeros.h b/include/linux/count_zeros.h
index 5034a30b5c7c..b72ba3faa036 100644
--- a/include/linux/count_zeros.h
+++ b/include/linux/count_zeros.h
@@ -10,8 +10,6 @@
#include <asm/bitops.h>
-#define COUNT_TRAILING_ZEROS_0 (-1)
-
/**
* count_leading_zeros - Count the number of zeros from the MSB back
* @x: The value
@@ -38,11 +36,11 @@ static inline int count_leading_zeros(unsigned long x)
*
* If the LSB of @x is set, the result is 0.
* If only the MSB of @x is set, then the result is BITS_PER_LONG-1.
- * If @x is 0 then the result is COUNT_TRAILING_ZEROS_0.
+ * If @x is 0 then the result is BITS_PER_LONG.
*/
static inline int count_trailing_zeros(unsigned long x)
{
- return (x != 0) ? __ffs(x) : COUNT_TRAILING_ZEROS_0;
+ return x ? __ffs(x) : BITS_PER_LONG;
}
#endif /* _LINUX_BITOPS_COUNT_ZEROS_H_ */
--
next reply other threads:[~2026-03-23 17:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-23 17:00 Yury Norov [this message]
2026-03-23 17:10 ` Andy Shevchenko
2026-03-23 17:12 ` Yury Norov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260323170032.109858-1-ynorov@nvidia.com \
--to=ynorov@nvidia.com \
--cc=andriy.shevchenko@intel.com \
--cc=chenhuacai@kernel.org \
--cc=dhowells@redhat.com \
--cc=kernel@xen0n.name \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=loongarch@lists.linux.dev \
--cc=maobibo@loongson.cn \
--cc=yury.norov@gmail.com \
--cc=zhaotianrui@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome